Received-SPF: pass (google.com: domain of linux-kernel+bounces-177815-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 13 May 2024 17:17:20 +0100
From: Conor Dooley <conor@kernel.org>
To: Kanak Shilledar <kanakshilledar@gmail.com>
Cc: wahrenst@gmx.net, Mark Brown <broonie@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>,
	Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>,
	Kanak Shilledar <kanakshilledar111@protonmail.com>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: spi: brcm,bcm2835-spi: convert to
 dtschema
Message-ID: <20240513-shredder-renderer-80f888812467@spud>
References: <20240511061457.8363-1-kanakshilledar@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="iNrqzZLi0em8VcEV"
Content-Disposition: inline
In-Reply-To: <20240511061457.8363-1-kanakshilledar@gmail.com>


--iNrqzZLi0em8VcEV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, May 11, 2024 at 11:44:56AM +0530, Kanak Shilledar wrote:
> diff --git a/Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.yaml =
b/Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.yaml
> new file mode 100644
> index 000000000000..94da68792194
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/brcm,bcm2835-spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCM2835 SPI0 controller
> +
> +maintainers:
> +  - Florian Fainelli <florian.fainelli@broadcom.com>


> Signed-off-by: Kanak Shilledar <kanakshilledar@gmail.com>
> +  - Kanak Shilledar <kanakshilledar111@protonmail.com>

Why didn't you use protonmail for both?

Otherwise, this looks fine.

Thanks,
Conor.

> +  - Stefan Wahren <wahrenst@gmx.net>
> +
> +allOf:
> +  - $ref: spi-controller.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - brcm,bcm2835-spi
> +      - brcm,bcm2711-spi
> +      - brcm,bcm7211-spi
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    spi@20204000 {
> +        compatible =3D "brcm,bcm2835-spi";
> +        reg =3D <0x7e204000 0x1000>;
> +        interrupts =3D <2 22>;
> +        clocks =3D <&clk_spi>;
> +        #address-cells =3D <1>;
> +        #size-cells =3D <0>;
> +    };
> --=20
> 2.34.1
>=20

--iNrqzZLi0em8VcEV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZkI9EAAKCRB4tDGHoIJi
0jVvAQDreMdyauMLXm/MjQJ/ND97gubmJtVqz3KZ0m6Mgfy9MQD+IZ8qrPf5LryK
WZjiu6UhLbPIHSAPZ88qxmdKAbWpzAk=
=hu+c
-----END PGP SIGNATURE-----

--iNrqzZLi0em8VcEV--