Received-SPF: pass (google.com: domain of linux-kernel+bounces-177822-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 13 May 2024 17:22:54 +0100
From: Conor Dooley <conor@kernel.org>
To: Alina Yu <alina_yu@richtek.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	johnny_lai@richtek.com, cy_huang@richtek.com
Subject: Re: [PATCH v3 6/6] regulator: dt-bindings: rtq2208: Add property to
 get ldo of RTQ2208 is adjustable or not
Message-ID: <20240513-tissue-repave-13d2e3bf88fd@spud>
References: <cover.1715340537.git.alina_yu@richtek.com>
 <6a3a90d9aa2022dfb92e124e417f3e72c2f28b0b.1715340537.git.alina_yu@richtek.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="0Rzf6EampsUN2LBy"
Content-Disposition: inline
In-Reply-To: <6a3a90d9aa2022dfb92e124e417f3e72c2f28b0b.1715340537.git.alina_yu@richtek.com>


--0Rzf6EampsUN2LBy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 10, 2024 at 08:06:25PM +0800, Alina Yu wrote:
> Since there is no way to check is ldo is adjustable or not.
> As discussing in v2 series, 'richtek,fixed-microvolt' is added for that.
> user is supposed to know whether vout of ldo is adjustable.
>=20
> Signed-off-by: Alina Yu <alina_yu@richtek.com>
> ---
>  Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml | 8 +++=
+++++
>  1 file changed, 8 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/regulator/richtek,rtq2208.=
yaml b/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml
> index 609c066..6212f44 100644
> --- a/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml
> +++ b/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml
> @@ -75,6 +75,13 @@ properties:
>          description:
>            regulator description for ldo[1-2].
> =20
> +        properties:
> +          richtek,fixed-microvolt:
> +            description: |
> +              If it exists, the voltage is unadjustable.
> +              There is no risk-free method for software to determine whe=
ther the ldo vout is fixed or not.
> +              Therefore, it can only be done in this way.
> +
>  required:
>    - compatible
>    - reg
> @@ -177,6 +184,7 @@ examples:
>              };
>            };
>            ldo1 {

> +            richtek,fixed-microvolt =3D <1200000>;
>              regulator-min-microvolt =3D <1200000>;
>              regulator-max-microvolt =3D <1200000>;

I'm dumb and this example seemed odd to me. Can you explain to me why
it is not sufficient to set min-microvolt =3D=3D max-microvolt to achieve
the same thing?

Cheers,
Conor.

--0Rzf6EampsUN2LBy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZkI+XgAKCRB4tDGHoIJi
0teoAP0deskjwTQhQkwFkOEF3YwHdE/UPQPpoXblTyQcsq2YKAD+JWsBhF6E1eTE
vJixXEaTaIbjTD3RYNjy9OvMwTWmWwY=
=GwZ0
-----END PGP SIGNATURE-----

--0Rzf6EampsUN2LBy--