Received-SPF: pass (google.com: domain of linux-kernel+bounces-177833-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 13 May 2024 12:25:19 -0400
From: Phil Auld <pauld@redhat.com>
To: Paul Sherwood <paul.sherwood@codethink.co.uk>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
	bristot@redhat.com, vschneid@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/deadline: Fix grammar and typos in comments
Message-ID: <20240513162519.GC9998@lorien.usersys.redhat.com>
References: <20240511082644.44757-1-paul.sherwood@codethink.co.uk>
 <20240513135812.GA9998@lorien.usersys.redhat.com>
 <ef7021835015a5bdd5bf5404ee712853@codethink.co.uk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ef7021835015a5bdd5bf5404ee712853@codethink.co.uk>

On Mon, May 13, 2024 at 04:19:10PM +0100 Paul Sherwood wrote:
> On 2024-05-13 14:58, Phil Auld wrote:
> > On Sat, May 11, 2024 at 09:26:44AM +0100 Paul Sherwood wrote:
> > > - conjugate verb to match subject of sentence
> > > - s/a entity/an entity/g
> > > - s/this misbehave/this misbehaviour/
> > > - a few typos
> > > 
> >   - not starting all the lines of a commit message with "-", priceless.
> > 
> > Plus, you're just repeating what's in the actual patch.
> > 
> > Otherwise, these changes themselves look good to me.
> 
> Thanks for the feedback - would you like me to re-submit without the
> bullet-points, or without the text entirely?
>

Personally I'd rather a sentence or two saying something like
"Fix some types and grammar issues in sched deadline comments."
Or something.  I know that's basically same as the title, but
that gets lost in the subject line, so maybe worded a little
differently? For this it probably doesn't need much but does
need something. 

I'm not the one to merge it though so I don't know if the
maintainer wanted to just fix it up at the time.   Just my
opinion...


For the changes themselves, fwiw,

Reviewed-by: Phil Auld <pauld@redhat.com>


Cheers,
Phil

> br
> Paul
> 

--