To: Adrian Bunk <bunk@kernel.org>
Subject: Re: Mostly revert "e1000/e1000e: Move PCI-Express device IDs over       to e1000e"
Cc: akpm@linux-foundation.org, auke-jan.h.kok@intel.com, davem@davemloft.net,
       jeff@garzik.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
       randy.dunlap@oracle.com, torvalds@linux-foundation.org
In-reply-To: <20080130235836.GV29368@does.not.exist>
References: <200801292359.m0TNxb75011826@hera.kernel.org> <20080129212314.91b9bb5b.randy.dunlap@oracle.com> <alpine.LFD.1.00.0801301631400.3426@www.l.google.com> <20080130235836.GV29368@does.not.exist>
Message-Id: <E1JKOBl-0007ne-EE@faramir.fjphome.nl>
From: Frans Pop <elendil@planet.nl>
Date: Thu, 31 Jan 2008 02:26:01 +0100
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1515
Lines: 42

Adrian Bunk wrote:
>> Jeff, Auke, would something like this be acceptable? It makes it very
>> obvious in the driver table which entries are for the PCIE versions that
>> would be handled by the E1000E driver if it is enabled..
> 
> I don't like it:
> We should aim at having exactly one driver for one card.

There is one thing I don't understand, but that may well be just me...

>From Linus' original patch:
> +++ b/drivers/net/e1000/e1000_main.c
> +     INTEL_E1000_ETHERNET_DEVICE(0x108C),

So, apparently support for 8086:108c was removed from the e1000 driver.

>From my lspci:
$ lspci -nn | grep Ether
01:00.0 Ethernet controller [0200]: Intel Corporation 82573E Gigabit Ethernet Controller (Copper) [8086:108c] (rev 03)

But when I look at where that card is sitting:
$ readlink pci/devices/0000\:01\:00.0/driver
../../../../bus/pci/drivers/e1000

So, it's on the PCI bus, not on the PCI-Express bus (which I also have, but
which has no devices on it).

Or does the e1000e driver also support cards on the PCI bus?

If that's the case then the original changelog entry "Move PCI-Express
device IDs over to e1000e" is misleading as it's not only PCI-Express
devices...

Hmmm. Or does which driver is loaded decide on which bus the device ends up?

Confused,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/