Received-SPF: pass (google.com: domain of linux-kernel+bounces-177886-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Sender: Tejun Heo <htejun@gmail.com>
Date: Mon, 13 May 2024 07:17:18 -1000
From: Tejun Heo <tj@kernel.org>
To: Aaron Tomlin <atomlin@atomlin.com>
Cc: Wenchao Hao <haowenchao2@huawei.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	linux-kernel@vger.kernel.org, Wenchao Hao <haowenchao22@gmail.com>,
	neelx@redhat.com
Subject: Re: [RFC PATCH] workqueue: Fix rescuer task's name truncated
Message-ID: <ZkJLHtiGb6XM4iMO@slm.duckdns.org>
References: <20240423182104.1812150-1-haowenchao2@huawei.com>
 <uo54qjyy7zts6nyxb2sfsxnh6lma4ezoybr7qc7da5k77rwoig@sj2a4wgfmcgu>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <uo54qjyy7zts6nyxb2sfsxnh6lma4ezoybr7qc7da5k77rwoig@sj2a4wgfmcgu>

Hello

On Sat, May 11, 2024 at 03:15:11PM +0100, Aaron Tomlin wrote:
> > @@ -5439,6 +5439,8 @@ static int init_rescuer(struct workqueue_struct *wq)
> >  		return ret;
> >  	}
> >  
> > +	snprintf(rescuer->desc, sizeof(rescuer->desc), "%s", wq->name);

Can you please address the testbot reported warning?

> >  	wq->rescuer = rescuer;
> >  	if (wq->flags & WQ_UNBOUND)
> >  		kthread_bind_mask(rescuer->task, wq_unbound_cpumask);
> > @@ -6289,6 +6291,8 @@ void wq_worker_comm(char *buf, size_t size, struct task_struct *task)
> >  						  worker->desc);
> >  			}
> >  			raw_spin_unlock_irq(&pool->lock);
> > +		} else if (worker->desc[0] != '\0') {
> > +			scnprintf(buf + off, size - off, "-%s", worker->desc);
> >  		}
> >  	}
> >  
> > -- 
> 
> Reviewed-by: Aaron Tomlin <atomlin@atomlin.com>

The patch looks fine to me otherwise.

Thanks.

-- 
tejun