Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp2201775lqo; Mon, 13 May 2024 10:37:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU15XPxHazwQlbec1hUWf68TMXaLfQ4jl7c1uQQsDj6Onf2WPYxR9S7BkLlGPms1wV2UsOsRVqv84vGZKXUYlF0WNPhA+kQVKjv+G9g0g== X-Google-Smtp-Source: AGHT+IEWxe0RBanpMzPYvS2yi+M0gAD1tiKzpGi8h78ykUjRJUgzboA7OpS4/wzyhnHkwH+FqYVa X-Received: by 2002:a05:6a20:d807:b0:1af:f927:55db with SMTP id adf61e73a8af0-1aff9275760mr3089973637.59.1715621844766; Mon, 13 May 2024 10:37:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715621844; cv=pass; d=google.com; s=arc-20160816; b=LY8N67CtDT7MziQxj9hI7sNNV7zGBWP6O0EGKiaEi68NpXhjNE+r+VwtVyxjLe8SJB Xq73u9p+lhmHvgLi0aG7cDD5x5b+kWoFz+G7XbdTsp3UqX3dFcnBGTnQBVp6lWb7DsHY SOekOA1iTPtJxCzChfO8ik4fFM9FMzn/zg93sGipeR2JEeC3fulZPUmw/Y03GiKB2wfg fzT3h0DzFc2+Osbs+nLbKimqCaITZ8odfxDMoT/5ag88X8O3oLxpvPEzZIKBEbiVU3z0 G3S2EBUwc0NxBhodMV+Ds42LeSA8ksU6nP51S0jJJdmfWNmmPIMOJq+20MK0WmDGuBO8 ZRBg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=pGKgSqj8FhjNUqw99/xj+RkQSPtYlnoIACWc6isu8ZY=; fh=Ls+WCXZnPKU4EypcEkdv6zYBZD3K3neU5sN9Z4lDEO4=; b=n7P/sVRkaOgjAgJ/t0UoG3Wy2V35t1IRLkehKxQgplKRsV8ozP+G5lEWf1AETF7VGn 38O1uAIfdm2rT0SXhH96zKGqfk+c20afM0lfhVLy8OR3yy0F+UiV5onp/BJ4m48hDWRX dhx7VXpIhQ3lSti1GVmyhwu80pbmBX3M/woRElRaOCz/q75zGhO2EMqHhK7elWbjNd7v +72VB8CbSi/1fCm38dotxsQy+N8ui+zonuIyNsWbFsg0LFl2tVcsYg+xYGEt4b6NCL3O xoJA8kaogBm9xM9sncnrt3ZyHcrO4u+OZOkeT9Wo7XNVRlMqJOwgptQwI1WsK9vAsaPE pVKg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eSftEmFq; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-177918-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-177918-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d2e1a72fcca58-6f4d2a72b8fsi9604492b3a.54.2024.05.13.10.37.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 10:37:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-177918-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eSftEmFq; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-177918-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-177918-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4CD2B280F29 for ; Mon, 13 May 2024 17:37:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CD5C03C060; Mon, 13 May 2024 17:36:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eSftEmFq" Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DA48249F5 for ; Mon, 13 May 2024 17:36:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715621783; cv=none; b=EJkGmX05RXsG+Q6smMssf64R+ylfuCCf/wkzg3FxPY3EZa/QFpJVz1NapqY6CAqS3Wqr5a8/rS8MCI79aiPC1WCxdHHTD4J6HeFrNvoXf/7NZKFFZ7nNDB4AAaGN1Wvdqliz8qCDIfqW2w7h4ZReUsc3WPtD8uK3xu2S5feKI74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715621783; c=relaxed/simple; bh=oH3eGcg4uKDc8mJeYWQzOH+FxQ/v/Qtu4+nq1oVpYYs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jJTxn5LXu5Rq22OkcJVzafTXMvrOlZNNMNrU1jsyyPKXEZ1NDYefe1A8WfpvIIpRSNgutq5UPDzhABWRu9m/G14vG1/EmVruHZfks/WVr3bLdEyR0Uq7VkuWHwWk+A8NKgRB/F2CwApBQj8KIFcvzmf1CTM7tpQC9r+aaHDbc8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=eSftEmFq; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a59cdd185b9so975900366b.1 for ; Mon, 13 May 2024 10:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715621780; x=1716226580; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pGKgSqj8FhjNUqw99/xj+RkQSPtYlnoIACWc6isu8ZY=; b=eSftEmFqW1YChOo6/qPPW3uAfbbtzDNBC4yYrZUJrvxSKIZBdG9Z9NV7Z2zSj92oOK 0ZKZIxYypZyafV9L4h+4IDx7ne7mfiGKdN6dA/uMKwnUb1GIpoQYRd47L+a8MxE4VL+P 5dgkY7x7JWBT4vDArGWwBFwfUuIQcaO8sqO6XoMYI4xXzH4VQNSB4eCTnZ1CMWvzUZYH Otbo79R3LWQbHPpG+PE4bso5db+UD+MQM608imPTn1SAAjM3ux1rVTOI7UlfMiSFTE9F L9zWyO6/EH5f/kwO2WljmJSNWh4EJF3hQsbx51N9xnrZ14rUBJ03SsKzp0dasOE95kTa eVew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715621780; x=1716226580; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pGKgSqj8FhjNUqw99/xj+RkQSPtYlnoIACWc6isu8ZY=; b=mToiu72gBCHM0Ge3qT3YQQQ+CSY9IX6dRRH/GLrsfwqJuYZf397RezCXXBKjEGpXKd CGbw/HI0hglSsfr9MrDElN7DyfHHHAk9JwgF9jBP27Ry1YYbqgaFEOnq2oHQnlq+2tqR iHgeetUQNsXNhDGOO+yCUGW14JsnXQ5iUwmoOiDKUYYQMuQhQc1z3zkkMheSa7qL+Z7S YEjMp0yeGh4EPMbMzS4cO5+j68gtKoA2Fc42XosvqDlqBHOHkZ46gFUg3e7e43Ajr3Xc k2yeZEA1UkOS60J7UW5T437vz7m5rv1i03Tw6RVIRtp77ymHikwUUaMQKCCoQ6n5WcKB rNjg== X-Forwarded-Encrypted: i=1; AJvYcCU0xi5XDpBaRvzkuSM5KPk2qO+Jtr6wFmlWxsA1BtoWZGSRPZO6niO9Ur2SE/Szhqyyt3NIf2lr2hHScPrLJTt2UAaF+FjpV+HcBv7Z X-Gm-Message-State: AOJu0Yy2KU6HIgfhshnAtfJDyrGjoVpvIqtalEPLbVfAn2DIhNO9R6/i UHFX6DxHfpr21pwjU34QHUsscPe2zNEnIxnEvIUA+465YJ2h1FFeljaHF+EM4N4= X-Received: by 2002:a17:907:2d09:b0:a55:5520:f43f with SMTP id a640c23a62f3a-a5a115ef93dmr1376985466b.10.1715621778926; Mon, 13 May 2024 10:36:18 -0700 (PDT) Received: from [10.1.3.28] ([149.14.240.163]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a5a17b01932sm618072366b.168.2024.05.13.10.36.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 May 2024 10:36:18 -0700 (PDT) Message-ID: <55ce4e31-4134-40fe-8e94-28392863886a@linaro.org> Date: Mon, 13 May 2024 18:36:16 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/8] media: qcom: camss: Attach formats to VFE resources To: "Gjorgji Rosikopulos (Consultant)" , Vladimir Zapolskiy , rfoss@kernel.org, todor.too@gmail.com, andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com, hverkuil-cisco@xs4all.nl, quic_hariramp@quicinc.com References: <20240411124543.199-1-quic_grosikop@quicinc.com> <20240411124543.199-3-quic_grosikop@quicinc.com> <9ac41841-9281-4867-a607-e3883f32db83@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <9ac41841-9281-4867-a607-e3883f32db83@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/05/2024 16:35, Gjorgji Rosikopulos (Consultant) wrote: > I agree but i would propose to have next series for cleanup up patches, > Otherwise we will have to many changes across the files. So, I missed these plats in the code, thanks for spotting. I'd like to get the header SPDX and style stuff Vlad highlighted fixed in a V4 of this series. However given the amount of effort required to verify these changes, I'd rather avoid data-structure and/or logic changes at this stage. --- bod