Received-SPF: pass (google.com: domain of linux-kernel+bounces-177927-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <CAHx5RXBfazB62qpbGGK3_YjwCFbiJbEXrgo88V6qHFdTW1CdRQ@mail.gmail.com>
 <338daebd-b4af-4a0c-951a-ad7f86dc4646@gmail.com> <CAHx5RXAOKBGXRgC8pqEyY3MZGXxj0-vrwnqg_WZqKreYp18dAg@mail.gmail.com>
 <7efffaa0-6330-4b01-b3d2-63eb063cbbb0@gmail.com> <CAHx5RXD8qFmbEytrPcd40Pj0VRo7uOvZjucrMj6Xxqw73YyS1Q@mail.gmail.com>
 <212a9464-d52b-4730-95b9-5a0aebd38c91@gmail.com> <CAHx5RXCWW5M-eW5v65bAkQWZemsU2NTvDv3jA9_XKz=+YP56Qg@mail.gmail.com>
 <688e54ec-3b29-4e3b-a2c3-f2c83b9c97b7@lunn.ch>
In-Reply-To: <688e54ec-3b29-4e3b-a2c3-f2c83b9c97b7@lunn.ch>
From: Stephen Langstaff <stephenlangstaff1@gmail.com>
Date: Mon, 13 May 2024 18:40:19 +0100
Message-ID: <CAHx5RXBFdzsgKXR94gdZd2b=uz8PJDg4OjLPJxKtsdhcjJq3Qw@mail.gmail.com>
Subject: Re: drivers/net/dsa/dsa_loop_bdinfo.c build problems
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>, linux-kernel@vger.kernel.org, 
	"OlteanV@gmail.com" <OlteanV@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 13, 2024 at 5:54=E2=80=AFPM Andrew Lunn <andrew@lunn.ch> wrote:
> As Florian pointed out, dsa_loop_bdinfo.o should be built into your
> kernel. When you insmod dsa_loop.ko, it should match the data in
> dsa_loop_bdinfo to the dsa_loop driver an instantiate an instance of
> it. Do you see that happening?

Well, if I fiddle with the Makefiles to get dsa_loop_bdinfo built as a
module (as opposed to not building at all) then I see the following
behaviour:

root@machine:~/dsa_test# ls
dsa_loop.ko  dsa_loop_bdinfo.ko
root@machine:~/dsa_test# modprobe dsa_core
root@machine:~/dsa_test# insmod dsa_loop_bdinfo.ko
root@machine:~/dsa_test# insmod dsa_loop.ko
root@machine:~/dsa_test# lsmod
Module                  Size  Used by
dsa_loop               16384  0
dsa_loop_bdinfo        16384  0
dsa_core              118784  1 dsa_loop
..

..and I see no new interfaces reported by ifconfig -a
[just the existing eth0, eth1 and lo0 interfaces]

I will revert my changes to the Makefiles and confirm that
dsa_loop_bdinfo.o does not get built into the kernel - that's an
overnight build for me so bye for now!