Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp2204360lqo; Mon, 13 May 2024 10:43:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW7zLVd//SAUpqrW6b7pRuYvHwDaxONSKPCi2NwcABHFOxTB4i2stq8n+hauOY5zIqgaz7UM848y4Ed/v6N2slzg7GMtkxZDG5/paNqGw== X-Google-Smtp-Source: AGHT+IFKC7nHsuM+JDwxLqLrGXhr3xZNZoINO3rDnx7tzLBAee4mE3ukP1djHE2P9qcltWBcwxb4 X-Received: by 2002:ad4:4528:0:b0:6a1:68e9:5700 with SMTP id 6a1803df08f44-6a168e958damr90959356d6.6.1715622212443; Mon, 13 May 2024 10:43:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715622212; cv=pass; d=google.com; s=arc-20160816; b=odUafceyBDYz0teXHzptN+FxKKjKMomRfrBU1ZUcsbo6I8nCA4xTYl4uSYv6vcm3Df 9Izl62Bv8jDYHmJ7lZS5tyXc2+d6yWZVYK0ZK1jwL7QkXN/UvSl8speHAMBh4R9wCdaL hYY5Ka0fyaKoHvegBcwo2aVMNx345UwUn4rQyPvE4sneJ5zdInFsdKm2EABLbtmUvUiU LIv54MAHBz2jsRG3fJh+4u0OWKmCyR0vzi/qSKiXLqygiYGAdc6VIqMiQ78X5fGi2Zrv /bO0C9EckWqvmzuSYSbI4EJb9m+q9sgL581qyD50GikGm8gFqi+18H7scZ4Mi/h3bpZe fTkw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=CejXXsjOA3SIu2w4YNwZ/Z+ltOoM4sfK/JZcNG8ud/g=; fh=UiqJ6U0BhgKH7XXt6E2YlMwweUI3U204sabYu0fDGss=; b=HpDvboshkjMpZwYOlz+rwHD6jMifhCQXlsJMHHfk1tCb8lGpanlOPAUIZQxTJJWxQS nXgchrUwOwnsAerBTp76FKFDaz9q4U6igXIPqrC9Z6VF58C7yHJbGOPcenO0Zp3N6feh hfGpcmrVElZZT+SC04fkpRCFR5El4AJFXzIUG+1ST+Tv3C3FM+wkzw+nNLvsq6/j4k8i n3dc3mz3kawpLXj+lBh5wM2PR8p5AMNYjLDM6aauKcd+bAY5tcL8qFvod6buBGlKXKvf iYzHLrNqXFxfK/M/KVJPK51K5EoKCpiUKttE/UtHh3+RDYq4PVYLJMLOkc0dDasU8ncq A/9Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=J98GTKTw; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-177931-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-177931-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 6a1803df08f44-6a15f2069basi100427136d6.160.2024.05.13.10.43.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 10:43:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-177931-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=J98GTKTw; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-177931-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-177931-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D65FC1C20D42 for ; Mon, 13 May 2024 17:43:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AEF922940B; Mon, 13 May 2024 17:43:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="J98GTKTw" Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EDE22E3EE for ; Mon, 13 May 2024 17:43:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715622201; cv=none; b=PC98ONdzW5P+AEENHRk63Rc7UqxAnyOWqeqNCLIGS/2mAbbjkmBO9cvNTXJNypsqqeMugcYLwv8Xk4feEaSBnlXo9z8SQSWKIO+TwCt6k199Iu0g/rF4zl9xoT81PwrrRnkkPA77wclE6okMwt5tBY5tQorU7PT27lJIlLQ+U7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715622201; c=relaxed/simple; bh=CejXXsjOA3SIu2w4YNwZ/Z+ltOoM4sfK/JZcNG8ud/g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gfYc1MsV0pomms70K05KAVBJhdTSIaERJ5V7Sy6nPFnGL0af+nkJbmyvoMo6E8F75eSfp1vCaIOCccOa0D1Gsq39rpDD828nbx3o1R+TUNANg84vC8mhm7p977+7FzLSDmrk3y/62CeQK1nq2iaqydi15bTtpXzNIoAWl/saC50= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=J98GTKTw; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a5a4bc9578cso541043266b.2 for ; Mon, 13 May 2024 10:43:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715622198; x=1716226998; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CejXXsjOA3SIu2w4YNwZ/Z+ltOoM4sfK/JZcNG8ud/g=; b=J98GTKTw3D0z+xU+CR0UUBU22I88kwuahpsOh4pPHBwWv3JURsu2HOPNfYFy4ZZtrd lC5SteOWQUt1FKTWrrdT4U92QnltFp7dd70V5klAerhRgqi7AfCCvvtK51vXZQfwuSQC Hc1b+CrNHtskuouFlp9CV9RQdOSLlrbXF/A+z7HlA6yY93R5Wd9B3ks8Tw+G+2Lklv4b 1U13sUshsYRhDVlzVIUMOIF34ADSR3IfqiGWnvQmfyqJoAkHM9gxdGXzs08s+fgXkEvP QC5kBEMTyI0C2EJgKJTEwYt9x7sVJPgtJxB/V+RKlUrN7XhX3Mf8aQXm9TjGoKFcsi4s 2Ocg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715622198; x=1716226998; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CejXXsjOA3SIu2w4YNwZ/Z+ltOoM4sfK/JZcNG8ud/g=; b=owfGm2SkjSWoLFkdgwcn5NtxlyrTvgJOQrIH1ZzLff+CNDvRTi3Gwy4EmxYaBcKMWj dfzVFfZjn8mWkHuByn8S1XAiqwVkzSbC8q+5XBNtTNhpBvZ7gCrVkir78DAeoDe2Td+t rvX7vHLyExA9EQs2p2erOPC50MUYawGbTeGs7fZnC0++DVWF6b5gaZaKaNfsSwFVgXuH e01Y5wvOV4KbNMpzL8lQSreUQP5MIlkWLcYvf94r9R/m3396ZwNZRSvdSj/iXrtUSFyC K1eGT6Oatw0vGGqgFJXSz7P3kqmVYsfeEoB7+Y1SfKk04YjTpDRkySklUOdk5rNOzAuk bdtg== X-Forwarded-Encrypted: i=1; AJvYcCUt7jtkUWAE1NPckzBNzoNnXB6GMBWWvZh3cSIi9CO5Uzhfc+zGhhxH5DoowGNULBJyQw47sqxsL/NKgLknx8UbyifklMrRMaNmmOQi X-Gm-Message-State: AOJu0Ywm6lkJHJmfgHwu0wN61aD0RWgg/IH4nHLiehj4O8qPF2w2EG24 WByuLWr8Ik9Y1+6IBoCWMHL24EGrNlGlK9IUugstP3mE8ApNcnfC78tKHNWlfC4= X-Received: by 2002:a50:bb0f:0:b0:56f:e7b9:e67d with SMTP id 4fb4d7f45d1cf-5734d5cec3bmr11655801a12.12.1715622198507; Mon, 13 May 2024 10:43:18 -0700 (PDT) Received: from [10.1.3.28] ([149.14.240.163]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5733c2b8f7fsm6393355a12.66.2024.05.13.10.43.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 May 2024 10:43:18 -0700 (PDT) Message-ID: <12bfcd12-28ef-4fa9-9a46-f370bdb4cce8@linaro.org> Date: Mon, 13 May 2024 18:43:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/8] media: qcom: camss: Move format related functions Content-Language: en-US To: "Gjorgji Rosikopulos (Consultant)" , Vladimir Zapolskiy , rfoss@kernel.org, todor.too@gmail.com, andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com, hverkuil-cisco@xs4all.nl, quic_hariramp@quicinc.com References: <20240411124543.199-1-quic_grosikop@quicinc.com> <20240411124543.199-6-quic_grosikop@quicinc.com> From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/05/2024 17:52, Gjorgji Rosikopulos (Consultant) wrote: >> 0 as an error condition indicator is not very common, at least it shall be >> documented in the comment. > The original function was vfe_find_code. This change moves all format > related functions across the sub-device files to camss-format > I believe that 0 is default format For this series changing the result code is extraneous, agree. We can debate such a change in a standalone patch on its own merits. --- bod