Received-SPF: pass (google.com: domain of linux-kernel+bounces-177978-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Valentin Schneider <vschneid@redhat.com>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org, "Paul E. McKenney"
 <paulmck@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Neeraj
 Upadhyay <quic_neeraju@quicinc.com>, Joel Fernandes
 <joel@joelfernandes.org>, Josh Triplett <josh@joshtriplett.org>, Boqun
 Feng <boqun.feng@gmail.com>, Steven Rostedt <rostedt@goodmis.org>, Mathieu
 Desnoyers <mathieu.desnoyers@efficios.com>, Lai Jiangshan
 <jiangshanlai@gmail.com>, Zqiang <qiang.zhang1211@gmail.com>
Subject: Re: [PATCH v2 26/27] rcu: Update stray documentation references to
 rcu_dynticks_eqs_{enter, exit}()
In-Reply-To: <ZjuSTC0sZvuqx57r@localhost.localdomain>
References: <20240430091740.1826862-1-vschneid@redhat.com>
 <20240430091740.1826862-27-vschneid@redhat.com>
 <ZjuSTC0sZvuqx57r@localhost.localdomain>
Date: Mon, 13 May 2024 20:40:20 +0200
Message-ID: <xhsmhseylh7xn.mognet@vschneid-thinkpadt14sgen2i.remote.csb>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 08/05/24 16:55, Frederic Weisbecker wrote:
> Le Tue, Apr 30, 2024 at 11:17:30AM +0200, Valentin Schneider a =C3=A9crit=
 :
>> rcu_dynticks_eqs_{enter, exit}() have been replaced by their
>> context-tracking counterparts since commit:
>>
>>   171476775d32 ("context_tracking: Convert state to atomic_t")
>>
>> Update the stray documentation references.
>>
>> Signed-off-by: Valentin Schneider <vschneid@redhat.com>
>> ---
>>  .../RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.rst   | 4 ++--
>>  Documentation/RCU/Design/Memory-Ordering/TreeRCU-dyntick.svg  | 4 ++--
>>  Documentation/RCU/Design/Memory-Ordering/TreeRCU-gp-fqs.svg   | 4 ++--
>>  Documentation/RCU/Design/Memory-Ordering/TreeRCU-gp.svg       | 4 ++--
>>  4 files changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Or=
dering.rst b/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Order=
ing.rst
>> index 0533814a1f69a..50fc99aba777f 100644
>> --- a/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.=
rst
>> +++ b/Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.=
rst
>> @@ -147,8 +147,8 @@ RCU read-side critical sections preceding and follow=
ing the current
>>  idle sojourn.
>>  This case is handled by calls to the strongly ordered
>>  ``atomic_add_return()`` read-modify-write atomic operation that
>> -is invoked within ``rcu_dynticks_eqs_enter()`` at idle-entry
>> -time and within ``rcu_dynticks_eqs_exit()`` at idle-exit time.
>> +is invoked within ``ct_kernel_enter_state()`` at idle-entry
>
> Looks like ct_kernel_exit_state().
>
>> +time and within ``ct_kernel_exit_state()`` at idle-exit time.
>
> And ct_kernel_enter_state()
>
>>  The grace-period kthread invokes ``rcu_watching_snap()`` and
>>  ``rcu_watching_changed_since()`` (both of which invoke
>>  an ``atomic_add_return()`` of zero) to detect idle CPUs.
>> diff --git a/Documentation/RCU/Design/Memory-Ordering/TreeRCU-dyntick.sv=
g b/Documentation/RCU/Design/Memory-Ordering/TreeRCU-dyntick.svg
>> index b57210ecd689e..c7d16b72f0973 100644
>> --- a/Documentation/RCU/Design/Memory-Ordering/TreeRCU-dyntick.svg
>> +++ b/Documentation/RCU/Design/Memory-Ordering/TreeRCU-dyntick.svg
>> @@ -607,7 +607,7 @@
>>         font-weight=3D"bold"
>>         font-size=3D"192"
>>         id=3D"text202-7-5-3-27-6"
>> -       style=3D"font-size:192px;font-style:normal;font-weight:bold;text=
-anchor:start;fill:#000000;stroke-width:0.025in;font-family:Courier">rcu_dy=
nticks_eqs_enter()</text>
>> +       style=3D"font-size:192px;font-style:normal;font-weight:bold;text=
-anchor:start;fill:#000000;stroke-width:0.025in;font-family:Courier">ct_ker=
nel_enter_state()</text>
>
> ct_kernel_exit_state()
>
>>      <text
>>         xml:space=3D"preserve"
>>         x=3D"3745.7725"
>> @@ -638,7 +638,7 @@
>>         font-weight=3D"bold"
>>         font-size=3D"192"
>>         id=3D"text202-7-5-3-27-6-1"
>> -       style=3D"font-size:192px;font-style:normal;font-weight:bold;text=
-anchor:start;fill:#000000;stroke-width:0.025in;font-family:Courier">rcu_dy=
nticks_eqs_exit()</text>
>> +       style=3D"font-size:192px;font-style:normal;font-weight:bold;text=
-anchor:start;fill:#000000;stroke-width:0.025in;font-family:Courier">ct_ker=
nel_exit_state()</text>
>
> ct_kernel_enter_state()
>
> etc...

Yes indeed, I shoved the sed the wrong way around :( Thanks!