Received-SPF: pass (google.com: domain of linux-kernel+bounces-178002-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <1b03ba34-ac06-47ed-9086-f8d346a20bb1@amd.com>
Date: Tue, 14 May 2024 01:59:33 +0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/9] iommu/amd: Introduce helper functions for managing
 IOMMU memory
Content-Language: en-US
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux.dev, joro@8bytes.org,
 thomas.lendacky@amd.com, vasant.hegde@amd.com, michael.roth@amd.com,
 jon.grimm@amd.com, rientjes@google.com
References: <20240430152430.4245-1-suravee.suthikulpanit@amd.com>
 <20240430152430.4245-2-suravee.suthikulpanit@amd.com>
 <20240501161741.GG1723318@ziepe.ca>
From: "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
In-Reply-To: <20240501161741.GG1723318@ziepe.ca>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eTBFU1R1YXpQMFBFdE9Jakk4WDZuU01SeDJSaXhSS0RLS29YZitOQTJYVmdH?=
 =?utf-8?B?RzA5bHlNZkpSLzFjL0pYYTcvSmNGdVFrY1U1bUJIRUk2THpOblZPdTdNQkhl?=
 =?utf-8?B?VjBMaE9kWW1nWFZleEtwSWM4SGQvV29vQW1Zc2dOb3JhM1pLT0RURFl4SHhU?=
 =?utf-8?B?Q2tDUEtGSnlnbnVRS0p5ZDVETDhnN1N0L2hsU1hXTC9SRzZFaDRzclVScmtD?=
 =?utf-8?B?NCt3TlhSOEgyZ3Z3UFJoOEV6TElqSk1jWVFZTTQrY2MrNHc3UlhhN2NlVTVW?=
 =?utf-8?B?L2VpZDk3dFVQaFRxVWVZWEJGRzFiT1N6VDFxMjhJUHBqQ0pFdWZBWTAyUlJo?=
 =?utf-8?B?amh0bmN0UFhwa3V6eHlHWkp4MWtLVmdHRUdmRExOckVlaXZ2djQxVTMrWEdp?=
 =?utf-8?B?d3dkcThiblhBallzSXVlNkNQN0FRdmY4L0I1TE1YcUpFa2ovZnFCc254Sm9Q?=
 =?utf-8?B?SmFiZmExOVpQOGdnUEN4NzQwbUNubDQ0bTVMYTB3a2ROTXlOdW8xbG5yNExk?=
 =?utf-8?B?OGNkdmpYUXFpZG5PRktnTjh3dG81ZENzNjFrZVpwQXpjM3RDSDc2Tk0wNXc0?=
 =?utf-8?B?YkUzSDJVcEFMaU9NVmNJRGI4aVd5OXNzL3I0b0YwUGdnbHgwdlVKekx2RkN4?=
 =?utf-8?B?UFpYWG1INms3VlhHdXR3bys1VkZEd2pib25XQTFER0ZmV2JTMDBuUHZkM3JU?=
 =?utf-8?B?bkpmT1ZNSEdHZ3BsYzBsOTQ5SDhEMndObTFvUE5xSm5RQ3pid29yTkxJK0N0?=
 =?utf-8?B?MlVtTlJNNlhwc3A3SVU2U3QvZEhTd0treTlVcWsxclNsbXF2Szl6YkI3VUdK?=
 =?utf-8?B?eEJCRFA0SzFGaXVTR0pMYTExNnk3YzVpSDVCMms5R1kwellMa0ZIUzVIRTN4?=
 =?utf-8?B?ejBnOU44eEtkZmVqQ2RxamVLZ2ZlNENEMjd1cHpJTk5YNk1HV20wcGp2Mlkz?=
 =?utf-8?B?ak9rYUZjaWV2cktUbytSOE9yT1VmU2dNb1pVMXBsSG5VbnZ4YzRjUW9Xc28x?=
 =?utf-8?B?dE5NTU9LN0d3ZW4vOXJTTzI4dG5JUnNjbmU0Wi9nYlZWemVkc1lWUmRVL0Fn?=
 =?utf-8?B?N05KSC9QMGt0SWlrRm1qNU4zditQNWcwNGNGWkJkZFpZWFdwRWdXSERVamNn?=
 =?utf-8?B?d0x6eTRpV1RuUmsxOGpvTWNXb3paMytONVEzMHVlcnBwYlRscksveERaWE0w?=
 =?utf-8?B?RERGSFdreUlxc29UN2FDQi91bFdkcVpxTFhwNlUwRVhJdjJzZE53TXRZclpm?=
 =?utf-8?B?dlhPZWJJV0JiZU5nRFh6a09zbVBOUGlDWVBMVDFSU2hmeGRySUtIN2huTzZK?=
 =?utf-8?B?OXdVREdadm1OL0haN0NDakdxZ3VDWHg2Vm1rcEVzNnV4NjlFbFAvL2s5cW9k?=
 =?utf-8?B?Mm1FS0hSYktlaHRiWml1NjU0RTZKVWVKQ2VNaWlLNzBHdmRRdFg0ZlRPQ3FH?=
 =?utf-8?B?eVJtUUt0dkNmVE5yZ2NvVUxWZVA3eko2TWlnTkJHL1d3aG9PdlZqMlcwQnR6?=
 =?utf-8?B?Y3QrS0VsdDJwZXRkOFJhT1k2TlNodmxjYk03WFEvWGU0SXFyd0VyTHZOcTY3?=
 =?utf-8?B?Z3ZLcThoWVFyKzFxa1U3eGhjOVhrNXd1THkvSXN3QWZkZWdicFA0WFV2UUhz?=
 =?utf-8?B?ZXZLNXJMYXN1UXhYckJJY3BVdFVTRUhQeWxtVlY1amI0bE41dWlQL0lROWpr?=
 =?utf-8?B?RjhOckZhbmp3NzZrbnQxY0N6OHRZeUFGcnpRb00xVkpjTjdqdjIxNjg1V0s2?=
 =?utf-8?B?aDVQRU1SVzlQUjhKZ1Z4WGpzWXVOWGQ5WWJ0U3VOQUNKdVJiVTNPblZISW42?=
 =?utf-8?B?NkNOTldiRHRsYVYvM0o5M3ZZZVE0N3pMRUFUcXZYTUYvTDNSVVVDb0NqWXVO?=
 =?utf-8?B?bWxFSkFQWExCYWM2SnZyUnJqdXZDUWdUY3piMG1rQ3d5YmVvWHJWUEowR2hF?=
 =?utf-8?B?VEpFcXRoVFMxbVdvWU1xTk5Sa2R5TXhBLzBiMnFURkFBQjh4aXltWTJIbjgy?=
 =?utf-8?B?TXVNNG81U3I2R29JdDBtZlVCdG5wNjBOKzhqL2NUVmo1S0RXazhqcXFRS1Z6?=
 =?utf-8?B?cE4rUTNJUjYzRThReTh2ZEg0YlFKUFE4cE51bTB3U3JVMHg2M3gzVlRYc2J2?=
 =?utf-8?Q?RXtCidzdV3Un3weg1y3FOdhkv?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e95ea51b-902c-49da-586e-08dc737ed8d1
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2024 18:59:42.3854
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5vCGgN11jmS19Ihbh7cCvU2eiFzbITfESMo8PpATF7ApILeX/dRKYHkVh5z8Ca2jI2Z3M0etcMYlvFoIkhsiPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7329

Jason

On 5/1/2024 11:17 PM, Jason Gunthorpe wrote:
> On Tue, Apr 30, 2024 at 03:24:22PM +0000, Suravee Suthikulpanit wrote:
>> Depending on the modes of operation, certain AMD IOMMU data structures are
>> allocated with constraints. For example:
>>
>>   * Some buffers must be 4K-aligned when running in SNP-enabled host
>>
>>   * To support AMD IOMMU emulation in an SEV guest, some data structures
>>     cannot be encrypted so that the VMM can access the memory successfully.
> 
> Uh, this seems like a really bad idea. The VM's integrity strongly
> depends on the correct function of the HW. If the IOMMU datastructures
> are not protected then the whole thing is not secure.
> 
> For instance allowing hostile VMs to manipulate the DTE, or interfere
> with the command queue, destroys any possibility to have secure DMA.

Currently, we have already set the area used for guest SWIOTLB region as 
shared memory to support DMA in SEV guest. Here, we are setting 
additional guest IOMMU data structures as shared:

* Device Table
* Command Buffer
* Completion-Wait Semaphore Buffer
* Per-device Interrupt Remapping Table

, which are necessary for QEMU interrupt remapping emulation. Therefore,
we are not making the VM any less secure from device perspective.

> Is this some precursor to implementing a secure iommu where the data
> structures will remain encrypted? 

Yes, the is precursor to secure vIOMMU support in the guest.

> What is even the point of putting a non-secure viommu into a SEV guest anyhow?

This is needed to provide interrupt remapping support for vcpu with 
x2APIC ID (> 255) in the guest, which is already available w/ 
QEMU-emulated AMD vIOMMU.

Thanks,
Suravee