Received-SPF: pass (google.com: domain of linux-kernel+bounces-178007-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240511144436754EiKfJM4xjMSTyCbEExwcL@zte.com.cn>
In-Reply-To: <20240511144436754EiKfJM4xjMSTyCbEExwcL@zte.com.cn>
From: Yang Shi <shy828301@gmail.com>
Date: Mon, 13 May 2024 13:05:28 -0600
Message-ID: <CAHbLzkqg=+Dq40-He5ZBCnzrXEJaBUfXtb2jjBoDKERpM-C07w@mail.gmail.com>
Subject: Re:  [PATCH linux-next] mm/huge_memory: mark racy access on huge_anon_orders_always
To: xu.xin16@zte.com.cn
Cc: akpm@linux-foundation.org, david@redhat.com, willy@infradead.org, 
	linux-kernel@vger.kernel.org, linux-mm@kvack.org, ziy@nvidia.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, May 11, 2024 at 12:44=E2=80=AFAM <xu.xin16@zte.com.cn> wrote:
>
> From: Ran Xiaokai <ran.xiaokai@zte.com.cn>
>
> huge_anon_orders_always and huge_anon_orders_always are accessed
> lockless, it is better to use the READ_ONCE() wrapper.
> This is not fixing any visible bug, hopefully this can cease some
> KCSAN complains in the future.

A little bit confused here. Did you see complaints from KCSAN?

> Also do that for huge_anon_orders_madvise.
>
> Signed-off-by: Ran Xiaokai <ran.xiaokai@zte.com.cn>
> ---
>  include/linux/huge_mm.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h
> index de0c89105076..6573430ea600 100644
> --- a/include/linux/huge_mm.h
> +++ b/include/linux/huge_mm.h
> @@ -122,8 +122,8 @@ static inline bool hugepage_flags_enabled(void)
>          * So we don't need to look at huge_anon_orders_inherit.
>          */
>         return hugepage_global_enabled() ||
> -              huge_anon_orders_always ||
> -              huge_anon_orders_madvise;
> +                       READ_ONCE(huge_anon_orders_always) ||
> +                       READ_ONCE(huge_anon_orders_madvise);
>  }
>
>  static inline int highest_order(unsigned long orders)
> --
> 2.15.2