Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp2265657lqo; Mon, 13 May 2024 12:47:17 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUspaF0Ex9Texia89QeO6wAJZN4EdopM7AK06sq1X0hAOyrYPOm18AlF/M4JjHLLRF+pc5EIkTw3mqMRs8cJwTYP6eExF7RQRbhsczp3Q== X-Google-Smtp-Source: AGHT+IEbJve/eA2G3OaY3y3Oi347gfh3phI567dKfnFZfn7c+TvIKbavJLufKQGnFHE97tehpUzf X-Received: by 2002:a05:6214:3283:b0:696:8f17:2ccb with SMTP id 6a1803df08f44-6a16815ce2emr117547976d6.17.1715629637641; Mon, 13 May 2024 12:47:17 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715629637; cv=pass; d=google.com; s=arc-20160816; b=El7y4TnuzfReKciCqkY19fZaM6ubcODmt5ZC1ebsnwQFCRZ6PwYJW+IkTuVh8ae6KS uXBcnunwAg861cI8skOZ3WDECxm/LrDv7EbucB7jkw83SQ/Jcp+PgugFdBk/QaHmXd1N 86UhwNHIShFoH+E5C16xVZx5QaKOVn/3yeFq+azP9Nh2wv8/LNuE2mm0d72/NVsWU+zN v90Q5n4paEbT6D63XaimYcOOoV8mELK2iq2Khc5ySMUJX02eH1SzvTLNWpzb7vrdM4RO AVDbBxFhaXv61cLoGklNLN5CUiABbdi8CoJnmCJh2NFY7C9SBm4E1jGfdb2aKuYKhxfh OBrg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=SfFfYpzZ9TkXj0n+fN7saznALYpPsNADwmH6bqocYac=; fh=lJ9NRhn/MEEOi8eggzSCZOTFWXJhztbRGAF4ytTBUWQ=; b=gBlwaEISKdh/47IEasyF2N27gpPA2EgvaDi8RoCRdS00RcO1Jms/nAqnhT2ogr5VSf Ed67WNnRlMy0Dsfs8957m48JI9zag9HmHMNFFULcLwP+8u1pHvOaD+hJJutdVKDiD/gS lBBt0vUF01eugtZWX/laLSqyBrVLOk88m3OKgFThtxtwqGovPBOOWiwW18tACzIJlMlr dBETZijrp1l08nEE6EX7WzQ4CsQjW4GemCKoPqDNZq7DbsUde6j7s4KZwMrI374zYz8e hKk2J/C2GTquNJ4zR8SzcoOk4smtg6JB50anE621qyo3otj+NXPaDQ7NR+UT2W1XH3yf QGoQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=PamTSi9I; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-178042-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-178042-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 6a1803df08f44-6a15f2ec8ffsi111481426d6.461.2024.05.13.12.47.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 12:47:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-178042-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=PamTSi9I; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-178042-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-178042-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5CA991C22D0F for ; Mon, 13 May 2024 19:47:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3131B78C9A; Mon, 13 May 2024 19:47:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="PamTSi9I" Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 298DD77106 for ; Mon, 13 May 2024 19:47:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715629630; cv=none; b=bssW47vdnN4KThX2gxRY0UFN2ArYPgaKTeHSNgqcnxjDI5k19BR3zLT1a2nehWRbMRIPXkBR7ZJ8yqZddFV8P5w0TKGyKM3X+UcaAeEwn2yZFi/LVmqY3jgpTuqXUCPOnpY0MUkhuK2kVIuz9x0JjRx5Rj8REaFyPgaTg/zuCQ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715629630; c=relaxed/simple; bh=16a3Epaq7g7pf8NaFIU+bskv2ICswFxu2+yqI8JIU9Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z1Js0gQLTd3loxhUqu4hosxM+Vg+2CxjS20yNXZ2VAfbJciw20auU0Dcd+RbplEt4UhDpImEJc6JaN19SoBjmz5tV/XmOFMP0cgjCG/TXrBQz4SFBccI9q9SPxuKDbK4L8Gj9K5m+aJfO10B6iP7WujBBt3nFD0BpSZOpRw5DI4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=PamTSi9I; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-61aef9901deso3444807a12.1 for ; Mon, 13 May 2024 12:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715629628; x=1716234428; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=SfFfYpzZ9TkXj0n+fN7saznALYpPsNADwmH6bqocYac=; b=PamTSi9IUV3k9KyOzKbYhCQHoF3hzhyZAv9trDSgFgdBiht+S0densC7xGT4AHuJ9U UhubWxNZZPXKJEXOQ/LO46BAwMs/FAF8Voa2GVFfM6ZUhTJSyvlaa5qe0XNNSe42pmJS LcYCdEdfT7UglIT9mKVo7fDpL2wTDco/9PkBk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715629628; x=1716234428; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SfFfYpzZ9TkXj0n+fN7saznALYpPsNADwmH6bqocYac=; b=QSFwSVFd6e+fgv4H0SoWccwUSy27/VnY4AViNsrzd0PoPEtU5zf/3ZR0lvCuhp72iV dICGEIVcobikGCXlYh4lB1HLdkRzwRMYnXtpd7i8IpJ0q3zFsxczKU0G8BGuJ8YnF8dS 4dhNdMDplvqjn7+C3cTRFje3yGoOUiCYJzVkJL88/LuwNBmPBMEY5lRM1sJl8OWn1PYg bYjM86zYFMAE3QzsX4WGZIU0mOJhDDZOyBrgM6zAvlN6vsm2CFKGhp9/nmWdFJ/kPtB7 O+K1DBtX1qQjlEVrGCe4uQoT35X8pLlM0FNuOpMRsVF8qtQYcAg+KRE7Y81NB43PaRUV V8kw== X-Forwarded-Encrypted: i=1; AJvYcCWOryewBIqcVC3ixPHCbTiMk7PWJmQaPET7+7gG1u5PpFqyyN6F1oOAwzVmv0sgr9P0h6x2elwLAvpQojNkxWYyJod8ZTdJWPCCF1dT X-Gm-Message-State: AOJu0YyXsDQHNSI89drtlXFA28RDtFV1j7NVKoVaqs4lQpvyOoRUhc/a TUIPJLU0n2S7jpb5RZPIBnO5TRZmk31kxQ6B0isCe1NQvibND+i6EqRsAFxDsg== X-Received: by 2002:a05:6a20:7f81:b0:1a7:a3ee:5e4a with SMTP id adf61e73a8af0-1afde0e24e4mr11181425637.33.1715629628568; Mon, 13 May 2024 12:47:08 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4d2ae0d77sm7765927b3a.106.2024.05.13.12.47.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 12:47:08 -0700 (PDT) Date: Mon, 13 May 2024 12:47:07 -0700 From: Kees Cook To: j.granados@samsung.com Cc: Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Luis Chamberlain , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] sysctl: constify ctl_table arguments of utility function Message-ID: <202405131246.C27D85E1@keescook> References: <20240513-jag-constfy_sysctl_proc_args-v1-1-bba870a480d5@samsung.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240513-jag-constfy_sysctl_proc_args-v1-1-bba870a480d5@samsung.com> On Mon, May 13, 2024 at 11:25:18AM +0200, Joel Granados via B4 Relay wrote: > From: Thomas Wei?schuh > > In a future commit the proc_handlers themselves will change to > "const struct ctl_table". As a preparation for that adapt the internal > helper. > > Signed-off-by: Thomas Wei?schuh Yup, looks good. At what point is this safe to apply to Linus's tree? i.e. what prerequisite patches need to land before this? Reviewed-by: Kees Cook -- Kees Cook