Received-SPF: pass (google.com: domain of linux-kernel+bounces-178062-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 14 May 2024 04:09:04 +0800
From: kernel test robot <lkp@intel.com>
To: Lyndon Sanche <lsanche@lyndeno.ca>
Cc: oe-kbuild-all@lists.linux.dev, mario.limonciello@amd.com,
	pali@kernel.org, W_Armin@gmx.de,
	srinivas.pandruvada@linux.intel.com,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	Hans de Goede <hdegoede@redhat.com>,
	Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dell.Client.Kernel@dell.com
Subject: Re: [PATCH v2] platform/x86: dell-laptop: Implement platform_profile
Message-ID: <202405140348.Wz7gOmdP-lkp@intel.com>
References: <20240426020448.10862-1-lsanche@lyndeno.ca>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240426020448.10862-1-lsanche@lyndeno.ca>

Hi Lyndon,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.9 next-20240513]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Lyndon-Sanche/platform-x86-dell-laptop-Implement-platform_profile/20240511-144534
base:   linus/master
patch link:    https://lore.kernel.org/r/20240426020448.10862-1-lsanche%40lyndeno.ca
patch subject: [PATCH v2] platform/x86: dell-laptop: Implement platform_profile
config: i386-randconfig-005-20240513 (https://download.01.org/0day-ci/archive/20240514/202405140348.Wz7gOmdP-lkp@intel.com/config)
compiler: gcc-8 (Ubuntu 8.4.0-3ubuntu2) 8.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240514/202405140348.Wz7gOmdP-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405140348.Wz7gOmdP-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: drivers/platform/x86/dell/dell-laptop.o: in function `thermal_init':
>> drivers/platform/x86/dell/dell-laptop.c:2404:(.text+0x21a3): undefined reference to `platform_profile_register'
   ld: drivers/platform/x86/dell/dell-laptop.o: in function `thermal_cleanup':
>> drivers/platform/x86/dell/dell-laptop.c:2412:(.text+0x21cc): undefined reference to `platform_profile_remove'
>> ld: drivers/platform/x86/dell/dell-laptop.c:2412:(.init.text+0xb44): undefined reference to `platform_profile_remove'
>> ld: drivers/platform/x86/dell/dell-laptop.c:2412:(.exit.text+0x7c): undefined reference to `platform_profile_remove'


vim +2404 drivers/platform/x86/dell/dell-laptop.c

  2377	
  2378	int thermal_init(void)
  2379	{
  2380		int ret;
  2381		int supported_modes;
  2382	
  2383		ret = thermal_get_supported_modes(&supported_modes);
  2384	
  2385		if (ret || !supported_modes)
  2386			return 0;
  2387	
  2388		thermal_handler = kzalloc(sizeof(*thermal_handler), GFP_KERNEL);
  2389		if (!thermal_handler)
  2390			return -ENOMEM;
  2391		thermal_handler->profile_get = thermal_platform_profile_get;
  2392		thermal_handler->profile_set = thermal_platform_profile_set;
  2393	
  2394		if ((supported_modes >> DELL_QUIET) & 1)
  2395			set_bit(PLATFORM_PROFILE_QUIET, thermal_handler->choices);
  2396		if ((supported_modes >> DELL_COOL_BOTTOM) & 1)
  2397			set_bit(PLATFORM_PROFILE_COOL, thermal_handler->choices);
  2398		if ((supported_modes >> DELL_BALANCED) & 1)
  2399			set_bit(PLATFORM_PROFILE_BALANCED, thermal_handler->choices);
  2400		if ((supported_modes >> DELL_PERFORMANCE) & 1)
  2401			set_bit(PLATFORM_PROFILE_PERFORMANCE, thermal_handler->choices);
  2402	
  2403		// Clean up but do not fail
> 2404		if (platform_profile_register(thermal_handler))
  2405			kfree(thermal_handler);
  2406	
  2407		return 0;
  2408	}
  2409	
  2410	void thermal_cleanup(void)
  2411	{
> 2412		platform_profile_remove();
  2413		kfree(thermal_handler);
  2414	}
  2415	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki