Received-SPF: pass (google.com: domain of linux-kernel+bounces-178068-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <b83a3b5a-884e-4b9b-b962-3a625b3072b5@oracle.com>
Date: Tue, 14 May 2024 01:42:25 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] iio: temperature: mlx90635: Fix ERR_PTR dereference in
 mlx90635_probe()
To: Crt Mori <cmo@melexis.com>
Cc: Jonathan Cameron <jic23@kernel.org>, Lars-Peter Clausen
 <lars@metafoo.de>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org,
        error27@gmail.com
References: <20240513184514.3200222-1-harshit.m.mogalapalli@oracle.com>
 <CAKv63uvAe=RkZ6ytWfNkM5exy5ys5n2NwcJER=VMVAP+61-+rw@mail.gmail.com>
Content-Language: en-US
From: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
In-Reply-To: <CAKv63uvAe=RkZ6ytWfNkM5exy5ys5n2NwcJER=VMVAP+61-+rw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?NjE4N1BNR0VIODJQM09HYy9rbkIyek00V1JzVEgzbVEzRE9vVGxmSC9naHhP?=
 =?utf-8?B?L2Eza2s1L1NSaXl1a2c3M2V4Q2VGUE5kVWM2WndxVjV2SlZaNXZyYUMreHdS?=
 =?utf-8?B?NU5VS3g5MTd6aC9tTkVRdTllQXNMSjVHbnVIVkh6bVlTUEhrNmpSTzlIVWgx?=
 =?utf-8?B?d3NUeEZiUlFQNVZPdXNFV3BHQnFudm5WZDYxUWoxRXlCU0FhVzZzU1p3bTlz?=
 =?utf-8?B?b2JSSk93SzE1bEVkREMxNHQyakxBUTdBbjJSUzNscHJYajlFaEFzcWFKUzNn?=
 =?utf-8?B?eS9MM1d5cE5GM2xXdnk2MjFkejJkdTB0M1BVM0tGUExHRnJUZndaTGQ5Lzd2?=
 =?utf-8?B?YzhMVHc2UmxXUURNM0Z0MlgzbElTajBwT0VGeVFwM2w4UFBMSW1TeTBXb1dB?=
 =?utf-8?B?OVdmYTM1RHBKaTQyLzExQXlkRk4rZGM4a3JBbS9MeUxtNkZSdjRBNDdqS2lz?=
 =?utf-8?B?SEJTN0ZyYVlGWnpDMzArSEpJWnA5UFlQN21URlZxemUzeFpweHlVZHNOS2Na?=
 =?utf-8?B?b2VHUHg0aXE4MlpkcGFTV0JKTW5NalJPQURodm5mVThUU3hUdXlacytjVU1k?=
 =?utf-8?B?S01rdk5vV1VhWUNSUTZKN2MrM1BWS3I3YlJQaDdNM3A0Qk9FYzhMZkVsUUlu?=
 =?utf-8?B?dHdxSlVhOGxIcU03dk41bUVrL0hOYUJVcmdIUG5lZmdDeHhZMXpqZURPZ0xP?=
 =?utf-8?B?U2Z2QU92TlhscU44SWpDdDBoalk3Z2taT3JYOVpvMURIQXNROFdJOHd3ZHAr?=
 =?utf-8?B?blRFQ0pjQmltQUJycllOd2dGRkQ1YXFQd3A3Q2hrbDZrQjhSSFBTWVN3NnAy?=
 =?utf-8?B?MHRYaGF2dHhqQ0dWZEQraWtDS3g3NjY0b0djSVpueGJ0cTFzRmRQUkYxbnV6?=
 =?utf-8?B?Mm5EZzRQNDMrYjExMWFhK0p6UDJ0SUwyZytneGFIQk14VVVIRDRBcnFyak53?=
 =?utf-8?B?cEpnNXJPT2tNYWNjYzJCQ3BlSlBNOUVzeTlpeEE2SDhvUmYvQ01PM1pweVNj?=
 =?utf-8?B?YUsyRjRZYVdGWEhkdmh0bGtiSEJzS3hNVTBHb0NKT0hCb1QzUWtFeUYySURj?=
 =?utf-8?B?TTRNZnFTUG1aL0VNZ3VTV2Q4MnJuMnRySmxwb2NPcHNyVHR5dUFnQTYzWHp3?=
 =?utf-8?B?SEFXeStwbzNsZjYrTkNZd2RBdDREWnZOa0U4MEVzUTljZHZUbUd3b2hOcHNj?=
 =?utf-8?B?VG8rK1NmWDQrd3JsNkhmRXZmNDZiZ2lnT0J1SXpuMlRFYjAxbzd1UEo4Y0hT?=
 =?utf-8?B?aThIZWh2ZHZDdmM4LzcydUQrRU1PQkUzSkZJL2dLYmhGbks5OVNEVEl3SlBw?=
 =?utf-8?B?R2lVQkxkQ1FCYVgvNlBZbFc1cnFPWTliVko5MmJyN1gzOW5rQWhBRDFraGpP?=
 =?utf-8?B?Sm1FRlVtelBLMkpoaHF4RTFNc1AxL0dnOUZ0MnAzODF3NVNRdHhzcDB1WTMz?=
 =?utf-8?B?U29lSEpTc2dRanhFWWxpU2dNQ3VFZW1JMVlmeFNtUXhMYWx5N0tlZ2k1aGRz?=
 =?utf-8?B?S0tVVDJEa2NhaCs4a2pmaXpDaUxveXE4aHFBcmtUTXAzVTZSUms5ZzBVbnhO?=
 =?utf-8?B?MnlkTGlQQ1ZkWGRjRXhKWVdVY3dzNzllNFlpVmJvWG91Y3dLVW95cWRKZkpa?=
 =?utf-8?B?UWo3U1FZejllSHFMb2dqQW9vK25XUGFPd3JHSWhuLzJTb1VwN29qV3NuZXFG?=
 =?utf-8?B?OTl5SUV5QUxVVHc3Z1MvUlJvMjVPeG5jUHR6VEZzMTZXQTR6S1U5VVI3SG5N?=
 =?utf-8?B?OTJXSGJ4WTR3TVJvMTdGZnRRN0g4SVBLSWtRMWhwUVc0V0cxN21iTFlyZXp1?=
 =?utf-8?B?d3VlVTVQbTJKZWZHOEVkK21NdDF2SnkxV1RTUFZxUVRKZyt4WVRrTGZ5cEdS?=
 =?utf-8?B?NHRtenZadXBwL2VuVlA5ZWRqUnpVU1Y1T2lSNW4wdzZGVjdSODVyQ1ZVMWtO?=
 =?utf-8?B?YkxheXpZQnlXaDJrVkcrM2kxVWx2T3V2alNQZTd5S3R6RlR0UHJ6ZGVnbTR6?=
 =?utf-8?B?aTM5M2dhSEJwdGwrV29DZG9KcTBtNER5WTc1V0NtNERvckVqWE0zMk9JdnhO?=
 =?utf-8?B?WGdOZWxjS2Y3TVRBNDdQaEdLQ2ZRQ3ByMFFva0h6VW1UTlJPQ2VkSXNpeXVv?=
 =?utf-8?B?T0hXdkpLMkZaamw3RWJ5Sm12cWtBajlBYzVzNXdZa3g0UTQ3NlJlQVJxRzAy?=
 =?utf-8?Q?FPNJJOvgw7H39oJBbvsOW/c=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	qh+LQh2Hs8rBicZxGKEd3hZf0aCq3kw5efmEF//w/3bLZ4kWDIVJuexKmmYSMXknRX7tCR5Pd5+VLyprAlwa9FjH4TwTSAXBhlcjX8V1qtEwpHclMEaAyNcW/FwgkgVR8qE8ItBI94yM6v9OdOYaV8iOgsZU4nlj3ukVfwTTd9tWE2LNw/ttSGUQXdwQtOv1ohS8qydh8Xlz6dFPyFpGlNyFDcQDYkN1o1Z+kSloxAow7KWD6MwvuP1T54+YZqOh5zlQLjC3RvbJTtQhuU+p3A1JtlaHiw24BWGTh6uzFqdAHCWtln89yV2Nmf/HFxjcrvaHucri7b9VabLtn4Ut8YkbdLb+1Tff31SzdREl/2MRAZDoywFCkPo6GmzWQhLKa9dcRS5dTt5miQd+G2jcLkgxvizdX1M014gZw/lBy/S45v1nzZBv3SMtyFFM75mgmofKkR8PYij+rvi1JUWgocvO9cLPp5Z82UZjUZ6t8bMEUodo3kgQBYqJT4PmjYJSRMd8AklTNd1PxLyJdO6LjJuy9+dCI9H/mImPFF1FjZTxlgf6S0nB8oe1xpYrQBLI73lgT2NRFeNHAam/XGSmQ/dT5kaqfEoGKvagogF+ujw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8dc54f2c-c663-4c45-c705-08dc738906e7
X-MS-Exchange-CrossTenant-AuthSource: PH8PR10MB6290.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2024 20:12:34.6099
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QLyJw5sfqlRDpHk183JhR0vABYYLryrUKeauTeKKlTTrLrvhkHnik7+OeAS9tFJm8ZGVihiFOom8zDB1rjjfH5quLby7t4e8lBpXyeXx5pJcElzhnC5UcGirEu+SNEsi
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5202
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-13_14,2024-05-10_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0
 mlxlogscore=999 spamscore=0 suspectscore=0 mlxscore=0 malwarescore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2405010000 definitions=main-2405130137
X-Proofpoint-GUID: QnnQWmiVciuwNb7s_z3rvOG1m4MjDsSd
X-Proofpoint-ORIG-GUID: QnnQWmiVciuwNb7s_z3rvOG1m4MjDsSd

Hi Crt,

On 14/05/24 01:32, Crt Mori wrote:
> Hi,
> I agree it is is copy-paste error. Minor remark below and a few typo
> fixes in commit message. Thanks for your contribution.
> 
> Reviewed-by: Crt Mori<cmo@melexis.com>
> 

Thanks for the review.


> On Mon, 13 May 2024 at 20:47, Harshit Mogalapalli
> <harshit.m.mogalapalli@oracle.com> wrote:
>>
>> When devm_regmap_init_i2c() fails, ragmap_ee could be error pointer,
> When devm_regmap_init_i2c() fails, regmap_ee could be error pointer,
> 

Oops, sorry for the typo, I will fix it in V2.

>> instead of checking for IS_ERR(ragmap_ee), regmap is checked which looks
> instead of checking for IS_ERR(regmap_ee), regmap is checked which looks
>> like a copy paste error.
>>
>> Fixes: a1d1ba5e1c28 ("iio: temperature: mlx90635 MLX90635 IR Temperature sensor")
>> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
>> ---
>> This is found using smatch, only compile tested.
>> ---
>>   drivers/iio/temperature/mlx90635.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iio/temperature/mlx90635.c b/drivers/iio/temperature/mlx90635.c
>> index 1f5c962c1818..2b61489d5ee0 100644
>> --- a/drivers/iio/temperature/mlx90635.c
>> +++ b/drivers/iio/temperature/mlx90635.c
>> @@ -947,8 +947,8 @@ static int mlx90635_probe(struct i2c_client *client)
>>                                       "failed to allocate regmap\n");
>>
>>          regmap_ee = devm_regmap_init_i2c(client, &mlx90635_regmap_ee);
>> -       if (IS_ERR(regmap))
>> -               return dev_err_probe(&client->dev, PTR_ERR(regmap),
>> +       if (IS_ERR(regmap_ee))
>> +               return dev_err_probe(&client->dev, PTR_ERR(regmap_ee),
>>                                       "failed to allocate regmap\n");
> 
> Maybe fix her would also be to this regmap error message to include
> regmap EEPROM?
> 
Should we make it like:

"failed to allocate EEPROM regmap\n" ?

Thanks,
Harshit


>>
>>          mlx90635 = iio_priv(indio_dev);
>> --
>> 2.39.3
>>