Received-SPF: pass (google.com: domain of linux-kernel+bounces-178100-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 13 May 2024 23:17:48 +0200
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>, 
	Peter Rosin <peda@axentia.se>, Jonathan Cameron <Jonathan.Cameron@huawei.com>, 
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, "Rob Herring (Arm)" <robh@kernel.org>, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: sbs-manager: Remove class argument from
 i2c_mux_add_adapter()
Message-ID: <4g4u2g2nrcpjvx4uswxppw2vsfzwcsy6kbsjp7ukksgfyhgnqb@s5n6jlz6w7af>
References: <20240513201400.16589-2-wsa+renesas@sang-engineering.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="d6m7btjvugjxoruz"
Content-Disposition: inline
In-Reply-To: <20240513201400.16589-2-wsa+renesas@sang-engineering.com>


--d6m7btjvugjxoruz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Wolfram,

On Mon, May 13, 2024 at 10:11:16PM +0200, Wolfram Sang wrote:
> Commit 99a741aa7a2d ("i2c: mux: gpio: remove support for class-based
> device instantiation") removed the last call to i2c_mux_add_adapter()
> with a non-null class argument. Therefore the class argument can be
> removed.
>=20
> Note: Class-based device instantiation is a legacy mechanism which
> shouldn't be used in new code, so we can rule out that this argument
> may be needed again in the future.
>=20
> This driver was forgotten by the patch in the Fixes tag.
>=20
> Fixes: fec1982d7072 ("i2c: mux: Remove class argument from i2c_mux_add_ad=
apter()")
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>=20
> The to-be-fixed patch is only in linux-next in my i2c/for-next tree. We
> want to remove this unneeded parameter in the next mergewindow. I
> suggest that I just put it on top of my branch to avoid the
> dependencies. A quick ack would be super-awesome! Thanks.

Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

>  drivers/power/supply/sbs-manager.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/power/supply/sbs-manager.c b/drivers/power/supply/sb=
s-manager.c
> index 9e4141cffbf9..933b04806d10 100644
> --- a/drivers/power/supply/sbs-manager.c
> +++ b/drivers/power/supply/sbs-manager.c
> @@ -358,7 +358,7 @@ static int sbsm_probe(struct i2c_client *client)
>  	/* register muxed i2c channels. One for each supported battery */
>  	for (i =3D 0; i < SBSM_MAX_BATS; ++i) {
>  		if (data->supported_bats & BIT(i)) {
> -			ret =3D i2c_mux_add_adapter(data->muxc, 0, i + 1, 0);
> +			ret =3D i2c_mux_add_adapter(data->muxc, 0, i + 1);
>  			if (ret)
>  				break;
>  		}
> --=20
> 2.43.0
>=20

--d6m7btjvugjxoruz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmZCg3gACgkQ2O7X88g7
+pp43w//VO9lJvcUaKz+JueNUDFd0HXec3yMyAZajSdxiWoBabx/LoCOh1+dgy5e
36cR9TO7e/+f+OcwUD34gZ1GY0De+XLMMsFBojVll20VH222lOMyhg+WROUcKbU8
AeZjL5YX6noqe4X+p+pRv5lQfU+GjKFY9Z3+TAm49Gk4zMHnL/KdCGwvgWhNFLiO
bmR1yUUs+AG6TRpDSJCjv6c3tTG9u5shrCoQ4I1CAU4RUDh7skztzsRME/lgYSbf
znikgB5tr3kIxiwwZHupaNitC7vXfhMXaMgjkkhCibkJNri/fqOv2/+taN79Zqct
mHECbusAcvoQv4c9cJvekMrCpd+oqBW2d5clldPsrguICpq8R8E1loTVg6CFCPeW
pXY79eqcCunzU1OEkCGZoYF3VkBthUuAn9lcdNS3oH6uPXosADrNoh2Raq4YHUYn
vHuBAjYPNl9P/Uf3Rr3QiCu+01Zo63fOFyOCFhYYG5GzKShrQ3bI9zFkM79JB87J
RHhRxr7Lqr5xM7lcAxJpBvP0JYBqgotP1PxpQ72ptjgzy0kcVky80uR5pXLCawxs
88IZW1h8CBhj3W/l6tcGWsVOByHYIE6SmKboAmo3h/WVI8PUMBSjtyygjJXkm9d9
MhgtdQjmV3vGk9s3rNJU7y9nwzKShjaE1sQgY87DrxXd5rvknEQ=
=2KO3
-----END PGP SIGNATURE-----

--d6m7btjvugjxoruz--