Received-SPF: pass (google.com: domain of linux-kernel+bounces-178112-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 13 May 2024 14:33:15 -0700
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Charles Wang <charles.goodix@gmail.com>
Cc: hadess@hadess.net, hdegoede@redhat.com, neil.armstrong@linaro.org,
	hughsient@gmail.com, broonie@kernel.org, jeff@labundy.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Input: goodix-berlin - Add sysfs interface for
 reading and writing touch IC registers
Message-ID: <ZkKHGy0qvFzSoVhl@google.com>
References: <20240513123444.11617-1-charles.goodix@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240513123444.11617-1-charles.goodix@gmail.com>

Hi Charles,

On Mon, May 13, 2024 at 08:33:37PM +0800, Charles Wang wrote:
> +
> +const struct attribute_group *goodix_berlin_groups[] = {
> +	&goodix_berlin_attr_group,
> +	NULL,
> +};

This symbol needs to be exportedsymbol needs to be exported..

Thanks.

-- 
Dmitry