Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp2318691lqo; Mon, 13 May 2024 14:51:40 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUTS5qgVPqrPaGNbmaF/fy8OFgaftlcVB2h0lUcRw0iIMFKHdXeU80DTc1N6iQhJ6udWCwu0j6mfwaZNCtkwBNCuQrLqsWZgaaLcPzFpQ== X-Google-Smtp-Source: AGHT+IHba1ivpH19YvV73AqqNaRnmMAeNgQQcQKlqFIZZh7oX+LObDW8wQneNxiWs0mSQafuam1n X-Received: by 2002:a17:903:48c:b0:1e3:c5d0:9fb8 with SMTP id d9443c01a7336-1ef4404fd76mr96475015ad.42.1715637100153; Mon, 13 May 2024 14:51:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715637100; cv=pass; d=google.com; s=arc-20160816; b=IsIbjmNGGBA4A4QSbWsGFAi8Nzi8Auy/4XTGkl/ltRsLflrlIyw1dNfAHWLfjJURJ/ 7co3PHpAMH6pXpV/ptBhjlJOUQSl7ZT9FZ9pO8iwvtlto2wNzOOwaGDuOOdb2w4TnevH xsxI56ZCbnIwQyKgI6vsB7job9t1QjSmQ41yk7pX3CBXs+2aoV9YDbe2XUae1VQ0TX0h ywIWJ10kc+x5BRw6ybNcbQSUY9XJEaR2HIJ0T+npezqAmKr2uK0JWVgWIDNi0aibKmRi UJQCIY3XezFwzaBFi+PvYS/I29BBgncZmrAxjM22WBpzxTB05Zp+GPbEFdtKh3IB1pP+ /2yA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=3IqFSJyw7bcFJ36HHbPoZCM6onrc5HoJqxxiXPG+/zI=; fh=zfCWNT+2arUysoe0Inm5+51QH0wRkdaQmNANP3GS9w0=; b=DzVDV+0YVeM734f/QbNgNSGJGu7h0M0mRr8Ni2CfcekrXLi9KWqiOkJgD2IqOYXE9k RA19+kmKpB0FEN8n673lkRGcc0qOqm26q/09mdzUA4wJX3UqlRhUXbmytGlQ567Zsw6Q BYGjDRk4dBuF7GGf4gNFa8GxgiHIkc/QfFQ424FfW7boR6ES8q11S79T2s725sfX/JyK +kxiM+cQhQCFrfkOqNV3ShdJY1aauNUcLi4TAFXhrosvSyJ9XwJK4bEGX0/7esduWwP7 leM6JK9QELXNMOL4B/LrqunYwARVWrCzyzFWhXoh2tovg/BF4+YvyazC0ZgXqTorGCZi rIMA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PKYzTCPv; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-178121-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-178121-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d9443c01a7336-1ef0c1603e2si99270205ad.532.2024.05.13.14.51.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 14:51:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-178121-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PKYzTCPv; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-178121-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-178121-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BB663282A0A for ; Mon, 13 May 2024 21:51:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 309D584A3B; Mon, 13 May 2024 21:51:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PKYzTCPv" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 597822AF09; Mon, 13 May 2024 21:51:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715637091; cv=none; b=LZjVd2rmXoaqkJf+w4furNO+AECKV20XAkr9VDe+fsro6/nW61Jo9TPEPUcrMlFQHknUyMfzbGTV8tmstQINtgYzwghCwP96pmfO0CuAhHugghLvjyFI6gpjMfsw2+RKHsWSeRntV2uW89iJvpSfnVJoOg9wIX+DKAE6k25mTi4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715637091; c=relaxed/simple; bh=qjDaR7GpKVcHlSgdXco8X6U5ApfVTHDXF71c1j23G6Y=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LMtbelNqUrdZyC7SJJTMK86GuSDgTv8x2LSo6oiKAqoj5P6Uvyfb60nV+U9Hjm9Fsgipn9xm0SEET2Ue0aVEpw7A/ctnSfdYbCUAJxKNpNuoWgyfh5coy6l/GsdE/XcPreIBXg/ZpaCdDcArRWcGxiU5G6JxB9JwGs5AWH6DrQM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PKYzTCPv; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF0B9C113CC; Mon, 13 May 2024 21:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715637091; bh=qjDaR7GpKVcHlSgdXco8X6U5ApfVTHDXF71c1j23G6Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PKYzTCPvDQEq3qqSq4LvLpV7by4JwQCgW+DL/tlfBikBTc7tcQvlL1OjVxsKKNfe3 g6JurEYbAdO5k0ZPpGLsMHZOUWcc8g0lexIHpRbiVl9q4+DYuI6EsyQ+j8Z8QTol1s CCd33VgQyogWUZ5EgVut4ofxmiLdNyo8FoqhoAE2ftSGbbpQc1Goe4emg7pJ9RDN7t WEsgj3VIxGIBBcuYrf7YhASpOZ+HALztfvsMx6ZpGk9ydD5vh+DUH6GEe37aCTdTpy VIxWB3RqQ4kufHo0uwws40I3javIeHgqg0KqIKdH1javzjdxmLVYdjle+3R9ObG3Rx 9oHb5KjcMYR8Q== Date: Mon, 13 May 2024 14:51:29 -0700 From: Jakub Kicinski To: Breno Leitao Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , thepacketgeek@gmail.com, Aijay Adams , netdev@vger.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH net-next] netconsole: Do not shutdown dynamic configuration if cmdline is invalid Message-ID: <20240513145129.6f094f92@kernel.org> In-Reply-To: <20240510103005.3001545-1-leitao@debian.org> References: <20240510103005.3001545-1-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 10 May 2024 03:30:05 -0700 Breno Leitao wrote: > +static inline bool dynamic_netconsole_enabled(void) > +{ > + return IS_ENABLED(CONFIG_NETCONSOLE_DYNAMIC); > +} Why the separate static inline? We can put IS_ENABLED.. directly in the if condition.