Received-SPF: pass (google.com: domain of linux-kernel+bounces-178139-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 13 May 2024 19:30:59 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: will@kernel.org, robin.murphy@arm.com, kevin.tian@intel.com,
	suravee.suthikulpanit@amd.com, joro@8bytes.org,
	linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org,
	yi.l.liu@intel.com, eric.auger@redhat.com, vasant.hegde@amd.com,
	jon.grimm@amd.com, santosh.shukla@amd.com, Dhaval.Giani@amd.com,
	shameerali.kolothum.thodi@huawei.com
Subject: Re: [PATCH RFCv1 02/14] iommufd: Swap _iommufd_object_alloc and
 __iommufd_object_alloc
Message-ID: <ZkKUo1Z+YKdsUPm8@nvidia.com>
References: <cover.1712978212.git.nicolinc@nvidia.com>
 <43bab81816a7bb08fde868a43d62c439ede91f9f.1712978212.git.nicolinc@nvidia.com>
 <ZkDDlMouOmfTaRRg@nvidia.com>
 <ZkF7EY+COAPYNWwU@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZkF7EY+COAPYNWwU@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?h0YSL8kAKmp6w7FAInWvRey/Jc3HgEzz8nlJQeeoWBWTQtvWhTAoJpb9jclN?=
 =?us-ascii?Q?zmASUCA6hngTXXWnY4qi8nRsY5Xyvs1WIkG3uUXC3T5VSNoJybioIxJrkBE9?=
 =?us-ascii?Q?SilTafhImfMOFm3hbIpxr/cOb6tdWcVF7mWoumVZD2m9Ptd/TJyGEl6p3Q+Z?=
 =?us-ascii?Q?Oz5wkLIpS/TWxcynD7z+RxTcsQVcVyAj419jmFuEmKvNRf4GB2+ml73XoMnl?=
 =?us-ascii?Q?ngpHJWy7JTU5F6DCBFhfTS1ZgxSTq8vqNtzmM8noGrl8TQAWVOHbQiLSklj0?=
 =?us-ascii?Q?Fyw+r6XqfY2UTOCr+eZp8NHwDvzqDFjlb9z2c4zvF1IQePUJpr4da+dhvgtr?=
 =?us-ascii?Q?cC9YzGul8MQjvRcjKGRJBiwSXlc9k9P3lyQM5tcX58Kqc5UlXPbEW9v7BAQ+?=
 =?us-ascii?Q?zekuD9WkijJI1ZuD5LKXQyzn7jCMXn9rm6VN5HIU6wuBgV64/8WLahugbi+K?=
 =?us-ascii?Q?FQ7yQHOq1JEHotJCQV48qOzlR33ydLRF2CICgms6+4T4HmqowdlVZV3YESnu?=
 =?us-ascii?Q?5dQNK0iwTdlMFEjP+4p+RaNWOYvxdcwTEjtHMX436EiwX44DAAZqlNcmYjND?=
 =?us-ascii?Q?8hpd0cVIOEKo0jNc8TqIzqzEj7twDLUOiJzf7wm/Iyuugi2Ku5WFSWg174Oh?=
 =?us-ascii?Q?Vr4NhSe1skuOHNvjS7/y9eycaY7HfNtxlX1gD1ZAR2FigMenlev+dgBeHKK3?=
 =?us-ascii?Q?esbMSRw2B6omvyZM8lyfZ2PnJwGMgbQTlwD+MDmFgONkUuyV0dwoWZFJD/8R?=
 =?us-ascii?Q?RVlEnQiLjSbQx7mpyUmxkRLGFdHIEXWWMTcIHn2501WGLA0cT1ZH8oTQAXP6?=
 =?us-ascii?Q?oG/djgETZddrJzYVU4FTfNipTSxyvxLI6BcUcgksC+ul334pjglsB6T/VDaf?=
 =?us-ascii?Q?VtJeFnJYpPOgeLm06NQYCmvDu+AUw8JV0uKw2XZqH5DaZOxF/bPOvQwvtk7Z?=
 =?us-ascii?Q?wlTHW2MQITN0g8UWoI8zLY6XdCeJNZqRjAykSZNJvZTunOd6HMQl2O+V489U?=
 =?us-ascii?Q?okLT3BrpgLyLHWBk8n4rMXP0d3fRFfTKQSmOTaTpl3ykW7MG6kUa+fx7gAYa?=
 =?us-ascii?Q?yoQNm3mCchRHLh6DbnTRXh0o+VvLhOcEnsJnrKXAte/hQ00ZiX58wbZdc7zE?=
 =?us-ascii?Q?5uMrGdyouQY6tG7eHFuiLHbUPnM5ridLNfI8FTp2O+LnrlDcst+3xEfCGMnZ?=
 =?us-ascii?Q?ZpQSOhddNOcvpD2/9MV1kX4FIZer1ah3kzIC6Bn8LTvC9pLlwg+m9sLD7K3Z?=
 =?us-ascii?Q?Mum3sV/+Vuui6Xq5+wUTUZhTXK7CF+hLjI2/dxC3S/rHYLPg0h5U/pltGaw+?=
 =?us-ascii?Q?zTi1GuEHJ9mgdaOjfHsmzNXk+pEbDet7zgbh0mIjrCroXtSKvPLHDk3t36/l?=
 =?us-ascii?Q?oiUg3Bn/iCpOo0AQD+wYqk1hZnJKEzth+fkSu1xTxuMsJr72X+8e6zfVn7Iw?=
 =?us-ascii?Q?B0yEG1qAH3glnfFCFahw9iE/gXOMGZkUaMKINlLDOSC6rwpJMw2tgy2sJM5Y?=
 =?us-ascii?Q?XN5GkXDZuTBoJXBKdol25xLK/N7QTO/VeFgkxNCtECnWB/GfMOde2Yqc+W7J?=
 =?us-ascii?Q?rWpp5VBG0rLLwSMnMxo=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d0b4dba-8201-42b9-12c0-08dc739c5da4
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2024 22:31:00.4317
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VNq9IbJ/HhTAkdJn8joxZfDQmcK8uIGIVUoM4HSOMHCND0deHoSpw1OCF7Vyhg3Q
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5709

On Sun, May 12, 2024 at 07:29:37PM -0700, Nicolin Chen wrote:
> On Sun, May 12, 2024 at 10:26:44AM -0300, Jason Gunthorpe wrote:
> > On Fri, Apr 12, 2024 at 08:46:59PM -0700, Nicolin Chen wrote:
> > > Currently, the object allocation function calls:
> > > level-0: iommufd_object_alloc()
> > > level-1:     ___iommufd_object_alloc()
> > > level-2:         _iommufd_object_alloc()
> > 
> > Let's give __iommufd_object_alloc() a better name then
> > 
> > It is a less general version of iommufd_object_alloc(), maybe
> > iommufd_object_alloc_elm() ?
> 
> With the level-3 allocator, something like the followings?
> 
> level-0: iommufd_object_alloc()
> level-1:     __iommufd_object_alloc()
> level-2:         iommufd_object_alloc_elm()
> level-3:             __iommufd_object_alloc_elm()
> 
> In this case, this patch will be:
> "iommufd: Rename _iommufd_object_alloc to iommufd_object_alloc_elm"

Yes

Jason