Received-SPF: pass (google.com: domain of linux-kernel+bounces-178143-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 13 May 2024 19:36:24 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: will@kernel.org, robin.murphy@arm.com, kevin.tian@intel.com,
	suravee.suthikulpanit@amd.com, joro@8bytes.org,
	linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org,
	yi.l.liu@intel.com, eric.auger@redhat.com, vasant.hegde@amd.com,
	jon.grimm@amd.com, santosh.shukla@amd.com, Dhaval.Giani@amd.com,
	shameerali.kolothum.thodi@huawei.com
Subject: Re: [PATCH RFCv1 12/14] iommufd: Add IOMMUFD_OBJ_VQUEUE and
 IOMMUFD_CMD_VQUEUE_ALLOC
Message-ID: <ZkKV6HcHEw5vetV4@nvidia.com>
References: <cover.1712978212.git.nicolinc@nvidia.com>
 <b0ee53af3f59602834e67ddf86c748ca304da175.1712978213.git.nicolinc@nvidia.com>
 <ZkDZ/YO0jqZOlRtA@nvidia.com>
 <ZkGZ7+37HnLlT6Jn@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZkGZ7+37HnLlT6Jn@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?TZZ5Tc9USlLetUsEJg95EiYZJ86ZlKpICHdpCWWO3oHakHnjG0OgiMwUaiZF?=
 =?us-ascii?Q?sYuzd9rHHWGJK7L48aeesQzNvpv1/c3qsLWXvgAwryXBPyj48a/VDMR0iS/M?=
 =?us-ascii?Q?/FCkq8vnlFoZp3Cewry70Go9/OfWZZYqfQ2jTNLhNEGQIj7fV0fjtRMky7VJ?=
 =?us-ascii?Q?Xl/0+q8T9sD0K+7/NkAl8mfenJhWFvEcfSM/ve9B+gCnYcIOoB6sRii1pYWj?=
 =?us-ascii?Q?o3L3BYugWK8MVd4gGYqtIkebCTqTVJMho6EcB/BoNizzNaHslA3X0qxrNbmr?=
 =?us-ascii?Q?6Am1YD7lhvheUG/gB271yIvrUZx8uJp6YZoxw+oYXwixqoztSQJe7T0z/Kny?=
 =?us-ascii?Q?fxCX7hx0EiNFXzZf1GEwj8too0CWHKG4U9Up3aIY8h+T2s0j+PWextT25Mcl?=
 =?us-ascii?Q?C14JGw/GB0JoGrJihhcoT0UuPeGkpCdJ9NI5MsVTOAEjOrL8aqEbW+PEo70h?=
 =?us-ascii?Q?oieWVfxuuwazpvzmZaszdHY6tlPmOMShAFZF5U6X2d9AXCb0l40c4tPdzxMf?=
 =?us-ascii?Q?97fySjlgw/0HxHszrF8w4oM7KFq/xY+hw/Ks8eP5jgG3s48ewdTn5OgU8ykQ?=
 =?us-ascii?Q?yADB55/VWni9zFYpSynRR5WEf70J6bgCDFjsDGPvPdhBL/ygZJ2h/jzmQalE?=
 =?us-ascii?Q?84eDNBq1GnXQs00GpQl1ZVRLB/Vc/YAgomIcz5YAoke/wZhoc7FxQbiTG+j+?=
 =?us-ascii?Q?pp+lNzWJ2WvE/pYMpnNsdEyC69sLQRDlCGvhNp7FFRpJjuyXDinYUthuWAlq?=
 =?us-ascii?Q?UDOPu/l02a14HJKhVE1Ve3esnXHG0BIBk1OeteeM8NCgcWUlddMK0rZWU38G?=
 =?us-ascii?Q?Q7tcDjS2QMArPtcGMbDTLdtQcKGwqyQR7v27Zrl+krIq3XtGkM50R5qNFQGI?=
 =?us-ascii?Q?t1k6n0lM2hVGb5NbwO0Wjh5e1OhMxgFBxZmNvfHAFMObv+PN/GypyMZmk733?=
 =?us-ascii?Q?YpvFWieAEtno4f8+bm5JnK71fldFHNqB1Ji8lFx+DbDr0KG1ZCe5PGd978q4?=
 =?us-ascii?Q?ctQdeatvPtTTvhBFo2cFgYEueAu72kMAkFxmLLRt+E7SmCaPU7Of3sdZjltL?=
 =?us-ascii?Q?J9nqv9I3NQzFMCAIhZU1J5m5BK/BM12WDvo8giOU8K263N3Y9TVm8/EmF4E0?=
 =?us-ascii?Q?qWJf8DOjijfqH2w95z3+EvaQl+xQq2jE/4mVkW+mBKfSFnF5GO1m6jXMX6aw?=
 =?us-ascii?Q?WLVmU/CMZShoD8R7M7npQmKekiusxQzXEBpaMLfWCIUihv7oLMiqpPiavKEd?=
 =?us-ascii?Q?f43lr1PEVQfynWeBniaGI/WjARzlxxuMEO3y7CPBvnh9AhG6P4uNFYihFBAo?=
 =?us-ascii?Q?yUGO/4bxyrC8h/ssguQ6E2VvbUcQA0mupFwZRNlkODpUPow8ZmjbH+ji5f1k?=
 =?us-ascii?Q?dfbUAlgoBpphrg2qDDHQQMW7py9pguYNv0XoEzmIV3R3W7upaq7qVKIS4Gc5?=
 =?us-ascii?Q?I5Wx6BqcgecfyoNSqJrScHqj8Gny+iXorsjIQaF22qaFBgzS3RtP2WIZzITI?=
 =?us-ascii?Q?3ygSzyfMQ/1HAdV+7QIGV/grg1vMY6SLmJ6bw7hoExKJj2wlHVfr9YulyJXO?=
 =?us-ascii?Q?xhBQ2868Os7lNS7zrUs=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51c4f063-3fa0-4025-a419-08dc739d2031
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2024 22:36:27.1611
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d99f+Aryzk2erfPuPP3zXFjtEoMYjgJJbocxEU0D38Sc8dPTRTyE7rKTFUOOFTO4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8987

On Sun, May 12, 2024 at 09:41:19PM -0700, Nicolin Chen wrote:
> On Sun, May 12, 2024 at 12:02:21PM -0300, Jason Gunthorpe wrote:
> > On Fri, Apr 12, 2024 at 08:47:09PM -0700, Nicolin Chen wrote:
> > 
> > > +/**
> > > + * struct iommu_vqueue_alloc - ioctl(IOMMU_VQUEUE_ALLOC)
> > > + * @size: sizeof(struct iommu_vqueue_alloc)
> > > + * @flags: Must be 0
> > > + * @viommu_id: viommu ID to associate the virtual queue with
> > > + * @out_vqueue_id: The ID of the new virtual queue
> > > + * @data_type: One of enum iommu_vqueue_data_type
> > > + * @data_len: Length of the type specific data
> > > + * @data_uptr: User pointer to the type specific data
> > > + *
> > > + * Allocate an virtual queue object for driver-specific HW-accelerated queue
> > > + */
> > > +
> > > +struct iommu_vqueue_alloc {
> > > +	__u32 size;
> > > +	__u32 flags;
> > > +	__u32 viommu_id;
> > > +	__u32 out_vqueue_id;
> > > +	__u32 data_type;
> > > +	__u32 data_len;
> > > +	__aligned_u64 data_uptr;
> > 
> > Some of the iommus will want an IPA here not a user pointer. I think
> > it is fine API wise, we'd just add a flag to indicate data_uptr is an
> > IPA.
> 
> Ack.

To be clear, add a flag someday, no change needed

Jason