Received-SPF: pass (google.com: domain of linux-kernel+bounces-178167-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240417053530.30995-1-wangyao@lemote.com> <Zj_0KU2cInEUbsW3@bombadil.infradead.org>
In-Reply-To: <Zj_0KU2cInEUbsW3@bombadil.infradead.org>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Tue, 14 May 2024 08:10:31 +0900
Message-ID: <CAK7LNARCxO9rysrJyZo1uVQ+83YJJc5KFqY65+_3vWwSa80xtQ@mail.gmail.com>
Subject: Re: [PATCH] modules: Drop the .export_symbol section from the final modules
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: wangyao@lemote.com, ainux.wang@gmail.com, linux-modules@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, May 12, 2024 at 7:42=E2=80=AFAM Luis Chamberlain <mcgrof@kernel.org=
> wrote:
>
> On Wed, Apr 17, 2024 at 01:35:30PM +0800, wangyao@lemote.com wrote:
> > From: Wang Yao <wangyao@lemote.com>
> >
> > Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost")
> > forget drop the .export_symbol section from the final modules.
> >
> > Signed-off-by: Wang Yao <wangyao@lemote.com>
>
> Masahiro, commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by
> modpost") was your change, wanna address / take it through your
> tree? It makes sense to me though.


Yes, applied now.

Thanks for the reminder.


>
>   Luis
>
> > ---
> >  scripts/module.lds.S | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/scripts/module.lds.S b/scripts/module.lds.S
> > index bf5bcf2836d8..89ff01a22634 100644
> > --- a/scripts/module.lds.S
> > +++ b/scripts/module.lds.S
> > @@ -13,6 +13,7 @@ SECTIONS {
> >       /DISCARD/ : {
> >               *(.discard)
> >               *(.discard.*)
> > +             *(.export_symbol)
> >       }
> >
> >       __ksymtab               0 : { *(SORT(___ksymtab+*)) }
> > --
> > 2.27.0
> >


--=20
Best Regards
Masahiro Yamada