Received-SPF: pass (google.com: domain of linux-kernel+bounces-178218-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240513192439.18473-1-rdunlap@infradead.org>
In-Reply-To: <20240513192439.18473-1-rdunlap@infradead.org>
From: Ian Rogers <irogers@google.com>
Date: Mon, 13 May 2024 17:44:41 -0700
Message-ID: <CAP-5=fX020He2fdmm-tzFY383tSaaOB4q6OBzEtFHgXOW+S00w@mail.gmail.com>
Subject: Re: [PATCH] perf Documentation: clarify sysfs event names characters
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Kan Liang <kan.liang@linux.intel.com>, 
	Arnaldo Carvalho de Melo <acme@redhat.com>, linux-perf-users@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 13, 2024 at 12:24=E2=80=AFPM Randy Dunlap <rdunlap@infradead.or=
g> wrote:
>
> Specify that perf event names in sysfs must not contain mixed lower and
> upper case characters and that they may contain numbers, ".", "_",
> or "-" as well.
>
> Fixes: 785623ee855e ("perf Document: Sysfs event names must be lower or u=
pper case")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Kan Liang <kan.liang@linux.intel.com>
> Cc: Ian Rogers <irogers@google.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: linux-perf-users@vger.kernel.org

Reviewed-by: Ian Rogers <irogers@google.com>

Looks good to me! Thanks,
Ian

> ---
>  Documentation/ABI/testing/sysfs-bus-event_source-devices-events |   10 +=
+++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff -- a/Documentation/ABI/testing/sysfs-bus-event_source-devices-events=
 b/Documentation/ABI/testing/sysfs-bus-event_source-devices-events
> --- a/Documentation/ABI/testing/sysfs-bus-event_source-devices-events
> +++ b/Documentation/ABI/testing/sysfs-bus-event_source-devices-events
> @@ -37,11 +37,13 @@ Description:        Per-pmu performance monitor
>                 performance monitoring event supported by the <pmu>. The =
name
>                 of the file is the name of the event.
>
> -               As performance monitoring event names are case
> -               insensitive in the perf tool, the perf tool only looks
> -               for lower or upper case event names in sysfs to avoid
> +               As performance monitoring event names are case insensitiv=
e
> +               in the perf tool, the perf tool only looks for all lower
> +               case or all upper case event names in sysfs to avoid
>                 scanning the directory. It is therefore required the
> -               name of the event here is either lower or upper case.
> +               name of the event here is either completely lower or uppe=
r
> +               case, with no mixed-case characters. Numbers, '.', '_', a=
nd
> +               '-' are also allowed.
>
>                 File contents:
>