Received-SPF: pass (google.com: domain of linux-kernel+bounces-178221-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <66e5bf06-6302-47f3-9bdd-5213a1e6c570@quicinc.com>
Date: Tue, 14 May 2024 08:52:59 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm64: dts: qcom: sm8550: Move some common usb node
 settings to SoC dtsi
To: Krzysztof Kozlowski <krzk@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
        <conor+dt@kernel.org>
CC: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <kernel@quicinc.com>
References: <20240513084701.1658826-1-quic_tengfan@quicinc.com>
 <829162d0-2fef-4bbc-9417-13e8ca96150c@kernel.org>
From: Tengfei Fan <quic_tengfan@quicinc.com>
In-Reply-To: <829162d0-2fef-4bbc-9417-13e8ca96150c@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 5/13/2024 4:56 PM, Krzysztof Kozlowski wrote:
> On 13/05/2024 10:47, Tengfei Fan wrote:
>> All the board dts which base on SM8550 SoC dtsi refer to usb_1_dwc3_ss,
>> usb_dp_qmpphy_usb_ss_in, orientation-switch and usb-role-switch, so move
>> them to SoC dtsi from board dts.
> 
> That's not really a good argument. Argument is that it is a SoC property
> (vs being a property of a board). Provide rationale for that. You are
> moving things just because they look common, so to me it looks really
> unjustified.

In the next version of the patch series, I will modify the commit 
message to more accurately indicate why they need to be moved SoC dtsi.

> 
>> OTG is default for dr_mode, so it can be dropped from board dts.
> 
> Separate patch, see submitting patches.

In the next version of the patch series, I will separate this.

> 
> Best regards,
> Krzysztof
> 

-- 
Thx and BRs,
Tengfei Fan