Received-SPF: pass (google.com: domain of linux-kernel+bounces-178222-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 13 May 2024 17:53:55 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Matt Jan <zoo868e@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
 netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Matt Jan
 <matt_jan@trendmicro.com>
Subject: Re: [PATCH] connector: Fix invalid conversion in cn_proc.h
Message-ID: <20240513175355.2b34918e@kernel.org>
In-Reply-To: <20240510154919.874-1-zoo868e@gmail.com>
References: <20240510154919.874-1-zoo868e@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 10 May 2024 23:49:19 +0800 Matt Jan wrote:
> From: Matt Jan <matt_jan@trendmicro.com>
> 
> The implicit conversion from unsigned int to enum
> proc_cn_event is invalid, so explicitly cast it
> for compilation in a C++ compiler.
> /usr/include/linux/cn_proc.h: In function 'proc_cn_event valid_event(proc_cn_event)':
> /usr/include/linux/cn_proc.h:72:17: error: invalid conversion from 'unsigned int' to 'proc_cn_event' [-fpermissive]
>    72 |         ev_type &= PROC_EVENT_ALL;
>       |                 ^
>       |                 |
>       |                 unsigned int
> 
> Signed-off-by: Matt Jan <zoo868e@gmail.com>

Why not. But please fix the checkpatch warning:

CHECK: No space is necessary after a cast
#36: FILE: include/uapi/linux/cn_proc.h:72:
+	return (enum proc_cn_event) (ev_type & PROC_EVENT_ALL);
-- 
pw-bot: cr