Received-SPF: pass (google.com: domain of linux-kernel+bounces-178291-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <3ade5078-0105-4d10-86d2-02806d48fbd0@arm.com>
Date: Tue, 14 May 2024 08:55:43 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mm/rmap: optimize folio_move_anon_rmap()
Content-Language: en-US
To: David Hildenbrand <david@redhat.com>,
 Chen Taotao <chentt10@chinatelecom.cn>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20240512123555.8358-1-chentt10@chinatelecom.cn>
 <7a4d4992-4c8a-43b9-8c41-a938bc3cec67@redhat.com>
From: Anshuman Khandual <anshuman.khandual@arm.com>
In-Reply-To: <7a4d4992-4c8a-43b9-8c41-a938bc3cec67@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 5/13/24 21:07, David Hildenbrand wrote:
> On 12.05.24 14:35, Chen Taotao wrote:
>> When a folio belongs exclusively to one process after a COW event,
>> folio_move_anon_rmap() always moves the folio into the anon_vma
>> belongs only to this process.
>>
>> However, if the folio already belongs to the anon_vma of the this
>> process, we don't need to move it again. In this case, we first
>> check if the folio already belongs to the anna_vma of the this
>> process, and only move it if it does not.
>>
>> The above changes may improve the performance of vm faults in some
>> scenarios, because the performance loss caused by WRITE_ONCE() is
>> much more than the performance loss caused by add a judgment.
> 
> Please proof that by real numbers. I don't think it will make a real difference, and we likely don't want that change.

Agreed, only scenarios when pre-condition check makes any sense is
if subsequent actions are expensive such as writing into registers
etc. But in this case both 'if' and 'WRITE_ONCE' statements are of
comparable cost, hence adding additional conditional check is only
going to increase the cost on average i.e when both gets executed.