Received-SPF: pass (google.com: domain of linux-kernel+bounces-178327-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 14 May 2024 12:26:50 +0700
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Huichun Feng <foxhoundsk.tw@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Jonathan Corbet <corbet@lwn.net>,
	Kent Gibson <warthog618@gmail.com>, linux-gpio@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mao Zhu <zhumao001@208suo.com>, Ran Sun <sunran001@208suo.com>,
	Xiang wangx <wangxiang@cdjrlc.com>,
	Shaomin Deng <dengshaomin@cdjrlc.com>,
	Charles Han <hanchunchao@inspur.com>,
	Attreyee M <tintinm2017@gmail.com>, LihaSika <lihasika@gmail.com>
Subject: Re: [PATCH] docs: gpio: prefer pread(2) for interrupt reading
Message-ID: <ZkL2GkCsyKYRckj7@archie.me>
References: <20240514041223.800811-1-foxhoundsk.tw@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="tApy7N8s/kQ5ZoLI"
Content-Disposition: inline
In-Reply-To: <20240514041223.800811-1-foxhoundsk.tw@gmail.com>


--tApy7N8s/kQ5ZoLI
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, May 14, 2024 at 12:12:23PM +0800, Huichun Feng wrote:
> In legacy sysfs GPIO, when using poll(2) on the sysfs GPIO value for
> state change awaiting, a subsequent read(2) is required for consuming
> the event, which the doc recommends the use of lseek(2) or
> close-and-reopen to reset the file offset afterwards.
>=20
> The recommendations however, require at least 2 syscalls to consume
> the event. Gladly, use of pread(2) require only 1 syscall for the
> consumption. Let's advertise this usage by prioritizing its placement.
>=20
> Signed-off-by: Huichun Feng <foxhoundsk.tw@gmail.com>

LGTM, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

--=20
An old man doll... just what I always wanted! - Clara

--tApy7N8s/kQ5ZoLI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZkL2GQAKCRD2uYlJVVFO
owkxAP4+j0XIuZjzer3KEU2hBpV2m/fGG4rwaXE66ovkHGdkEQEA6k+r0sif9hPK
fSFs0eCsgOkyXQfo0mfLntsTJh9lVA8=
=0QDZ
-----END PGP SIGNATURE-----

--tApy7N8s/kQ5ZoLI--