Received-SPF: pass (google.com: domain of linux-kernel+bounces-178334-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <f0586fff-c47a-4610-bb31-5a5ad743a1be@ti.com>
Date: Tue, 14 May 2024 11:18:33 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next] dt-bindings: net: ti: icssg_prueth: Add
 documentation for PA_STATS support
Content-Language: en-US
To: Krzysztof Kozlowski <krzk@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Rob Herring <robh@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>, Eric
 Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>
CC: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <srk@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
        <r-gunasekaran@ti.com>, Roger Quadros <rogerq@kernel.org>
References: <20240430122403.1562769-1-danishanwar@ti.com>
 <8ce66e56-7f41-4f2d-ac10-1328784a51af@kernel.org>
From: MD Danish Anwar <danishanwar@ti.com>
In-Reply-To: <8ce66e56-7f41-4f2d-ac10-1328784a51af@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

Hi Krzysztof,

On 01/05/24 3:56 pm, Krzysztof Kozlowski wrote:
> On 30/04/2024 14:24, MD Danish Anwar wrote:
>> Add documentation for ti,pa-stats property which is syscon regmap for
>> PA_STATS register. This will be used to dump statistics maintained by
>> ICSSG firmware.
>>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>> ---
>>  Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> index e253fa786092..abf372f7191b 100644
>> --- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> @@ -55,6 +55,11 @@ properties:
>>      description:
>>        phandle to MII_RT module's syscon regmap
>>  
>> +  ti,pa-stats:
>> +    $ref: /schemas/types.yaml#/definitions/phandle
>> +    description:
>> +      phandle to PA_STATS module's syscon regmap
> 
> One register needed? Then use phandle-array syntax - see examples.

No this is not one register only. PA_STATS is a set of registers. My bad
I should have mentioned *registers* in the commit description. Just like
MII_RT and MII_G_RT modules, PA_STATS is also a set of registers where
different statistics are dumped by ICSSG firmware. Moduling this as
syscon will help the driver read/write those statistics using
regmap_read() / write() just like the driver currently read / write
registers from mii_rt and mii_g_rt regmaps.

I have tried to describe this node *ti,pa-stats* the same way as
"ti,mii-g-rt" and "ti,mii-rt"

> Explain in description the purpose of this register in the context of
> *this* device.
> 

Sure will do that.

> Best regards,
> Krzysztof
> 

-- 
Thanks and Regards,
Danish