Received-SPF: pass (google.com: domain of linux-kernel+bounces-178351-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: zhida312@outlook.com
To: rafael@kernel.org,
	viresh.kumar@linaro.org
Cc: andypma <andypma@tencent.com>,
	Huang Rui <ray.huang@amd.com>,
	"Gautham R. Shenoy" <gautham.shenoy@amd.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
	Perry Yuan <perry.yuan@amd.com>,
	linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [v2] cpufreq: amd-pstate: fix the memory to free after epp exist
Date: Tue, 14 May 2024 14:43:27 +0800
Message-ID:
 <PUZPR01MB51206C1D9F3E2005B5BECCBA92E32@PUZPR01MB5120.apcprd01.prod.exchangelabs.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: PUZPR01MB5120:EE_|SEZPR01MB4453:EE_
X-MS-Office365-Filtering-Correlation-Id: 764f445f-5521-407b-3b36-08dc73e13f49
X-Microsoft-Antispam:
	BCL:0;ARA:14566002|461199019|440099019|3412199016|3430499023|3420499023;
X-Microsoft-Antispam-Message-Info:
	syjQjQ1U8Xn3cbh2X523XKNBZHgzSggUY5brFNRFD4BMa4ypd6Dsu11hOAOmxYg+KwN+6VTgzi84Ppy3nu7VGTBo85ZjMSXLH2JoQbuRIkVGON2zSpyygtB0uzIhPOYV8LT3wmh3bRsQwMe57nGoyVb38/XWP6fYt2b0my5IMM1ef/CKUzARex2BZvNq4rIAoNhpE/27jPNMI7tPXXrOtWMDpwo7I5zWpQJMoW9xhYyEi6L6dROyP6hJWqHtTDzKtFJQEHHqa5q+BPYqap3dg/kVMjvCAYc3egFsXUedJ5FJkcrqiebRm4cujHeIhkEMHma84ztMEuI6xE9jaD1qDsLMTcNmUkWtGjgepGZG+IBkBoMCggQIiKuvfUoRukl3LhozRXYuF6VNFr38DZ++ixpR8Cg5dmeH+V9LrJKWY7/W4zw/th8G0BDKfSypYt/NFnPXEFjci6IVnuvo+g0KSMXfofg6qrgBhwWL64kHw9xLb/Qg8uJaCnHKDG8PjEV0c6whJzr5e9MO1jbFyQDSPaf8q8H41unaCWfC3seFAtSSSL7ZzuGyigHrs86xt7J/
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?BcSJ8nO9WCLGGAfNzbYLr9y9eomWx70KrfvFhLflC19a0GyG6UU+FTdGV51l?=
 =?us-ascii?Q?WZs57ZO8UlOPCq4xIxBtHyZHzfPqZa/wuo9dOBS49ccf157pqtNkMhcszk2x?=
 =?us-ascii?Q?psDOekSgjvrCzbGcLMtWlCUgfJD4cWJ43gg7v2n5+F2I6Kgv239udSCheQfp?=
 =?us-ascii?Q?9l8YvDzOU+ytBE36gcTRQVjjd9XbWKi+1sY9wGkVAgNYnEm/EJYerZ4xI8Ha?=
 =?us-ascii?Q?2CQ4fFYIS53cO6eBi3FOO50cE8p6HQfnYzX6YwoARcBG6xQt81pbz2yPBoK3?=
 =?us-ascii?Q?A+EFbLK9kPno4pfG0uZyVN/JL9hmjEfQzvNz4utefAZSaFzR0bQQPDDn+zhn?=
 =?us-ascii?Q?+jZW5FUzWByy7caqd+r/+6nKN+8fRFKjLrOanxbYHJ3U9vzwWJ0wFakYECMy?=
 =?us-ascii?Q?71kxSvsnwASMLHxJtXhuwKz0hh4g409xmGjiXT0tsGtVB1t+JVK8DsO2mRl9?=
 =?us-ascii?Q?S0co2NeSzNtL0SjwaQnpxX9b1Ok0JwcQzIs7L7qztea9W/Qlg68Oapve6lfl?=
 =?us-ascii?Q?Qz2WsZM0nEHTuTtL8V3EMbmEtuX7gdDcU2W/kG4myBiJtQQdfVVkrrATyWUV?=
 =?us-ascii?Q?8Fb29lc/nRpZPnvSva5vpkUC2h2JnhLlHoYvH/cAPXt64sGFkrw4jl5LdBUp?=
 =?us-ascii?Q?4I+zfzZ5PNTazuxTJ7Mg8QWGT6MugNBeoCZrhhKUDseK562+XxmIbXZRoeVi?=
 =?us-ascii?Q?MaHfrKfiRQinhHXAefO0adOdJv2HdB+uFd6j+/LbxBiph+J+xwbU0XJg4b3H?=
 =?us-ascii?Q?Ns/YMEc6wl5vFketLSilZIQmifbXZOOU4BfiraAaCAlEEm5NVepi/LDBAkul?=
 =?us-ascii?Q?qJn30JMcKaNWhDlfTAHoAaAq1Z6G5vK+FfjQ05PtYzVRn5hsda63aPvstHCz?=
 =?us-ascii?Q?UYvCaklKJD+8mJtwq96yWOjkj9svHfwQfZcU6n3Tm1pjr3XSGYFJM8C6z3jB?=
 =?us-ascii?Q?jSUy0QrX4uHbn5OveKIbL7oHQzJE0xKdWVJg4Qu5IEVzqcUzfJle0WyjjhCC?=
 =?us-ascii?Q?cr2jdy6QscrhhQfrZS3ZCPIejau5I6WJ+BnHahpG2tXgwWl6HZwkUE6Fse6n?=
 =?us-ascii?Q?R/z+rXTeQFZ4WqUW0drdE3XvUr1tqZUdFpjq1IjkeWtWckUK97j48pUv/ywd?=
 =?us-ascii?Q?EGYykIv3MbXdO5sshzGbA4OxsUuk/34bMcHBf6sX9kPNfaC7/v407YJlP/5s?=
 =?us-ascii?Q?7gqlURu7rpY8ytg71ZT8XpkycvWzOGYMGgkFCfQnXgTiUn5ab+3TUN5Szhw?=
 =?us-ascii?Q?=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 764f445f-5521-407b-3b36-08dc73e13f49
X-MS-Exchange-CrossTenant-AuthSource: PUZPR01MB5120.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2024 06:44:04.9743
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR01MB4453

From: andypma <andypma.tencent.com>

the cpudata memory from kzmalloc in epp init function is
not free after epp exist, so we should free it.

Signed-off-by: andypma <andypma@tencent.com>

Changes since v1:
	check whether it is empty before releasing.
	set driver_data is NULL after free.
---
 drivers/cpufreq/amd-pstate.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 6a342b0c0140..e100c5b6c9b2 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -1441,6 +1441,13 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
 
 static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy)
 {
+	struct amd_cpudata *cpudata = policy->driver_data;
+
+	if(cpudata) {
+		kfree(cpudata);
+		policy->driver_data = NULL;
+	}
+
 	pr_debug("CPU %d exiting\n", policy->cpu);
 	return 0;
 }
-- 
2.33.0