Received-SPF: pass (google.com: domain of linux-kernel+bounces-178394-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <ZkG4cMe1TFI5w7sc@gmail.com> <CAHk-=wgf=jwo1HZjQN7UeFw7iYPtQ_i0ri7JNOci+7Rn5-pDcg@mail.gmail.com>
In-Reply-To: <CAHk-=wgf=jwo1HZjQN7UeFw7iYPtQ_i0ri7JNOci+7Rn5-pDcg@mail.gmail.com>
From: Ard Biesheuvel <ardb@kernel.org>
Date: Tue, 14 May 2024 09:27:14 +0200
Message-ID: <CAMj1kXHm_tmBPNTvnvn3r6myeRo5x1fX3_J73UA1j4bVBo_PSg@mail.gmail.com>
Subject: Re: [GIT PULL] x86/boot changes for v6.10
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org, 
	"the arch/x86 maintainers" <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>
Content-Type: text/plain; charset="UTF-8"

On Tue, 14 May 2024 at 03:03, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Sun, 12 May 2024 at 23:51, Ingo Molnar <mingo@kernel.org> wrote:
> >
> >  - Re-introduce a bootloader quirk wrt. CR4 handling
>
> I've pulled this, but shouldn't the compressed boot also just stop
> setting the G flag that it didn't understand?
>

I agree. But not setting CR4 to a known value is what caused the
regression, and that could cause other problems down the road, so
fixing it was arguably more important.

More than happy to send another patch to clear the G bit from the page
table entries created by the decompressor, but at this point, it
shouldn't make a difference.