Received-SPF: pass (google.com: domain of linux-kernel+bounces-178419-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Hariprasad Kelam <hkelam@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        Sunil Kovvuri Goutham
	<sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Jerin
 Jacob <jerinj@marvell.com>, Linu Cherian <lcherian@marvell.com>,
        Subbaraya
 Sundeep Bhatta <sbhatta@marvell.com>,
        Naveen Mamindlapalli
	<naveenm@marvell.com>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>
Subject: Re: [PATCH] octeontx2-pf: devlink params support to set TL1 round
 robin priority
Thread-Topic: [PATCH] octeontx2-pf: devlink params support to set TL1 round
 robin priority
Thread-Index: AQHapdPn4dklFnNCykOp5VltXQLq0Q==
Date: Tue, 14 May 2024 07:54:10 +0000
Message-ID: 
 <PH0PR18MB44744704A95A0BAD5AD05856DEE32@PH0PR18MB4474.namprd18.prod.outlook.com>
References: <20240513053546.4067-1-hkelam@marvell.com>
 <20240513161817.048123bf@kernel.org>
In-Reply-To: <20240513161817.048123bf@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?Q1gfEHs6bZ3iNzIYzjrDFmylGAQGD/UAjv/P5yBzrVOHq7iiCj1Tkh6eaOPy?=
 =?us-ascii?Q?OuhXkbkBpaAcuVJqKLhv2cswdoZ2//90bcE7I5abdoWjZpcasBIqysct1dWv?=
 =?us-ascii?Q?r7smOLOA1hw32z/ieYb32a4AiFy3Zn1ZDjFieqnq+qLxGBxrM/eSBEdO7/lZ?=
 =?us-ascii?Q?GXC0oWgQPGTEOJBB86UDbNuzfXeNvNp2hlYLK1BdSXDtSXcxaVTm7gsqLil0?=
 =?us-ascii?Q?5uSS3YQeSnxxCBl3QDBTLUUjuouEOY7QPVTHWxmIoBfdOgYOifMBVG3f/5xV?=
 =?us-ascii?Q?2HiOaMyILi5UfMIToYvJthgRbELVUsKaHbUfO8dT6B5Ai3cD1adXJUASWKzE?=
 =?us-ascii?Q?X8suxdA8SzjkQ4fegAu4A0ArBAuFbeUEi1CtwG0oX0BsBM9VzUpUXBagx2g+?=
 =?us-ascii?Q?gZzqiOcb8Vj3pEC8N5MZPHFO8YV703O8NPY32otyP6K4n9XW2NqtkSaJUEOH?=
 =?us-ascii?Q?wtvoJ6chTppCSxGuToUx/XSXVovCe5fw5ghBNDLz+OhHH34YK2Mv8Lz8/NAv?=
 =?us-ascii?Q?XCb3xgzQ0DsnrLJFhNKd7Bx/fqEaZ2t3AB4Xg++2EvOejE87235+3FUmtpDL?=
 =?us-ascii?Q?De5e3SENDzHU/KvLlO94HbB8YU9qDuuGqqu66Pw6NeWNaSL9hZPwuOvwrYzE?=
 =?us-ascii?Q?zGpR31lS/lRjVOS1wgR2iuMf6LEqJL3rKYp3LRNyp7X7z1hJieQnyitgKcd6?=
 =?us-ascii?Q?lP1V8IJGfqt4i1QkZugFy/TpgM0w3EeS0lN0kbFRtlxCCfxeShdbvCmrOJ8Z?=
 =?us-ascii?Q?I/crVBjEOJ1YIx3oe4F3/3LHNuyjRZC3w4j1Hpi8KJ/1m5ZZwKxAfUHj1Vgb?=
 =?us-ascii?Q?jWTkaeLgjDFPIqwWhMftl8TDpSBgubK1p0bI/F9lF8/4vCMS/n+7xBLKWEa4?=
 =?us-ascii?Q?ZRt/nEkPCO0qPhEW+5Bck2GB2myQFPacfhW+s9Zqj6VM7u6mTz53Ypw9WMtV?=
 =?us-ascii?Q?SrElE7q1nwmBizJN94XcgrBBGd0sbsT/OYchX5Luw+MnlP5Hnd6C44E0TV/7?=
 =?us-ascii?Q?0Qoiy6O0MFR3S4iCseazEj0OsLv/YSZ5UVhlErIQcJRgX3mFS+ifywFm3wOl?=
 =?us-ascii?Q?1MYEQE1Hd0wEzLhOjzm4Iix0o/D9btqlk0XDeohqR8N0GnrYhYoZPAzk9TCk?=
 =?us-ascii?Q?+KphPhq/tGXW5Fo4Veb8bA7+caxX5OcQBfRX8cxKuppGw2PXNPoU7Cr7ELRL?=
 =?us-ascii?Q?SxJiBJCGJ1ryxnpcJGiHgnGDeQ8CKF9GTkll3sEFvYpCNHjexewWd8Y6Bco9?=
 =?us-ascii?Q?/wyoC4mJ+tbVNgPn459HMsjdxarGwhD0vMl5ci+Nt9RzxN1DobcH7LQodH96?=
 =?us-ascii?Q?YLOBoZaJMX9VibTdcev+ZdIM6hzyLXGm/BYd46uYBASxwb0HAMCvHvmsj9Xv?=
 =?us-ascii?Q?JrAYr8zDN/Zx4r0hDeUbsIkOMHt07sIdV/0KLFe8JUjAHiq9Gq/hFTMew64g?=
 =?us-ascii?Q?BiT5YhZzPP0VszlqgxGUzRk/dpSajW8PNFwTgqLOrczUwpiH7A+1MknSrpL8?=
 =?us-ascii?Q?hDR621Lvcx4oYcmvnyzZN1Poqo3+0ZO8a/Z1icI00VK0b4evkb62bC4pd4iU?=
 =?us-ascii?Q?fGOYkQJdtqBgLXFMm65hENuqLOj8NzmV0O8qMM2f?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4474.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a12b631e-c04d-4fe9-fc2e-08dc73eb09ea
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2024 07:54:10.0267
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5YFqOELl7WvmvumGYYvvWDVZIflQtQjvcBsvKo4Ish61PLdc3zJuMaYO+NIhFLc6n5yYQnIYpKhkoE/yQUIuBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR18MB4646
X-Proofpoint-ORIG-GUID: H-I5C1P5wtGVdXGPoWLUA-JfLhZ8k4QQ
X-Proofpoint-GUID: H-I5C1P5wtGVdXGPoWLUA-JfLhZ8k4QQ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-14_03,2024-05-10_02,2023-05-22_02


> On Mon, 13 May 2024 11:05:46 +0530 Hariprasad Kelam wrote:
> > Added support for setting or modifying transmit level (tl1) round
> > robin priority at runtime via devlink params.
> >
> > Octeontx2 and CN10K silicon's support five transmit levels (TL5 to TL1)=
.
> > On each transmit level Hardware supports DWRR and strict priority,
> > depend on the configuration the hardware will choose the appropriate
> > method to select packets for the next level in the transmission process=
.
>=20
> Configuring DWRR parameters seems in no way HW specific.
> Please work on extending one of the Tx scheduling APIs to express this.
>
  The driver offers per-interface DWRR params configuration with HTB offloa=
d.
  Below are example commands having different classid with same priority va=
lue

tc class add dev ethx parent 1: classid 1:1 htb rate 10Gbit prio 1 quantum =
2048
tc class add dev ethx parent 1: classid 1:2 htb rate 10Gbit prio 1 quantum =
3048

Due to a hardware limitation, only a single DWRR group is supported on a tr=
ansmit level.
To address this for physical functions (PFs) sharing a transmit level with =
their virtual functions (VFs),
 a devlink option implemented to configure a priority value.

Thanks,
Hariprasad k

> pw-bot: cr