Received-SPF: pass (google.com: domain of linux-kernel+bounces-178424-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: ran xiaokai <ranxiaokai627@163.com>
To: shy828301@gmail.com
Cc: akpm@linux-foundation.org,
	david@redhat.com,
	linux-kernel@vger.kernel.org,
	linux-mm@kvack.org,
	willy@infradead.org,
	xu.xin16@zte.com.cn,
	ziy@nvidia.com
Subject: Re:  [PATCH linux-next] mm/huge_memory: mark racy access on huge_anon_orders_always
Date: Tue, 14 May 2024 08:03:12 +0000
Message-Id: <20240514080312.661480-1-ranxiaokai627@163.com>
In-Reply-To: <CAHbLzkqg=+Dq40-He5ZBCnzrXEJaBUfXtb2jjBoDKERpM-C07w@mail.gmail.com>
References: <CAHbLzkqg=+Dq40-He5ZBCnzrXEJaBUfXtb2jjBoDKERpM-C07w@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

>>
>> From: Ran Xiaokai <ran.xiaokai@zte.com.cn>
>>
>> huge_anon_orders_always and huge_anon_orders_always are accessed
>> lockless, it is better to use the READ_ONCE() wrapper.
>> This is not fixing any visible bug, hopefully this can cease some
>> KCSAN complains in the future.
>
> A little bit confused here. Did you see complaints from KCSAN?

Not yet.
The only written access to huge_anon_orders_always is when
changing the mTHP sysfs "enabled" knob, I think peple do not
change the mTHP settings frequently.
But the possibility is not zero, please refer to the cgroup related knobs,
I think  wde'd better do the same and this annotation wont lead to any performance issue, right?

>> Also do that for huge_anon_orders_madvise.
>>
>> Signed-off-by: Ran Xiaokai <ran.xiaokai@zte.com.cn>
>> ---
>>  include/linux/huge_mm.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h
>> index de0c89105076..6573430ea600 100644
>> --- a/include/linux/huge_mm.h
>> +++ b/include/linux/huge_mm.h
>> @@ -122,8 +122,8 @@ static inline bool hugepage_flags_enabled(void)
>>          * So we don't need to look at huge_anon_orders_inherit.
>>          */
>>         return hugepage_global_enabled() ||
>> -              huge_anon_orders_always ||
>> -              huge_anon_orders_madvise;
>> +                       READ_ONCE(huge_anon_orders_always) ||
>> +                       READ_ONCE(huge_anon_orders_madvise);
>>  }
>>
>>  static inline int highest_order(unsigned long orders)