Received-SPF: pass (google.com: domain of linux-kernel+bounces-178434-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Yuan, Perry" <Perry.Yuan@amd.com>
To: "zhida312@outlook.com" <zhida312@outlook.com>
CC: andypma <andypma@tencent.com>, "Huang, Ray" <Ray.Huang@amd.com>, "Shenoy,
 Gautham Ranjal" <gautham.shenoy@amd.com>, "Limonciello, Mario"
	<Mario.Limonciello@amd.com>, "linux-pm@vger.kernel.org"
	<linux-pm@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "viresh.kumar@linaro.org"
	<viresh.kumar@linaro.org>, "rafael@kernel.org" <rafael@kernel.org>
Subject: RE: [v2] cpufreq: amd-pstate: fix the memory to free after epp exist
Thread-Topic: [v2] cpufreq: amd-pstate: fix the memory to free after epp exist
Thread-Index: AQHapcohLUw4ziXiGE6Ecaw1Y44u67GWYe7g
Date: Tue, 14 May 2024 08:24:02 +0000
Message-ID:
 <CYYPR12MB865591A37BC2582E247D0A1C9CE32@CYYPR12MB8655.namprd12.prod.outlook.com>
References:
 <PUZPR01MB51206C1D9F3E2005B5BECCBA92E32@PUZPR01MB5120.apcprd01.prod.exchangelabs.com>
In-Reply-To:
 <PUZPR01MB51206C1D9F3E2005B5BECCBA92E32@PUZPR01MB5120.apcprd01.prod.exchangelabs.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels:
 MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=4d401377-1f34-40da-bd43-6e75a16ca611;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD
 Internal Distribution
 Only;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-05-14T08:14:34Z;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: CYYPR12MB8655:EE_|BL1PR12MB5755:EE_
x-ms-office365-filtering-correlation-id: 2f0209c5-3f28-4f4c-2663-08dc73ef363f
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;ARA:13230031|1800799015|376005|366007|38070700009;
x-microsoft-antispam-message-info:
 =?us-ascii?Q?bJqZ2pEyBu8oLVHEMGdrAomFB8+sUtdpjyiDaujyvV6emuFxclEGaIIKf9JW?=
 =?us-ascii?Q?JPWH/WHXx4Qc6BzJtvjYKUC+dzFKYUj+ICuxApoLaXDSLsGXsDRWI14F1OfG?=
 =?us-ascii?Q?Y+KN6HcT1+LC72YkKDrbCmhjZtSo+3Vjqki6aPc7PMLf2p1L+DgpyQbbVdYY?=
 =?us-ascii?Q?+3jqXZ+ujSkid/jJDbvRIoADdgxUXA91heOOjIYUmc1F9ejRXyfpWSyJx+31?=
 =?us-ascii?Q?3gGBqpsLi9GvaBXTFgoTj7xfKjvEDVhjP9bEgGH2I3QdAEABoqHRCypQxzlO?=
 =?us-ascii?Q?c2EJ8fXWWpbOKBiNFhNrZ8bSIPA7UT2pWHmiJgjfmCjes1rIRcrT78U+oYsf?=
 =?us-ascii?Q?Z7lLqoi+jq0++U1FPnMiAiCnS1KxPbjIr2SMNYz82WpVGp6fddY3f2Al61xR?=
 =?us-ascii?Q?mljAZ4HlztKbZV1EHl977ZWbuMAvoI51X8VKF3KIoV7tGeMZUk7OOLHOaLnt?=
 =?us-ascii?Q?98t4UMEzJTYtZP0UPfPN7H1iYgRoNas6ORpNEzUm8w8rdGQIX3DzCy8kDQ+K?=
 =?us-ascii?Q?ve4J/mgy7xVK3XlgcSOouFVOIQ2fenyFIK0qgLxG8zctvKI78Jn4MeX9tBHS?=
 =?us-ascii?Q?8OBdvhNRqn/jBTu81Dp7c5qZerXnP673rCSgcTFk0ze3+JJubWdF30SNiFA9?=
 =?us-ascii?Q?SHUcOiCMCPHeuTHxk8gmg+uLCjsZjzCsu5/0WQ4FsYXHHhI0EfkOQtDrGZ9e?=
 =?us-ascii?Q?wMNbkq6c+WIoO7kO/EK4afkqL33dm73S+pjkp6EyDUMZTmJvs+No/vISQ8n0?=
 =?us-ascii?Q?6DA6WUujfxqoZNzi4vKWcwsctxsbw/WxiTL5inkr5BoHGI6dj2LvhaPt9cMU?=
 =?us-ascii?Q?L94bRM7yKISmUjlVoHAoKghDJFcwBx6xc1jNA6pmOgdAekfZwpXKVV9RZdGG?=
 =?us-ascii?Q?cF7InNWYgL85NdyJDC9oGeYukSU8wYAfIXXmZLxH+td+wPaMYnRgbLKiP0h+?=
 =?us-ascii?Q?gLRnO+b5WUgWkI1ksFlArn8OGayuA9idH6RwZIUEIqKRnd4fWIaq+5jpRAMJ?=
 =?us-ascii?Q?RwzIQqq8z5HU8YRfmZM+7O1+/bBH81Pz/zrJ/q5D0M55XUqgeXmqLYp1Jc/M?=
 =?us-ascii?Q?sj/+uZzjbPR0nC0rSDgvwgnw99I7apVyRVBzladZOYzniDjSNMw3dVnpM39M?=
 =?us-ascii?Q?BfKvtw+LN+swqF2rcJQ+0Ex3Y6MCMMw/9Dppek+OLBGjRLfyhqbM3c+FBZR5?=
 =?us-ascii?Q?acRlLYM5wRIe5Wyj7IsNbDldDQ9dZLW4R8ggTd6LGQjFF01Cj9LGjr8YuY6s?=
 =?us-ascii?Q?CddK/y6uGzm5QkT9D1o25cHDXbtDe9HkzMHJxinoqZIPCMFxhOrQUDSa1rdL?=
 =?us-ascii?Q?ADgf5Qqq5Vt6DiLaU9KyzLMOvF6df83laEwIuk5bp4ELcw=3D=3D?=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CYYPR12MB8655.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(366007)(38070700009);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?55SVp5Njf6wkgm2kpQOraX6rT+47qlZnq5734uOVBsjRcAUK8ZFvFlBNbdn6?=
 =?us-ascii?Q?Z0PPI763d+2AS41NHOHh4Yg9vJ3Mp+QiF+p85rKvsOdKdlbaH4gjGL/fep1b?=
 =?us-ascii?Q?GJTy//1aWDXwcPNDjgh1SU657dA5ORE3gMlpvkm7VvONUgrNpU+FpGTUL05U?=
 =?us-ascii?Q?MzKImLb9jQpTUQrCEFgj5fyfKOrfENSamYX3+80Ic3i7Gs7y5uwW3W5TVvKX?=
 =?us-ascii?Q?KhBJ+DqzcMgccZE+Qua+O8fxVEJ1CUXrezHa4Yt0a04DQWCgIvU7mr29UhwN?=
 =?us-ascii?Q?BCPahE0wwNIdYbnl6o6xaN0geAVE1EMY64uo48hGxz2IEYPw+Xp4vCDTaNX1?=
 =?us-ascii?Q?lfB51iIw6LbmeK/tVV9w31vMzFkF0/0qXZ0pK2G2uqt2FHDnOCEQ0uhWR8Bu?=
 =?us-ascii?Q?qIwVaPHcsuYvYW8poEgjcqrgE0y/RQc94ZFcJF+yvGdAmVSx09ojvD2p6C7b?=
 =?us-ascii?Q?xHw5/btHD+hSRGDu2mfeRFCVEMW8892bFysl8fFRlv+akYxjcVYrUl/07XJK?=
 =?us-ascii?Q?5MDHAzqE69pwjroGqAABOLJh+XnnK3pt5A5Pkn8Rh3OwhCaETzf334UpK9LS?=
 =?us-ascii?Q?6rqjbP48vq3SyDAzJSDAsLJYt14Y0YaQul0THRm6xmE8HALDUXIZ/RosBeB9?=
 =?us-ascii?Q?d/JAbQ55uf6QI9k5c7KyU2VJHVJctXNo6iJ2oGdZ26WpxC5Kh37IQPQljlZx?=
 =?us-ascii?Q?fDbC4ZXdftYWTW7vsd6QLr/n2SpqJ1S6HNbTcFzbgtbIMNFum1EYTUYOmzH8?=
 =?us-ascii?Q?oPyPHTY8p6mhMg6iBuW4iYxKtvZ6QOSZJC7SPwEWJ/62iWllwy8orDNNa6m4?=
 =?us-ascii?Q?/freh30P9h3xZz4eLThkNh+n+d8RJBL9HUBLtWc9pkGZmaK9LJJ8qkiA6MH7?=
 =?us-ascii?Q?0nHCo53Y0ZeTd8PsEC5jh5Z91cOpbeRyKioKMF6KLb4TciDWcdrE4jUne58q?=
 =?us-ascii?Q?HgYJCUSvy/P12DJti0VqMsPMpmppBcbcJGkp1+YeYlHlfMxGh5TePdijJ7Ji?=
 =?us-ascii?Q?CXrNcTji6O+sAdC1lla02pS2pWRh1S4JPAGSmmfATND4cU8sn1GqtF7YpNk0?=
 =?us-ascii?Q?CwEXLHJIltvIc54omg8XNm3+M+ELynfbfxPd02MQtYGCmOSJmSQlT50wo4ma?=
 =?us-ascii?Q?DVE0U/N1BOMTCOHUYZZ5OADRqmRLQfxC45TUTHO/fxwOMsb9NLOr6Ug2958X?=
 =?us-ascii?Q?zuaSZReGhigw504wGU2U6olKzSboptLwm91hs3nx12SSyi0IZ2yZIyL8Xu5t?=
 =?us-ascii?Q?V9bHcqSBSMv42ZfPHjOgGybyrvErqtqXnF9ZTzXsrcQSwhBZjoZkBneLOgNU?=
 =?us-ascii?Q?L6i6JcXpVDQbmBqDK98Lid24XxG3SxvDoG+Ln4feYquk1pK2rMJ2smSYJiLr?=
 =?us-ascii?Q?PPK/HcFhh9RWTZN8Wgjby5/lTzRuIcEZyfyCUelAUEyXoFajLFDxHK4oPH1k?=
 =?us-ascii?Q?o6JCTHGLrSZCwODQRBZ0RF4aFiw0voo1JCE8uzkB0H4XhThexEInsHADLFBx?=
 =?us-ascii?Q?8R83RZAo3jW+qsqb5FBrSSnSV3JT2VKX2dX0/9AVnM+lQyJn0w6lLSw66GB0?=
 =?us-ascii?Q?FSQ3ID7SW5rtja3Y0PY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CYYPR12MB8655.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f0209c5-3f28-4f4c-2663-08dc73ef363f
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2024 08:24:02.3707
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dyZDTlDDVlLFWryWcCBTT4n7WQjlnCPuCUfGXN5ty9xXYU3zEnIiCa7gO5An9c0FxNw3dl1FHys5rI93aeH6hQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5755

[AMD Official Use Only - AMD Internal Distribution Only]

> -----Original Message-----
> From: zhida312@outlook.com <zhida312@outlook.com>
> Sent: Tuesday, May 14, 2024 2:43 PM
> To: rafael@kernel.org; viresh.kumar@linaro.org
> Cc: andypma <andypma@tencent.com>; Huang, Ray
> <Ray.Huang@amd.com>; Shenoy, Gautham Ranjal
> <gautham.shenoy@amd.com>; Limonciello, Mario
> <Mario.Limonciello@amd.com>; Yuan, Perry <Perry.Yuan@amd.com>; linux-
> pm@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [v2] cpufreq: amd-pstate: fix the memory to free after epp exist
>
> From: andypma <andypma.tencent.com>
>
> the cpudata memory from kzmalloc in epp init function is not free after e=
pp
> exist, so we should free it.
>
> Signed-off-by: andypma <andypma@tencent.com>

Looks like you need to fix the format of the `Signed-off-by` line in your c=
ommit, you need to ensure that it follows the correct format of including y=
our full name and email address. Here's how you can fix it:

Signed-off-by: Your Full Name <your_email@example.com>

So maybe you want to change like this.
Signed-off-by: Andy Pma <andypma@tencent.com>

Perry.

>
> Changes since v1:
>       check whether it is empty before releasing.
>       set driver_data is NULL after free.
> ---
>  drivers/cpufreq/amd-pstate.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 6a342b0c0140..e100c5b6c9b2 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1441,6 +1441,13 @@ static int amd_pstate_epp_cpu_init(struct
> cpufreq_policy *policy)
>
>  static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy)  {
> +     struct amd_cpudata *cpudata =3D policy->driver_data;
> +
> +     if(cpudata) {
> +             kfree(cpudata);
> +             policy->driver_data =3D NULL;
> +     }
> +
>       pr_debug("CPU %d exiting\n", policy->cpu);
>       return 0;
>  }
> --
> 2.33.0