Received-SPF: pass (google.com: domain of linux-kernel+bounces-178437-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <dbcbe659-08cc-496d-9fa4-6520167ea325@amd.com>
Date: Tue, 14 May 2024 03:30:45 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [v2] cpufreq: amd-pstate: fix the memory to free after epp exist
To: "Yuan, Perry" <Perry.Yuan@amd.com>,
 "zhida312@outlook.com" <zhida312@outlook.com>
Cc: andypma <andypma@tencent.com>, "Huang, Ray" <Ray.Huang@amd.com>,
 "Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
 "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
 "rafael@kernel.org" <rafael@kernel.org>
References: <PUZPR01MB51206C1D9F3E2005B5BECCBA92E32@PUZPR01MB5120.apcprd01.prod.exchangelabs.com>
 <CYYPR12MB865591A37BC2582E247D0A1C9CE32@CYYPR12MB8655.namprd12.prod.outlook.com>
Content-Language: en-US
From: "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <CYYPR12MB865591A37BC2582E247D0A1C9CE32@CYYPR12MB8655.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?anRrckc2YjMwZ3c3WENuUWRCSTIwai9wK0thZW1MaFVDWVo1ZEpzMXhxOUhj?=
 =?utf-8?B?ZGFxR241TGhIZHBZZUpiTFNIMzBvSE53WkxLNkUwK2tLSWZtdVg5eHNxV1Z1?=
 =?utf-8?B?dHNsVmExT1ZUak5yWEpRMUVBK3FpRmpoK3pLeHRneGNkMzdiZytQcWJxY0dX?=
 =?utf-8?B?TEZaT0Y0bHNLaVJmZzAyK0xpTG5MNGNRSUN6cEFzTk9vNGFwSTBvV1FwcjYz?=
 =?utf-8?B?LzRwZ0JDWFZxcHJFTEE5NldUQ1VlUW90cTlnQmVSdUpVWUkxd2RuTEh2SUYz?=
 =?utf-8?B?VHlpcVNNY1ZaT2xvVkJUeFhib3ZCSkpMNFRubXVIUWllYWM0SW9LTmhabFVS?=
 =?utf-8?B?SEFvbVZsbHhDRlRKZEVQSHFUSGFoMUtKZmRvTHNwODYvUmFjMzhBU3pHeGJT?=
 =?utf-8?B?RnhYL01CNXdzMU9ad2dUK1pmQVhVekc0cVgwaFpNQit1MGE3eUJJTzBUeU5Y?=
 =?utf-8?B?SU40NWhaWDZVcW1BbzVtVmM1cnd2TC9MdldSRUVzWjArM0N3TG4wSkF1aEtQ?=
 =?utf-8?B?MEowMVM2UjlyRlpzWmhSNkQ3R3NOUEpTWDROd3RkV3ZObjFSakFOWW4rQjRP?=
 =?utf-8?B?NndXN3lSekE4MjlwMVg3elhxVHl5TDVUbmQ1M0VVbDczUWlLY0JvdnVONFhY?=
 =?utf-8?B?TGlRZEV4N0phclpYRXB5UkxkMXNRY3dHckIyVmZFWEJSZEFPekNQeEx3TG1j?=
 =?utf-8?B?aUc4d3E3dXJMY1pXSzNWN2p0MkR3ZmhvSDJVOXFYZi9ZQlAzSVRsRDRzVnV5?=
 =?utf-8?B?eisvSVo2bmhFQ0lZMWVVUExCcE9PajdJTGpqVFZRN1NnWGhvV2diTVJzWVJ0?=
 =?utf-8?B?VnFZS2pKRENNMjBuNkNpdkJsQTZQQ0ZkVDR6cldmbHlES3Q0WXBPc25VbWw1?=
 =?utf-8?B?ZnM1UjZtSlJ3K010WGlOWEphZ3dlUEhkR1pzNEtvVDVuQzZqeFhsQ0RIL0tu?=
 =?utf-8?B?OE1LUEt3Zk9XRnZZcFRma3d6b0ZIVDFDZXdGWDZLdm9Qc2huMXlQdjhsTXpq?=
 =?utf-8?B?Wkt6OUZsWU1DbDZwWVpodStGektpaVBwcjJ2bjhxamNwcjIyRUxwbElKa0pR?=
 =?utf-8?B?ZXlHcmx1d1lxMlFaZWtBVC84dzJEa0g3RFFZYS9HRzFtOHI0L0hhWEJLNmhO?=
 =?utf-8?B?NGFyYzdRNHpDUXE0UThJbDFtbS8rZ1Y3TlJZb1J3WlROdHIyMUF5R3FqT2pa?=
 =?utf-8?B?N0p6bzBYbmw0TnhGczlqL2prVFd2MXhic29JSk1KTmo4eEtUOWNoTUhWaFM1?=
 =?utf-8?B?QXhwN1NXOWJpdmFsOWNEVURTekwvd1ZFbGVtaFRwZVZDd1RNWU5GNk5hRDNl?=
 =?utf-8?B?T0x4WEFMYjBrOG5nbzlaMXVZZ0l1VzVFeWs5RUZpZEVnWjVxU3ZMZ3RxV0Uy?=
 =?utf-8?B?N08ydlhrcTNpLzlQbHFibXcraTdhcTI4L0E4d0tRSHM5UHRnUG5TaFlvbi9v?=
 =?utf-8?B?Vm1GcXVuUC94NDJKQjVZY0RkZkN2NnFSek16c2V4ZyszRWJqb3BsTkk3RGIx?=
 =?utf-8?B?ZmFaZU1veWd1dkxubXplQUxCcElyazBtdTl4cEd1ZDRhQldzRXVWcHg3Um1r?=
 =?utf-8?B?RlFhYUlhT3BZb2x2NlJKdk5Ib2s0S2Z3dUpXQzg0djlCcWkzZ3JxRUtTTGI0?=
 =?utf-8?B?TzF4eXpKR0NuR3FtTmRHb2ZXeTQ1MkozdTJPR0NwK2ZkRnE0V0p6R3lJWjhj?=
 =?utf-8?B?ZjBONksyaEhVeXZhRjd4SlBOS2Nyc2dQc1lWVi90UVJCajhONndnQVk5eE5a?=
 =?utf-8?B?WFlMWnZ4b1U1RXZOeXBIN2hNd3Jhd0FjcjV2dXZHcDVEYW93clVLY0U1NFl2?=
 =?utf-8?B?SWpuY0RrYW92YjloVC81YjlDMVVmVXBnSFZMa1ZHemdOMnp0U25QTnZLbGho?=
 =?utf-8?B?dWVsUnpzdk9jOVJVWExxMjMwT3BtZzhVTDJKTG9KcHMrMmV3d0FHUkJzTVdW?=
 =?utf-8?B?WVZ2Q1BNN0V3MXJhbGxXRDVnb1lLK1M4VlZ6V1JNWDlwUjdIU1B2Tm40d3p5?=
 =?utf-8?B?dm9KOS90MUtma0VYNkFVdzJKZXExUkREdTFnU1AvWUwwYmluVlJ5amJvK0lw?=
 =?utf-8?B?TEpQMDcwcUd5dUkybjJ1YmpTTTRZTEdvMmZWUzhPc3Vyd1c2UVVHblBrc0NW?=
 =?utf-8?Q?BUQt0ABAyx00bZHJLcv02aDxR?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2dde4c0-688d-431b-9eb2-08dc73f02837
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2024 08:30:48.5194
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /mEg5qyln/pZBTWHQqqFncDTDlJhCpCSOdSDrbSEAxeDg8mp2oMXnsM0e7GOHCZAr2xpaURkLacotvAQSL0ifQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6606


On 5/14/2024 3:24 AM, Yuan, Perry wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
> 
>> -----Original Message-----
>> From: zhida312@outlook.com <zhida312@outlook.com>
>> Sent: Tuesday, May 14, 2024 2:43 PM
>> To: rafael@kernel.org; viresh.kumar@linaro.org
>> Cc: andypma <andypma@tencent.com>; Huang, Ray
>> <Ray.Huang@amd.com>; Shenoy, Gautham Ranjal
>> <gautham.shenoy@amd.com>; Limonciello, Mario
>> <Mario.Limonciello@amd.com>; Yuan, Perry <Perry.Yuan@amd.com>; linux-
>> pm@vger.kernel.org; linux-kernel@vger.kernel.org
>> Subject: [v2] cpufreq: amd-pstate: fix the memory to free after epp exist
>>
>> From: andypma <andypma.tencent.com>
>>
>> the cpudata memory from kzmalloc in epp init function is not free after epp
>> exist, so we should free it.
>>
>> Signed-off-by: andypma <andypma@tencent.com>
> 
> Looks like you need to fix the format of the `Signed-off-by` line in your commit, you need to ensure that it follows the correct format of including your full name and email address. Here's how you can fix it:
> 
> Signed-off-by: Your Full Name <your_email@example.com>
> 
> So maybe you want to change like this.
> Signed-off-by: Andy Pma <andypma@tencent.com>
> 
> Perry.
> 
>>
>> Changes since v1:
>>        check whether it is empty before releasing.
>>        set driver_data is NULL after free.
>> ---
>>   drivers/cpufreq/amd-pstate.c | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
>> index 6a342b0c0140..e100c5b6c9b2 100644
>> --- a/drivers/cpufreq/amd-pstate.c
>> +++ b/drivers/cpufreq/amd-pstate.c
>> @@ -1441,6 +1441,13 @@ static int amd_pstate_epp_cpu_init(struct
>> cpufreq_policy *policy)
>>
>>   static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy)  {
>> +     struct amd_cpudata *cpudata = policy->driver_data;
>> +
>> +     if(cpudata) {

You want a space after the if

But isn't it safe to call kfree(cpudata) even if cpudata was already NULL?

>> +             kfree(cpudata);
>> +             policy->driver_data = NULL;
>> +     }
>> +
>>        pr_debug("CPU %d exiting\n", policy->cpu);
>>        return 0;
>>   }
>> --
>> 2.33.0
>