Received-SPF: pass (google.com: domain of linux-kernel+bounces-178473-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Zhu Yanjun <zyjzyj2000@gmail.com>
Message-ID: <38a5ccc6-d0bc-41e0-99de-fe7902b1951f@linux.dev>
Date: Tue, 14 May 2024 10:53:05 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/6] rds: rdma: Add ability to force GFP_NOIO
To: =?UTF-8?Q?H=C3=A5kon_Bugge?= <haakon.bugge@oracle.com>,
 linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
 netdev@vger.kernel.org, rds-devel@oss.oracle.com
Cc: Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
 Saeed Mahameed <saeedm@nvidia.com>, Tariq Toukan <tariqt@nvidia.com>,
 "David S . Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 Paolo Abeni <pabeni@redhat.com>, Tejun Heo <tj@kernel.org>,
 Lai Jiangshan <jiangshanlai@gmail.com>,
 Allison Henderson <allison.henderson@oracle.com>,
 Manjunath Patil <manjunath.b.patil@oracle.com>,
 Mark Zhang <markzhang@nvidia.com>, Chuck Lever <chuck.lever@oracle.com>,
 Shiraz Saleem <shiraz.saleem@intel.com>, Yang Li <yang.lee@linux.alibaba.com>
References: <20240513125346.764076-1-haakon.bugge@oracle.com>
Content-Language: en-US
In-Reply-To: <20240513125346.764076-1-haakon.bugge@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 13.05.24 14:53, Håkon Bugge wrote:
> This series enables RDS and the RDMA stack to be used as a block I/O
> device. This to support a filesystem on top of a raw block device

This is to support a filesystem ... ?

> which uses RDS and the RDMA stack as the network transport layer.
> 
> Under intense memory pressure, we get memory reclaims. Assume the
> filesystem reclaims memory, goes to the raw block device, which calls
> into RDS, which calls the RDMA stack. Now, if regular GFP_KERNEL
> allocations in RDS or the RDMA stack require reclaims to be fulfilled,
> we end up in a circular dependency.
> 
> We break this circular dependency by:
> 
> 1. Force all allocations in RDS and the relevant RDMA stack to use
>     GFP_NOIO, by means of a parenthetic use of
>     memalloc_noio_{save,restore} on all relevant entry points.
> 
> 2. Make sure work-queues inherits current->flags
>     wrt. PF_MEMALLOC_{NOIO,NOFS}, such that work executed on the
>     work-queue inherits the same flag(s).
> 
> Håkon Bugge (6):
>    workqueue: Inherit NOIO and NOFS alloc flags
>    rds: Brute force GFP_NOIO
>    RDMA/cma: Brute force GFP_NOIO
>    RDMA/cm: Brute force GFP_NOIO
>    RDMA/mlx5: Brute force GFP_NOIO
>    net/mlx5: Brute force GFP_NOIO
> 
>   drivers/infiniband/core/cm.c                  | 15 ++++-
>   drivers/infiniband/core/cma.c                 | 20 ++++++-
>   drivers/infiniband/hw/mlx5/main.c             | 22 +++++--
>   .../net/ethernet/mellanox/mlx5/core/main.c    | 14 ++++-
>   include/linux/workqueue.h                     |  2 +
>   kernel/workqueue.c                            | 17 ++++++
>   net/rds/af_rds.c                              | 60 ++++++++++++++++++-
>   7 files changed, 138 insertions(+), 12 deletions(-)
> 
> --
> 2.39.3
>