Received-SPF: pass (google.com: domain of linux-kernel+bounces-178485-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Yang Yang <yang.yang@vivo.com>
To: Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Mikulas Patocka <mpatocka@redhat.com>,
	dm-devel@lists.linux.dev,
	linux-kernel@vger.kernel.org
Cc: Yang Yang <yang.yang@vivo.com>
Subject: [PATCH 5/5] dm linear: enable flush optimization function
Date: Tue, 14 May 2024 17:04:44 +0800
Message-Id: <20240514090445.2847-6-yang.yang@vivo.com>
In-Reply-To: <20240514090445.2847-1-yang.yang@vivo.com>
References: <20240514090445.2847-1-yang.yang@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Dn/AN0mKnR+6oun4WZDZUyNnTKuaPzMeqWM6FOMwWY1IBV/p9Dy1WGRLnkK4?=
 =?us-ascii?Q?gfmG35buEk6G14ZUFqyA42JYrIf+6E9BGJlJKjFiur/XWhckGc2TdQPCEOak?=
 =?us-ascii?Q?CgzIRd39drDYFOtG/htM+enn2tDYCZrJC1OASQ1zBPcaCBiBkLzN/0g1JUs5?=
 =?us-ascii?Q?9XbRuNXbGnw0cse5U4lDshZj1coSQHaC5ytZEJ3E2AJ70qFs+9uUTuHm/fp+?=
 =?us-ascii?Q?sgS2XItzEcH3CqPeqGDDmcVlQJEQfjWMjX+6HC/pLdJjasQzlFEi3GmejoQO?=
 =?us-ascii?Q?q5/gZLIYe9u/BsgmuYylN1jA9938SPGxL3WQUcxNJq5pvO5sjpd3yM8+l1nG?=
 =?us-ascii?Q?0J9WL1mNI+xJQrVLCWG9j+cJes4cnsLljB9GUYZ9yZJOfTKHmGOtUzPULEiF?=
 =?us-ascii?Q?ILvxuI7Z6DKVrVAgCI3HkHqhJSYw2UVnkPQQrG34KuUemyTSRAbDCKdJM5r0?=
 =?us-ascii?Q?yJhDgfUBNQtTrPHKKgKWEkV9MZGNZpv927nxgEEZCxZUkRT3drCopdpI32Gb?=
 =?us-ascii?Q?vXCQ+aFVLX89Mest9qymbHkDzSC5O8ScVD6snfqqaET8Hi+BE62tsGPwakkn?=
 =?us-ascii?Q?2JBttxu6dGno+oQ3hrGqw3baUYeNxe2NnAf7TGJmtpVSINKEQCjmsYLvYl3F?=
 =?us-ascii?Q?YU36F8UlBae6yuhQG3UdJMUqU9z0nGjxS5NE/EHAoOTwY8WtnBHCHcRcO5AL?=
 =?us-ascii?Q?dZsIqO1PBxfhamguVC+cG1V9kZerfIQZxRDxMkHsYPB8MkTTBztQRnAr0RaG?=
 =?us-ascii?Q?Q96zTo8qUuBz1vHCPl3dpYMVztqEETk64xHv1XfShDT5JsAoRSCfmRyjCm1C?=
 =?us-ascii?Q?3MzA+0gGgZaaoQyR75sUZ+0aJzwcPeBe4kiPGqj79rHivEQkd49D+M1UxYEq?=
 =?us-ascii?Q?oPLACWbf7hB6e6ZgVZxgx+zIybRNObdt2XIjd24xKdfqQJZax678ZMkqfMq8?=
 =?us-ascii?Q?yveAn9Yzm5wXjboLUu6xuGWuH+nEAJ+41uH1SIbog57Ifm34/pnD3da8Z98A?=
 =?us-ascii?Q?Wq3VhmUz9OMRXwCIuV3v6IC/V7i91qu/DrCe+6oCqJYVRxQU57ab6tgTZZkO?=
 =?us-ascii?Q?y/uc1j4LgXwPvXBzCHmhBOTe3uD7NWWRin3g4JFveXUZuKe9dTXe9g0JAEio?=
 =?us-ascii?Q?mG5ttEEmJrUExPn72I8MBfBs7ssWHNg8O8iit64YSlgBXUYj91SzlRd+rk/l?=
 =?us-ascii?Q?5mT7k0lF4vfyrGg469+dAfFK7oNlGpXG1qrp7eeaZALv0r9wFl7BQBsXT4uL?=
 =?us-ascii?Q?Z2S5yZelpleJoX1jKm9RDtDColIJIXhy2etCULxY/q3t3s+sRWDWSGnsO7vk?=
 =?us-ascii?Q?NTvprDHXoYgZazAo6MMISPsmywDtVfGa/ehbWxjjlo5bhQkYY07aeMk+4p9A?=
 =?us-ascii?Q?rWWF/9I447wIA93YWJntFa83e+QbkO63pAU3RXxU0jyaEwwJezb2OOGWBZzW?=
 =?us-ascii?Q?5Nn/jJ6jeMfcfWzGiKjW2M9zHY8/S5X4oLOsQUcaNCjuDgTGHPKtOgaYZkBW?=
 =?us-ascii?Q?DYtL4KbSpmyJbt8C06kkyf+Vs2LrOj1YVzTb5e/sqy7/ieRJbuE+CwyJ1qLQ?=
 =?us-ascii?Q?Ss6TjjzEaurZ1aFTxX/RiO+wPYR8ker6ajfqA+7I?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1761c51f-8dcc-4918-ec50-08dc73f513cc
X-MS-Exchange-CrossTenant-AuthSource: SEYPR06MB6398.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2024 09:06:01.7972
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w94iYCHefNR2n59gjE7vrXXZNA1JuKTJAAul1A71gTW3pATB2OtPz2zjQEMYNmGLj1P01DNfXytuwOXNjonROg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB6102

__send_empty_flush() sends empty flush bios to every target in the
dm_table. However, if the num_targets exceeds the number of block
devices in the dm_table's device list, it could lead to multiple
invocations of __send_duplicate_bios() for the same block device.
Typically, a single thread sending numerous empty flush bios to one
block device is redundant, as these bios are likely to be merged by the
flush state machine. In scenarios where num_targets significantly
outweighs the number of block devices, such behavior may result in a
noteworthy decrease in performance.

This issue can be reproduced using this command line:
  for i in {0..1023}; do
    echo $((8000*$i)) 8000 linear /dev/sda2 $((16384*$i))
  done | dmsetup create example

With this fix, a random write with fsync workload executed with the
following fio command:

  fio --group_reporting --name=benchmark --filename=/dev/mapper/example \
      --ioengine=sync --invalidate=1 --numjobs=16 --rw=randwrite \
      --blocksize=4k --size=2G --time_based --runtime=30 --fdatasync=1

results in an increase from 857 KB/s to 30.8 MB/s of the write
throughput (3580% increase).

Signed-off-by: Yang Yang <yang.yang@vivo.com>
---
 drivers/md/dm-linear.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/md/dm-linear.c b/drivers/md/dm-linear.c
index 2d3e186ca87e..3e1a33b4d289 100644
--- a/drivers/md/dm-linear.c
+++ b/drivers/md/dm-linear.c
@@ -62,6 +62,7 @@ static int linear_ctr(struct dm_target *ti, unsigned int argc, char **argv)
 	ti->num_discard_bios = 1;
 	ti->num_secure_erase_bios = 1;
 	ti->num_write_zeroes_bios = 1;
+	ti->flush_pass_around = 1;
 	ti->private = lc;
 	return 0;
 
-- 
2.34.1