Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762695AbYAaGTd (ORCPT ); Thu, 31 Jan 2008 01:19:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751787AbYAaGTZ (ORCPT ); Thu, 31 Jan 2008 01:19:25 -0500 Received: from gate.crashing.org ([63.228.1.57]:59009 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbYAaGTY (ORCPT ); Thu, 31 Jan 2008 01:19:24 -0500 Cc: , , Message-Id: From: Kumar Gala To: Zhang Wei In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v915) Subject: Re: [PATCH 4/6] Add multi mport support. Date: Thu, 31 Jan 2008 00:15:21 -0600 References: <1201689053956-git-send-email-wei.zhang@freescale.com> <12016890621727-git-send-email-wei.zhang@freescale.com> <120168907160-git-send-email-wei.zhang@freescale.com> <12016890773706-git-send-email-wei.zhang@freescale.com> X-Mailer: Apple Mail (2.915) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1353 Lines: 43 On Jan 30, 2008, at 11:57 PM, Zhang Wei wrote: > > >> -----Original Message----- >> From: Kumar Gala [mailto:galak@kernel.crashing.org] >> >> On Jan 30, 2008, at 4:30 AM, Zhang Wei wrote: >> >>> Change lots of static variable to mport private. And add >> mport to some >>> function declaration. >> >> Can you explain this patch further. Its not clear exactly from this >> commit message why we are doing this. >> >> - k > > Sorry about I have a little hurry about it. > > The original RapidIO driver suppose there is only one mpc85xx RIO > controller > in system. So, some data structures are defined as mpc85xx_rio global, > such as 'regs_win', 'dbell_ring', 'msg_tx_ring'. Now, I changed them > to > mport's private members. And you can define multi RIO OF-nodes in dts > file > for multi RapidIO controller in one processor, such as PCI/PCI-Ex host > controllers > in Freescale's silicon. And the mport operation function declaration > should be changed > to know which RapidIO controller is target. thanks, this makes a lot of sense and now reviewing the patch will make some sense to me :) - k -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/