Received-SPF: pass (google.com: domain of linux-kernel+bounces-178511-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <CAHx5RXBfazB62qpbGGK3_YjwCFbiJbEXrgo88V6qHFdTW1CdRQ@mail.gmail.com>
 <338daebd-b4af-4a0c-951a-ad7f86dc4646@gmail.com> <CAHx5RXAOKBGXRgC8pqEyY3MZGXxj0-vrwnqg_WZqKreYp18dAg@mail.gmail.com>
 <7efffaa0-6330-4b01-b3d2-63eb063cbbb0@gmail.com> <CAHx5RXD8qFmbEytrPcd40Pj0VRo7uOvZjucrMj6Xxqw73YyS1Q@mail.gmail.com>
 <212a9464-d52b-4730-95b9-5a0aebd38c91@gmail.com> <CAHx5RXCWW5M-eW5v65bAkQWZemsU2NTvDv3jA9_XKz=+YP56Qg@mail.gmail.com>
 <688e54ec-3b29-4e3b-a2c3-f2c83b9c97b7@lunn.ch> <CAHx5RXBFdzsgKXR94gdZd2b=uz8PJDg4OjLPJxKtsdhcjJq3Qw@mail.gmail.com>
 <e307a237-68e3-40c9-be31-4fe3d560ada2@lunn.ch> <CAHx5RXCF0=Soz_k88RGvJFGrajaxn=mVnqpb99GAQ=b7XOcWiw@mail.gmail.com>
 <732d8bb2-1d4f-4958-b130-0bd15a407271@gmail.com>
In-Reply-To: <732d8bb2-1d4f-4958-b130-0bd15a407271@gmail.com>
From: Stephen Langstaff <stephenlangstaff1@gmail.com>
Date: Tue, 14 May 2024 10:28:55 +0100
Message-ID: <CAHx5RXDaweFTF_Qt0GdBH4nBeMqwL4VVto7xzHBvFgFL5n=Ebg@mail.gmail.com>
Subject: Re: drivers/net/dsa/dsa_loop_bdinfo.c build problems
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, linux-kernel@vger.kernel.org, OlteanV@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 13, 2024 at 8:05=E2=80=AFPM Florian Fainelli <f.fainelli@gmail.=
com> wrote:
> Attached is a configuration that I use on a x86-64 VM for testing that
> is started with:

That's kind of what I expect to be happening on my target, but it's not.

I notice that your configuration does not define CONFIG_FIXED_PHY as
either a module or built-in - could that explain both the fact that my
dsa_loop_bdinfo.c does not get compiled when using the default
Makefiles, and that if I force compilation to a module it does not
appear to create the expected lanX@eth0 interfaces?

I have added some printk debug lines to the dsa_loop_init and
dsa_loop_drv_probe functions, and only see the one from the init
function, which makes me suspect that something is stopping the probe
from happening - I assume this should happen when the dsa_loop_bdinfo
module is inserted?

root@machine:~/dsa_test# ls
dsa_loop.ko  dsa_loop_bdinfo.ko

root@machine:~/dsa_test# modprobe dsa_core
root@machine:~/dsa_test#

root@machine:~/dsa_test# insmod dsa_loop_bdinfo.ko
[   51.742367] dsa_loop_bdinfo_init

root@machine:~/dsa_test# insmod dsa_loop.ko
[   58.485104] dsa_loop_init

root@machine:~/dsa_test# ip link
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN
mode DEFAULT group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP
mode DEFAULT group default qlen 1000
    link/ether xx:xx:xx:xx:xx:xx brd ff:ff:ff:ff:ff:ff
3: eth1: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc mq state
DOWN mode DEFAULT group default qlen 1000
    link/ether xx:xx:xx:xx:xx:xx brd ff:ff:ff:ff:ff:ff
4: can0: <NOARP,ECHO> mtu 16 qdisc noop state DOWN mode DEFAULT group
default qlen 10
    link/can