Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761829AbYAaGb1 (ORCPT ); Thu, 31 Jan 2008 01:31:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753137AbYAaGbQ (ORCPT ); Thu, 31 Jan 2008 01:31:16 -0500 Received: from az33egw01.freescale.net ([192.88.158.102]:53360 "EHLO az33egw01.freescale.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752222AbYAaGbQ convert rfc822-to-8bit (ORCPT ); Thu, 31 Jan 2008 01:31:16 -0500 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Subject: RE: [PATCH 4/6] Add multi mport support. Date: Thu, 31 Jan 2008 14:30:13 +0800 Message-ID: In-Reply-To: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH 4/6] Add multi mport support. Thread-Index: Achj0bvZ9xBCNWjNSqmmDAYYp+M7mAAADyDg References: <1201689053956-git-send-email-wei.zhang@freescale.com> <12016890621727-git-send-email-wei.zhang@freescale.com> <120168907160-git-send-email-wei.zhang@freescale.com> <12016890773706-git-send-email-wei.zhang@freescale.com> From: "Zhang Wei" To: "Kumar Gala" Cc: , Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1889 Lines: 64 > -----Original Message----- > From: Kumar Gala [mailto:galak@kernel.crashing.org] > > On Jan 31, 2008, at 12:15 AM, Kumar Gala wrote: > > > > > On Jan 30, 2008, at 11:57 PM, Zhang Wei wrote: > > > >> > >> > >>> -----Original Message----- > >>> From: Kumar Gala [mailto:galak@kernel.crashing.org] > >>> > >>> On Jan 30, 2008, at 4:30 AM, Zhang Wei wrote: > >>> > >>>> Change lots of static variable to mport private. And add > >>> mport to some > >>>> function declaration. > >>> > >>> Can you explain this patch further. Its not clear > exactly from this > >>> commit message why we are doing this. > >>> > >>> - k > >> > >> Sorry about I have a little hurry about it. > >> > >> The original RapidIO driver suppose there is only one mpc85xx RIO > >> controller > >> in system. So, some data structures are defined as mpc85xx_rio > >> global, > >> such as 'regs_win', 'dbell_ring', 'msg_tx_ring'. Now, I > changed them > >> to > >> mport's private members. And you can define multi RIO > OF-nodes in dts > >> file > >> for multi RapidIO controller in one processor, such as PCI/PCI-Ex > >> host > >> controllers > >> in Freescale's silicon. And the mport operation function > declaration > >> should be changed > >> to know which RapidIO controller is target. > > > > thanks, this makes a lot of sense and now reviewing the patch will > > make some sense to me :) > > when we have multiple ports are the device IDs on the ports intended > to be unique only to a port or unique across all ports? > I consider each RIO controller will has its own network, the device IDs should be unique only in its port network. Cheers! Wei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/