Received-SPF: pass (google.com: domain of linux-kernel+bounces-178525-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 14 May 2024 10:46:29 +0100
From: Mark Brown <broonie@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Felix Kaechele <felix@kaechele.ca>, Job Noorman <job@noorman.info>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, linux-input@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] input: himax_hx83112b: implement MCU register
 reading
Message-ID: <44570cd2-9540-47f8-a409-26220b0812fb@sirena.org.uk>
References: <20240511121245.109644-1-felix@kaechele.ca>
 <20240511121245.109644-4-felix@kaechele.ca>
 <ZkKb5_SRNwG1pRou@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="qIPUr/BZPS1Qo9uv"
Content-Disposition: inline
In-Reply-To: <ZkKb5_SRNwG1pRou@google.com>


--qIPUr/BZPS1Qo9uv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, May 13, 2024 at 04:01:59PM -0700, Dmitry Torokhov wrote:
> On Sat, May 11, 2024 at 08:12:24AM -0400, Felix Kaechele wrote:
> > Implement reading from the MCU in a more universal fashion. This allows
> > properly handling reads of more than 4 bytes using the AHB FIFO
> > implemented in the chip.

> Mark, do we have anything in regmap to support this better or having a
> wrapper is the best solution here?

No, I've not seen something that explicitly requires toggling a burst
mode on and off to do a bulk operation.  Off the top of my head I'd
suggest just always leaving the burst mode enabled but I assume there's
some downside to doing that.  We could add something but I'm not sure if
it's worth it without having seen any other devices with the same need.

--qIPUr/BZPS1Qo9uv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZDMvUACgkQJNaLcl1U
h9CCogf/eDQCdhAa8JoQL0uKEvCPgYIHa+U0n7N0kt6REwUn7vSgK8Wiy9Z4wfyE
FqwL1PXqrv3pHNi9xn8/L+QhpAM2s2TEnVcAp7O4M2m5AlKIJPfzdg2hVBNCkBhu
1L/idQLya58JGKcrQn4/ukNdf37o9ZE9FyY0s1h8/SBmLQEGUQGVOuCbgQR4QXAU
/axeuus9qA+pbqmqhdV0vVJPrfwkLZxmOlwkTIbx6wbAodYY3KYV3z0z7onG7Hyo
wcZys6QN37X7UnZWwyMF57YMXDxVcYv4FoRASc1ILRwMv6ooBHlEA7Pw5MMHm1tr
m8lhLOwy3MPSOaiuufcJdRHR3py7fw==
=0n8h
-----END PGP SIGNATURE-----

--qIPUr/BZPS1Qo9uv--