Received-SPF: pass (google.com: domain of linux-kernel+bounces-178526-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <f07e6b92-e133-4515-bfc9-24b24ad178d1@oracle.com>
Date: Tue, 14 May 2024 15:16:39 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] media: imx-pxp: fix ERR_PTR dereference in pxp_probe()
To: Philipp Zabel <p.zabel@pengutronix.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        Michael Tretter <m.tretter@pengutronix.de>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        linux-media@vger.kernel.org, imx@lists.linux.dev,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org,
        error27@gmail.com
References: <20240514094458.3463408-1-harshit.m.mogalapalli@oracle.com>
Content-Language: en-US
From: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
In-Reply-To: <20240514094458.3463408-1-harshit.m.mogalapalli@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?WkY1T2FrditzVXl3eGJsZ1YzaElSZloyZGV1Z3FrVDFqOXJVUDRjU2JGV1hp?=
 =?utf-8?B?OGpLaWplNitFU2VSTWpJSU9XaWRrWVQwMzl4eElXOXpyOGNxUDV5RG84KzBn?=
 =?utf-8?B?WHZUUEtUcm9jYm9vd2dnVnBFYWkyYWtEcHRiT3RacjhubG83QldUMFRpdWZF?=
 =?utf-8?B?TFNzeDJwMDZzckR1Qkg0cjhsSktXSzhPTnpvYWwzeGRLMUNmczRNcVdwVFJD?=
 =?utf-8?B?akhxYlFVNHFpbCtvRUlvYktES1pkRTVrUUFhNWVzUlFSOU0rb1hUSWlzU2F6?=
 =?utf-8?B?ZlhWUWorUmdEZUpSNU9KblBrNEplTmpQQkVKRlp4cmlZZmlEeTdtd25RYmpD?=
 =?utf-8?B?dUk3Qmo5eDY0dW45cS9OMk9PU2E5bDl3MTJkTU4wZ2FXbXVLbktSZkNZVSsr?=
 =?utf-8?B?a2RnU1FjYzBIOFR3QksycHYwVTRFSlFpM3F2eFhlbERRaC9xZTFzcGRzbUdj?=
 =?utf-8?B?eGk3Y3hUK1VqL1ZCOEVBMk1hR0haQm9HZC9QTndEcXVPU0RvaTNuYW1menNr?=
 =?utf-8?B?aU1tYUs3WEN1TmMrWFpweldVcHdyU0t1cGQ2SWMzbmpRYkRBeUlBYVNUVTZ2?=
 =?utf-8?B?K3FNdkhXZlBkQU1vYTA3Z2Q4MFEwY01jUGF6RkQ1dUJGSzhuOVBnaUVhcGx0?=
 =?utf-8?B?TzBoRnRIcGE0Tmh3Wlo5ODlOSXR0SHVncWVZenUxdkdxRmtBV0VaNnpzZ3lT?=
 =?utf-8?B?NUV2Q1VNUnllckpieGU5QnhWU0kzVHYxMFdIYVVqdVE2L1JsTE9SQUV2S3BL?=
 =?utf-8?B?ZjcvVitxZDNlWUlQRy9JZHBQODJJcEx4MHhiMWJrN0ZtYkZYeTNmTmhURTVM?=
 =?utf-8?B?a0FMRGNzZkp4MnRHUTFENEk1amNhRGpJc2lvcEFHVjh3YTZvellLVTdLZDV4?=
 =?utf-8?B?cnNuSGs3RGFjemRyZktCbXBJMzRxZFptSk5kWXpPSkdKZTc0dmZMTTFPNUVK?=
 =?utf-8?B?THRQRXMrajFsdFpUaTBVbkF2MWkwOGVpY21xbjJra3RFTXptdWZqVHFqaGF3?=
 =?utf-8?B?K3gyOTBBamtxSnFFR2pQdjY3L0E3UHpkd3IwUFhReDN5U0xpSHB5bnFkaFdv?=
 =?utf-8?B?Y3hKUXVLRUVoMEtBYjY1UkRHQlRlOFFWb1pqQnVrZyt6NW9Hc3V6ZkVST0tz?=
 =?utf-8?B?ZUVUd2praUNMWGNLMDhxSWJ6dDRGRmFMVlhPSVhIY0o4VExYUlJ4KzBuMTZK?=
 =?utf-8?B?NVp2bXFUSENqS1hwRlRBZ0Zpb0prRDVubWhWK2lJQ05INnFtUUd5c29zNmxC?=
 =?utf-8?B?RnMwa2IvZW5SMTVqUUUzK20xU0ljKy9TQUwzZUV5cExwQTg4eXlXWlllV09j?=
 =?utf-8?B?UXNwN1p4WTg1WXlNdU1iTkIwVlB4WDBGemdGTkhrTFlobktZSDV2dkxvMFZi?=
 =?utf-8?B?M1dpYVhORnIyelRDRU1qYU9BdnJIZXVFTGZjZ0JkVmppSUd4Ly95bXpjZCs5?=
 =?utf-8?B?eVdYR0NKVlpXdkd2SkZaSmw4YWJOb2FaMzk3aVpMUmwwNlJpMWRSY1RLZXVP?=
 =?utf-8?B?VFduWXdWWTlwb2NueHEwNjlMT3VYUDJVWGViNGJFWVpEbm0rYzIvQ2FHTUQw?=
 =?utf-8?B?YjlUTTN4TEx3Q0dtL3E1VmJ3T1BYZ1hwT0V6NUcwVEVDbWt1T3FCc21zSzNF?=
 =?utf-8?B?UE1NcFZRK0ZkSEd4cWp4a0Z4czkwTjIyaHl3cGh5aG9aNEgyYjZwZ0k5SlE1?=
 =?utf-8?B?SU9MejZUMVNKMmgvenFBbjNOMEc1Z3ZieFdvNDNDOEpDbVRyU3I5eXVxcHdW?=
 =?utf-8?B?WEtPWnNpYys5NnIyL3hJRFJQMkVMVkxWQjlMM2pLOUZsUWxYVmhrNnVJbnFX?=
 =?utf-8?B?STNtY2FRSHZUTHY4RFpUc2EwM2FqTWtNeFgrVlZpVlQrZ2d2RGVJSE9GbWZu?=
 =?utf-8?B?QnFxa3J1bDR5UFh0OWdSd092aXIrL2poUHM5YjhueC9GeUkzZE1uc2Z0NEFa?=
 =?utf-8?B?TlR4MERvZE9JbjBDaW1Ia3JPT1RXa1FpTWVYSU1wSEZ3SFVkUXd4dllXbHJE?=
 =?utf-8?B?ZDRVN3BDQk5wQjFsZXZ0eW1VdDFOZjNFNzlpYnFPZmZYbzdYSmZuWFdURkdh?=
 =?utf-8?B?cHdqYnVpSEMwV2VrUkUxSmIwMm4yUStPN0VRdXExaDJuR2pzanhFMkRRbm5B?=
 =?utf-8?B?bHRFaW1IZnhpNVRaRVZSb2lCZXNtbzZnSmUrZG0wUXpjQ051Z1gvUm0xWGt3?=
 =?utf-8?Q?vGYjOfpUrcgZuW6QTXNG79c=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	rdro3pOmh0P9n3tkbOzCKSp1qAYLrGeRAPVub642U9pV66NwN/qs4k7Ol+rRF+FRhbLZMsMP2rwmbNr/zCGmW+P6bSYYxHGEXtpc+NRv3lsxhFX2Z6+pyDkmhe4FHKOigsiX8YRc8ZpWubYWUBUWVyRd5V824oa0/SNXbLj+Bc90GwuL/fHzLY7TTTZD/eZMxWawAkOd8kA1YiS2N35XryixR/oy7rvwTALvw7vUZJ7RtNQsHx21k0QRmL8NUWOZ2Pyw+2WT7m3zxiqkvIi4c5clAXDEe7lCtUCPUCmQPAh9v6VTJT7xaNwnOAXZIi9ER6TSZseqg/tCRvxqBLFaT4a81THulAP2GRmmWirKVHA1vmSvcNhO8mOU2nzIPv3W1dq1TeXBaSTG/Tacoiu+4BkhXsk2hcazOys5PdWsTrR8chXF/81GGj76b41mSvn/ap2iKEaTy1qopA79X2nAToPBbbaqi8YiAAG4VfaHwl0I0O07vPhqPHpSa8bdwE9B12Ldo1mCXX7/OQIKkaBElqe//JhsoGbujts0/Qbtf/OkQBYIqo4d3PkGbDwDe/+bqj1FrQWkZQlAxE+eDKdluH9Nd2JUYblB9Z9Jc0VnAh0=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f0d1c96-5907-4ffa-8d45-08dc73fac8d1
X-MS-Exchange-CrossTenant-AuthSource: PH8PR10MB6290.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2024 09:46:53.0758
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Uqhk6Dy9aKlYBz8WpkRDyb3e/H0FyVw2YGCnjuTj2rFARALCuMDREl4X/1o417RuWim7DARyEF++tk+T6dsWeQsUL/rnCke7KnbAihl1FyVqwsnzykfMq6f5Pw3wsvOs
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4799
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-14_04,2024-05-10_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 mlxscore=0
 spamscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405140068
X-Proofpoint-ORIG-GUID: rBTOZiJModipkoVUVi8VLUKTn8nHIIqw
X-Proofpoint-GUID: rBTOZiJModipkoVUVi8VLUKTn8nHIIqw

Hi,
On 14/05/24 15:14, Harshit Mogalapalli wrote:
> devm_regmap_init_mmio() can fail, add a check and bail out in case of
> error.
> 

Please ignore this patch, I will send a V2.(v1->v2, I have to remove %d 
in error message)

Thanks,
Harshit
> Fixes: 4e5bd3fdbeb3 ("media: imx-pxp: convert to regmap")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
>   drivers/media/platform/nxp/imx-pxp.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/media/platform/nxp/imx-pxp.c b/drivers/media/platform/nxp/imx-pxp.c
> index e62dc5c1a4ae..58c10156c7a4 100644
> --- a/drivers/media/platform/nxp/imx-pxp.c
> +++ b/drivers/media/platform/nxp/imx-pxp.c
> @@ -1805,6 +1805,9 @@ static int pxp_probe(struct platform_device *pdev)
>   		return PTR_ERR(mmio);
>   	dev->regmap = devm_regmap_init_mmio(&pdev->dev, mmio,
>   					    &pxp_regmap_config);
> +	if (IS_ERR(dev->regmap))
> +		return dev_err_probe(&pdev->dev, PTR_ERR(dev->regmap),
> +				     "Failed to init regmap: %d\n");
>   
>   	irq = platform_get_irq(pdev, 0);
>   	if (irq < 0)