Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp2595056lqo; Tue, 14 May 2024 03:45:49 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVHyEbxX1xR+s1rQ3Bm3Vu6fLPwzsNqGCvsmIY5Z++Rg1dX9qM5HSycqxgePevkbGo719NYqLmZCaLH0peJrMY2sdfCu7BQGU24OwP/LA== X-Google-Smtp-Source: AGHT+IF6L6B06BE0NjEVUaRyQM7cvB2koFUL1x1tAl1te7vWUKic4noqonMKvuC/J7gOhyJAPINV X-Received: by 2002:a05:6a20:8428:b0:1a9:d9bb:acdc with SMTP id adf61e73a8af0-1afde10df02mr14696140637.28.1715683549009; Tue, 14 May 2024 03:45:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715683548; cv=pass; d=google.com; s=arc-20160816; b=Ff3XBHOmZafmih2g8abSKwVfNQomU7LwdRELc0lzGgWfZsNKLNH73FeF32Ep1d4478 /IzbFeEqAbEJ0GgbhKq1TN5LLKsG26Wy+xfbBoo449WeQNLVvHxA5Ob89ZQJ1UfVW1CF OztxfA0tUKBUk22X3cxSHGUf9yaB6pAajpv7cm/P+1oMi+OAzR/1axbDUxM3LQGWxw62 Vb9cbjVlTEvr6n3UndV+aNeifvwIDlv2PbL8niC4wUFkG9amTU2zugIl8w052+rk+spm bkRiuYPlk670gBRxhZdopUSUHzWmzAVwzK2qMqUmBQMK+2db9C1ubFB1v43s80xCud/s iMWA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=7Q8W3uNHR/1UMFJoTu/IzAoP9c6BKTCrF+F0qrD+03A=; fh=7fuDhGRSduOTD3X2atIBC+TDO7tMv7hl9s4mBJl1Sug=; b=EnkX43fgKdi2USuQt9c0gKwVH+cE/PulSPaDBW5b2KLdjHMxb/D4YZmGQwN4wNJrmq c1haFnyedrls8l3olvyP2+dQuYAyBEsAE3dTQCFN0ny+XP+ZNAqUm0gGTg11To0Ssq4K fCNCHED7/WOyGVkVcjxDwDlhx+034SVVwi6X3grGmPCrHoePN/ExaA1o/PEpwcj6lwIU iUANkfJHH2IHN/R8VzCrHlGQoBn827yI4XHpnTMHV5v50Pt3M8HKaroi7ynxglsb6jX9 DHcwYmPnyGa13862jVUKMv8+KvmUcUzrfVRqedF36MmvQ3MCILo8NqEcaxUyAd9afpKs igNw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=sLrLZOA2; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-178550-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-178550-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 41be03b00d2f7-634103f724esi10936781a12.377.2024.05.14.03.45.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 03:45:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-178550-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=sLrLZOA2; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-178550-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-178550-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id DC644B20F3D for ; Tue, 14 May 2024 10:45:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7601013F42D; Tue, 14 May 2024 10:14:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="sLrLZOA2" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEB296BFA8; Tue, 14 May 2024 10:14:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715681670; cv=none; b=OhTpKZbm7xCdmvl8SzwlcyegzMK1JB+/XxD20DbBJcjF9sW7+I6QB7xW1TFzb7I5qrNqo6T5vMV3HVN9Pog64ZTZyRVR4fao5aB2TxFuQFt/c0fGpTC2NaQURP76z7sifLqcjHf4MR7ESj4KL8c1cndIPrJ/wQm0DioIlpalC4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715681670; c=relaxed/simple; bh=AJTZYpaGAZvZ9qTcyVYkjf6UB4DVz5QNTtQh4NrqSHk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bikoC3MrnCBmifg8bBmL483PiLBCAlySlPcBpAEF/4GDaPt4I310DqZIlhO0wBkw/Kubti7nQHWgxiAar8JtNNg7d4Sr+50Ua62DhLF+H6d2xf35lCrWzM3Fe7lh7xa91Ewrpq8QNmMbeZGYrI3Yvvai4/qyX6tIRHh/jWW+fXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=sLrLZOA2; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Received: from [10.91.1.31] (unknown [149.14.240.163]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 159FA22A; Tue, 14 May 2024 12:14:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1715681654; bh=AJTZYpaGAZvZ9qTcyVYkjf6UB4DVz5QNTtQh4NrqSHk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sLrLZOA2CO694RBNyFaS7aT+ihrHBBoGdpMQMaByNMgcWlfR1s2e4rONXUFkFlYSN 2iaAbH9rTbihLIk0fQY+qz/UwTjyb/pqNhEb1AUSJY3glGd3dl6WAX0h4X35CSbxQ+ 9Xa6AomL8g0r9MgmZKVT8vjG00ich9niDcwDQ6JA= Message-ID: <3ba30852-cb50-497e-8968-a29d0b9a1986@ideasonboard.com> Date: Tue, 14 May 2024 11:14:18 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] media: ipu-bridge: fix error code in ipu_bridge_init() To: Andy Shevchenko , Dan Carpenter Cc: Bingbu Cao , Mauro Carvalho Chehab , Sakari Ailus , Hans de Goede , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: Content-Language: en-US From: Dan Scally Autocrypt: addr=dan.scally@ideasonboard.com; keydata= xsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW B31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove eIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq MHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX sUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU RWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1 NTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf vzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl 1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33 u4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5 IDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe kiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2 EAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg cEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm w/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi HSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7 c0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ nhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh AiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6 9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y ejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj xjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x xHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC PJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16 tPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t 8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp hyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT +49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj JwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX xGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K aL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL a/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT BQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM Res4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp vjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC FHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR du90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy xBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901 D+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM yMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt 9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1 u1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello On 10/05/2024 16:55, Andy Shevchenko wrote: > On Fri, May 10, 2024 at 06:43:31PM +0300, Dan Carpenter wrote: >> Return -EINVAL if "bridge->n_sensors == 0". Don't return success. > LGTM, but I leave the main Q "Is it really the error case?" to the maintainers. > I would imagine the use case where either from the following may happen: > 1) the sensors are all new and not listed as supported; > 2) there no sensors connected for real. > > In both cases I don't see this as a critical error that we can't enumerate > the bridge itself. > I have no strong feelings on this really. The CIO2 driver, before the bridge was a thing, didn't treat a lack of connected endpoints as an error case and still completed probe if the cio2_parse_firmware() function doesn't find any connected endpoints...but perhaps it should have behaved this way all along. Is there value in having the cio2 device probed, but useless? I can't think of any at the moment. The patch contents themselves look good to me.