Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp2598539lqo; Tue, 14 May 2024 03:55:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXi6is2iU+aio0LRMw8ALN64NPu6CYqa/s3klyZz0WriOro36l7HYjGhxdFRjp5oZcezLg3Iq7C+sY3CVpGmxqh+iV3LyYvPO23XiZHOA== X-Google-Smtp-Source: AGHT+IFOyPVRJdEoW7WT8rWhc4cCm/xq8VurKAiBLKcjet4iql8Xw2FwLvMluJRuVokJp6LEVpLk X-Received: by 2002:a05:622a:1808:b0:43a:ca31:8617 with SMTP id d75a77b69052e-43dfdb47b9bmr140563771cf.44.1715684152095; Tue, 14 May 2024 03:55:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715684152; cv=pass; d=google.com; s=arc-20160816; b=DhCh+Y6Hi/rw7aWAjn7XNKwN5rt8W0MpbEAAip3tfJSwkHMgZfdxPmnYuNxSks6BZh VOt+BxVU+jWX/imPQsoq/zkhfVFdPICTQS+E2php8a/DjiCZ58cSS42NP0VdLipwi1gs y1loMXvdvYW19F5YJzPZeg34CUpfCO1mhwpVfOkzjFeYy1ctVQWh9FcTUvTUDFlnimRS UvbV9cvo1PsKxOSh5aV7t97FjAW+AnM+hOb9gHC2NEBdCAkLgJdzwEj8YMLG4Anre9gM n6IWWlRMLyMMwP0aq/WLWFIqU5Vy6crlu6NQvfYqTyx4qxzTSV+ylNQltvGONE/BfRi6 WtWg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=rFhXB/PtNTcsLDrz8x1//Z6rnMNQHHu690THqM/SCs0=; fh=U6CGyhe0nAc68QPSdw/7pBff6XxSx5Ch7bP8crz+iAM=; b=GknZxWcCq+RKGR12a2MkVXX0LsavBQ//cRYVYh7zOP2GfdbMCVNP5gSO9bAq0aBw92 guAatzrPwfvS/nkW5E/iREP89iKVQc9ADzYJNcXXlWWuk+22m3ywmAGI6bJF1Z0qelqq 3n0gww41MZJvKp6sqjfEEmGMpzyTKrx1PjIU0TvbXKD0ucMkEmF5rEO9NJ8FrH4xvRnz Pg5QFSLLmL2yzwaqbTg1Z3+swmol12QaYpcZs/Rx/eRuIhsnIAoaELIyTjUuy80JBQAB 8OOGn+AiU2BVjjw975g5zcGFV6uE7JOWWlIgfEGhOJKxK0XLd89dfUNG2LJ3NFqTGWm2 JWmw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=pengutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-178558-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-178558-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d75a77b69052e-43e1594978dsi48057041cf.377.2024.05.14.03.55.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 03:55:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-178558-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=pengutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-178558-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-178558-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CE9681C21403 for ; Tue, 14 May 2024 10:55:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 87BF41353F5; Tue, 14 May 2024 10:34:12 +0000 (UTC) Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14F9C134CFE for ; Tue, 14 May 2024 10:34:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715682852; cv=none; b=jBa389sZLpMWa2JmwepQ4DrGrUkG6EecIf0igljWLQCzAQmRHj+zqCmJJ/diFJp92T6q7YrnMW5AQ9/bD/HSJwx3vbDM35/Oty+6f5iM/oHZjI6OXOhnrRlBv628p2zIhpgXJ9HgEDdKBQvOksbBh9KbbC81cIqymzZ4yqZuvcQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715682852; c=relaxed/simple; bh=aRk6NvPZjBiEJiRpLJXdgQJsFiOoBHTdq0kSIFpu1og=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=D/XwNpYqAgR0R23Gm3zQxOvJ1eZ5/r/onzUvUr4buhw3mi4B1GSM+hZwLBCj+8CiqVvFv07avAahiybqFOZXMLCynPcd/JBcaFcqJXDcrqU3AOJeBlAvbWTIsn5pe4X549oInQni6Sraq4eUR9wRbu8EGhhG0yY9jXY6r38Lys0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s6pTv-0006iz-Tn; Tue, 14 May 2024 12:34:03 +0200 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s6pTv-001KzM-C5; Tue, 14 May 2024 12:34:03 +0200 Received: from localhost ([::1] helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1s6pTv-003QYu-0p; Tue, 14 May 2024 12:34:03 +0200 From: Sascha Hauer To: linux-mtd@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Miquel Raynal , Richard Weinberger , Sascha Hauer Subject: [PATCH] mtd: rawnand: make rawnand_check_data_only_read_support() work Date: Tue, 14 May 2024 12:33:55 +0200 Message-Id: <20240514103355.817056-1-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: s.hauer@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org rawnand_check_data_only_read_support() calls nand_read_data_op() with a NULL pointer as buffer which will immediately return an error. Allow a NULL buffer pointer when check_only is requested. This should be safe to do as nand_read_data_op() has no business in touching the buffer in check_only mode. Fixes: 9f820fc0651c ("mtd: rawnand: Check the data only read pattern only once") Signed-off-by: Sascha Hauer --- drivers/mtd/nand/raw/nand_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c index d7dbbd469b892..a5e7d8deafbbe 100644 --- a/drivers/mtd/nand/raw/nand_base.c +++ b/drivers/mtd/nand/raw/nand_base.c @@ -2173,7 +2173,7 @@ EXPORT_SYMBOL_GPL(nand_reset_op); int nand_read_data_op(struct nand_chip *chip, void *buf, unsigned int len, bool force_8bit, bool check_only) { - if (!len || !buf) + if (!len || (!buf && !check_only)) return -EINVAL; if (nand_has_exec_op(chip)) { -- 2.39.2