Received-SPF: pass (google.com: domain of linux-kernel+bounces-178559-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 14 May 2024 11:34:29 +0100
From: Mark Brown <broonie@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Alina Yu <alina_yu@richtek.com>, lgirdwood@gmail.com,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, johnny_lai@richtek.com,
	cy_huang@richtek.com
Subject: Re: [PATCH v3 6/6] regulator: dt-bindings: rtq2208: Add property to
 get ldo of RTQ2208 is adjustable or not
Message-ID: <d97752ed-4032-4681-b28f-17f149fdc3d4@sirena.org.uk>
References: <cover.1715340537.git.alina_yu@richtek.com>
 <6a3a90d9aa2022dfb92e124e417f3e72c2f28b0b.1715340537.git.alina_yu@richtek.com>
 <20240513-tissue-repave-13d2e3bf88fd@spud>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="2yJ6nVJZYiZJOPrs"
Content-Disposition: inline
In-Reply-To: <20240513-tissue-repave-13d2e3bf88fd@spud>


--2yJ6nVJZYiZJOPrs
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, May 13, 2024 at 05:22:54PM +0100, Conor Dooley wrote:
> On Fri, May 10, 2024 at 08:06:25PM +0800, Alina Yu wrote:

> > +            richtek,fixed-microvolt = <1200000>;
> >              regulator-min-microvolt = <1200000>;
> >              regulator-max-microvolt = <1200000>;

> I'm dumb and this example seemed odd to me. Can you explain to me why
> it is not sufficient to set min-microvolt == max-microvolt to achieve
> the same thing?

This is for a special mode where the voltage being configured is out of
the range usually supported by the regulator, requiring a hardware
design change to achieve.  The separate property is because otherwise we
can't distinguish the case where the mode is in use from the case where
the constraints are nonsense, and we need to handle setting a fixed
voltage on a configurable regulator differently to there being a
hardware fixed voltage on a normally configurable regulator.

--2yJ6nVJZYiZJOPrs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZDPjQACgkQJNaLcl1U
h9A6rgf+IUYfQW5892x2qJJ3Racl8hbGhtW1RaVRQl36Zs1rAHvq24wQQlhnHMA/
XuN5J4H03dIl3ENmjY/jXMXxxAUjtScr+rIbGzlQDBjYwu5/fSlouEud8vs+lMcd
+j3lF0PYPCsehqOirejb19Z1uecY9JUlfvdD/exQahL5UNY4koOBNhsi9TTgrIg/
skOUh03sqrz6yfysvT+zqNb0+FYz6XiQY8tuGk37Nxmul9kt01ZiR5O021B4PGSH
s9FTFlIgikPJbYbq89trox6dH07Jxa/rW45iH8HLCUXMLyLdP+7WQRpKvoqqGqCS
KPuoi272ta1W2GQTDdZiKlc6QHdowQ==
=i+rQ
-----END PGP SIGNATURE-----

--2yJ6nVJZYiZJOPrs--