Received-SPF: pass (google.com: domain of linux-kernel+bounces-178588-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 14 May 2024 13:11:22 +0200
From: Andrea Parri <parri.andrea@gmail.com>
To: Puranjay Mohan <puranjay@kernel.org>
Cc: Alan Stern <stern@rowland.harvard.edu>, Will Deacon <will@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	David Howells <dhowells@redhat.com>,
	Jade Alglave <j.alglave@ucl.ac.uk>,
	Luc Maranget <luc.maranget@inria.fr>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Akira Yokosawa <akiyks@gmail.com>,
	Daniel Lustig <dlustig@nvidia.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	puranjay12@gmail.com
Subject: Re: [PATCH] tools/memory-model: Add atomic_andnot() with its variants
Message-ID: <ZkNG2uZEiF1S6M7z@andrea>
References: <20240514094633.48067-1-puranjay@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240514094633.48067-1-puranjay@kernel.org>

> C andnot
> 
> {
> atomic_t u = ATOMIC_INIT(7);
> }
> 
> P0(atomic_t *u)
> {
> 
>         r0 = atomic_fetch_andnot(3, u);
>         r1 = READ_ONCE(*u);
> }
> 
> exists (0:r0=7 /\ 0:r1=4)

Fair enough for the changelog.  If/when submitting proper tests, please
check their format using klitmus7 (besides herd7); say,

  $ mkdir mymodule
  $ klitmus7 -o mymodule <.litmus file>
  $ cd mymodule ; make
  $ sudo sh run.sh

Documentation/litmus-tests/ provides some examples litmus tests.


> Signed-off-by: Puranjay Mohan <puranjay@kernel.org>

Acked-by: Andrea Parri <parri.andrea@gmail.com>

  Andrea