Received-SPF: pass (google.com: domain of linux-kernel+bounces-178590-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 14 May 2024 19:14:58 +0800
From: Chen Yu <yu.c.chen@intel.com>
To: Swapnil Sapkal <swapnil.sapkal@amd.com>
CC: <linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
	<peterz@infradead.org>, <torvalds@linux-foundation.org>,
	<juri.lelli@redhat.com>, <dietmar.eggemann@arm.com>, <rostedt@goodmis.org>,
	<mgorman@suse.de>, <bristot@redhat.com>, <vschneid@redhat.com>,
	<vincent.guittot@linaro.org>, <gautham.shenoy@amd.com>,
	<sshegde@linux.ibm.com>, <kprateek.nayak@amd.com>
Subject: Re: [RESEND][PATCH v3 1/1] sched: Report the different kinds of
 imbalances in /proc/schedstat
Message-ID: <ZkNHshuGhY6nBGmJ@chenyu5-mobl2>
References: <20240514044445.1409976-1-swapnil.sapkal@amd.com>
 <20240514044445.1409976-2-swapnil.sapkal@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240514044445.1409976-2-swapnil.sapkal@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nmKR00iYCPY0oiF1Pf6aSQ3gOfdZo2pu5HYVQMFRTm7tPc+hgmBAaFR18C1F?=
 =?us-ascii?Q?s1Cuy6mx404B6j9EMbXpqaKDmERXL+RuaFySVRPcnAoRh7NFRw/bmlXxSLs0?=
 =?us-ascii?Q?S0BN0bjIg8PFSTfsU9dpDyoefz36enq3j0B9OrnSoUZ71aG6zc+D/eoVL0c1?=
 =?us-ascii?Q?4pscVZcoRSTmlvlsA4MKY9iohlZ7zdKlvvmTSA0evZJT0dK97+ymnThu9o+H?=
 =?us-ascii?Q?o7PUoSri60QY9hQgyAWatMzo7Ms9De8HSWcqYRF3iFJ3iJB4Kb9jzYBkyHNs?=
 =?us-ascii?Q?eFoBO6267UkBJpuKgMvtgCXmNyAcrUmEvVye62SC0fXefkWWBL73cis8mR6N?=
 =?us-ascii?Q?pQ28uGuEiDjpLQJWKeod9W1xVh6oYStL209QI8lgQSGdz+hrNv6vTZdrkssh?=
 =?us-ascii?Q?/MqsT6mRCK6P52Cmzzh02BZJQamElq1hyCeqqdQ0oThMExqj+f8PUZoy7dPK?=
 =?us-ascii?Q?OVM3wsbt3dsK46n5QzqsJ/BB1GUcYURUgYVoF6wI9FEOPvZcwvyFwUfdVqtL?=
 =?us-ascii?Q?EOUBDSmjuTSLr5arX/y4hq4byGf8yDoYIJT3sr4NbyOkws2CfNP092aRSErI?=
 =?us-ascii?Q?uemCLplMs84sw5bMDR2tI9KSUDg2wK4WdVk12auV7Q+DeoHxE+2kfglHggc3?=
 =?us-ascii?Q?yiNXU1PojZtbkVsB94XTZ8ggbBOhhCZdiJh09aywMqtU8bv8W1SYFFk2cORL?=
 =?us-ascii?Q?A4YFCRIQifIKWlwM2GPAwaNncJa4kQL21XNuf8nnWYRRj56X0jTFYsYB5jqE?=
 =?us-ascii?Q?OofNeaI5zglYBlW7c+G1K+U3aeBVbzYEjLbqmQv+crTj1lJf8kJOtkRpG5IX?=
 =?us-ascii?Q?5PlvB3S7WGBItJ/M/GBDr4USQq3zC9Deknp1aaSFibTwS7zhnsWAwtRdJMG/?=
 =?us-ascii?Q?Sz0mV/pHSLv0g+j/qooNeaGKK03phRIlrg26azvnnIYcDTjLTw8Dli47wDwe?=
 =?us-ascii?Q?qjcrCIQ2O5Ayvwd1eOW292+VYCll7pK3P7r4Lqf/EdJVH6cjcUjVzwGKQBzf?=
 =?us-ascii?Q?2c9lGe1jZksZUMdgtS29mj7OWlrJrsrGqv6tJCCsMsX3ICO0Fps42KZ/XnXo?=
 =?us-ascii?Q?AeAuUbYjFzI7oVNBu1rYdP/AEpITv+Dv6tdBcVTm13jU1eDzU2hN+RInCA5W?=
 =?us-ascii?Q?oV/b7DDLllbQs8eFG+o6hX/cbIMwsaxb8w9GRpGWgndLzLbZFgflw1OozZw8?=
 =?us-ascii?Q?rkNRhsCTUic4E35MPJx6MI8huZoqLW3tEV+M0xvMN9xb5shzhSLTMRfPhdpU?=
 =?us-ascii?Q?jkxBa0jI/TBR1bqKqPO+9mBAKb+1Fg3LF1kdszvWL8wCmyEtGhwH/+faXvH+?=
 =?us-ascii?Q?HHM094xh4j3iO8XCVDiyyK4ciAv29uGnNWyvC7NKDIqLV9FasbM9um3dpQ3m?=
 =?us-ascii?Q?Yccp9UnS0qUd+Ny1Zwf+JEHCJm6H5CYaBDLtNGmdzLG8kZFXu9miiC2IjNZt?=
 =?us-ascii?Q?FfPoktCPw1Beuie2kYrjt+wSSLnCBTTwV4SF9N1weVs+N/KToEyt5igct1lF?=
 =?us-ascii?Q?SfkzBq+LOhA3zvKHOb6qHob8vuzGgyHB0RDaUkB9hfIZ673CytwpcCIGawYD?=
 =?us-ascii?Q?D3eb7g9XD0GYoR8EsRw/tIr93QOmgQzW/Z9npLej?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3fb363b6-b21a-466b-45b7-08dc7407235d
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6020.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2024 11:15:18.8305
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JvUSsY2PZvnnPhkcJXXMKvtRqWNlovNYIAgABSc9NTY3O+zgEu5By8ik3DVGAV5X9HhVkXZGBijAOkMiPfmr4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4701
X-OriginatorOrg: intel.com

On 2024-05-14 at 04:44:45 +0000, Swapnil Sapkal wrote:
> In /proc/schedstat, lb_imbalance reports the sum of imbalances
> discovered in sched domains with each call to sched_balance_rq(), which is
> not very useful because lb_imbalance does not mention whether the imbalance
> is due to load, utilization, nr_tasks or misfit_tasks. Remove this field
> from /proc/schedstat.
> 
> Currently there is no field in /proc/schedstat to report different types
> of imbalances. Introduce new fields in /proc/schedstat to report the
> total imbalances in load, utilization, nr_tasks or misfit_tasks.
> 
> Added fields to /proc/schedstat:
>  	- lb_imbalance_load: Total imbalance due to load.
> 	- lb_imbalance_util: Total imbalance due to utilization.
> 	- lb_imbalance_task: Total imbalance due to number of tasks.
> 	- lb_imbalance_misfit: Total imbalance due to misfit tasks.
> 
> Reviewed-by: Shrikanth Hegde <sshegde@linux.ibm.com>
> Signed-off-by: Swapnil Sapkal <swapnil.sapkal@amd.com>
> ---
>  Documentation/scheduler/sched-stats.rst | 121 ++++++++++++++----------
>  include/linux/sched/topology.h          |   5 +-
>  kernel/sched/fair.c                     |  21 +++-
>  kernel/sched/stats.c                    |   7 +-
>  4 files changed, 99 insertions(+), 55 deletions(-)

[...]

> diff --git a/kernel/sched/stats.c b/kernel/sched/stats.c
> index 78e48f5426ee..a02bc9db2f1c 100644
> --- a/kernel/sched/stats.c
> +++ b/kernel/sched/stats.c
> @@ -151,11 +151,14 @@ static int show_schedstat(struct seq_file *seq, void *v)
>  			seq_printf(seq, "domain%d %*pb", dcount++,
>  				   cpumask_pr_args(sched_domain_span(sd)));
>  			for (itype = 0; itype < CPU_MAX_IDLE_TYPES; itype++) {
> -				seq_printf(seq, " %u %u %u %u %u %u %u %u",
> +				seq_printf(seq, " %u %u %u %u %u %u %u %u %u %u %u",
>  				    sd->lb_count[itype],
>  				    sd->lb_balanced[itype],
>  				    sd->lb_failed[itype],
> -				    sd->lb_imbalance[itype],
> +				    sd->lb_imbalance_load[itype],
> +				    sd->lb_imbalance_util[itype],
> +				    sd->lb_imbalance_task[itype],
> +				    sd->lb_imbalance_misfit[itype],
>  				    sd->lb_gained[itype],
>  				    sd->lb_hot_gained[itype],
>  				    sd->lb_nobusyq[itype],

Do we need to increase SCHEDSTAT_VERSION to 16?

thanks,
Chenyu