Received-SPF: pass (google.com: domain of linux-kernel+bounces-178653-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 14 May 2024 20:15:15 +0800
From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org, linus.walleij@linaro.org
Subject: Re: [PATCH] gpiolib: cdev: fix uninitialised kfifo
Message-ID: <20240514121515.GA72688@rigel>
References: <20240510065342.36191-1-warthog618@gmail.com>
 <171534996897.34114.8159265536879918834.b4-ty@linaro.org>
 <20240514033656.GA24922@rigel>
 <CACMJSetivWMXNu9dJyMeJTfYSsQaez_7kSHce-5NJL6=72Rd0g@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACMJSetivWMXNu9dJyMeJTfYSsQaez_7kSHce-5NJL6=72Rd0g@mail.gmail.com>

On Tue, May 14, 2024 at 08:56:13AM +0200, Bartosz Golaszewski wrote:
> On Tue, 14 May 2024 at 05:37, Kent Gibson <warthog618@gmail.com> wrote:
> >
> > On Fri, May 10, 2024 at 04:06:16PM +0200, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > >
> > > On Fri, 10 May 2024 14:53:42 +0800, Kent Gibson wrote:
> > > > If a line is requested with debounce, and that results in debouncing
> > > > in software, and the line is subsequently reconfigured to enable edge
> > > > detection then the allocation of the kfifo to contain edge events is
> > > > overlooked.  This results in events being written to and read from an
> > > > unitialised kfifo.  Read events are returned to userspace.
> > > >
> > > > Initialise the kfifo in the case where the software debounce is
> > > > already active.
> > > >
> > > > [...]
> > >
> > > Applied, thanks!
> > >
> > > [1/1] gpiolib: cdev: fix uninitialised kfifo
> > >       commit: 3c1625fe5a2e0d68cd7b68156f02c1b5de09a161
> > >
> >
> > I've got a patch series to tidy this up and catch any similar errors
> > earlier going forward.
> > It is of course based on this patch, but that isn't in gpio/for-next yet.
> > How should I proceed?
> >
> > Cheers,
> > Kent.
>
> Pull in current master into gpio/for-next, apply your series, make
> sure it works and then wait until v6.10-rc1 is tagged because I won't
> be picking up anything during merge window.
>

Will do.

Thanks,
Kent.