Date: Thu, 31 Jan 2008 16:40:45 +0900
From: Paul Mundt <lethal@linux-sh.org>
To: Chris Snook <csnook@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Purpose of numa_node?
Message-ID: <20080131074045.GA13788@linux-sh.org>
Mail-Followup-To: Paul Mundt <lethal@linux-sh.org>,
	Chris Snook <csnook@redhat.com>, linux-kernel@vger.kernel.org
References: <47A11ACD.1090400@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <47A11ACD.1090400@redhat.com>
User-Agent: Mutt/1.5.13 (2006-08-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1531
Lines: 26

On Wed, Jan 30, 2008 at 07:48:13PM -0500, Chris Snook wrote:
> While pondering ways to optimize I/O and swapping on large NUMA machines, I 
> noticed that the numa_node field in struct device isn't actually used 
> anywhere. We just have a couple dozen lines of code to conditionally 
>  create a sysfs file that will always return -1.  Is anyone even working on 
> code to actually use this field?  I think it's a good piece of information 
> to keep track of, so I'm not suggesting we remove it, but I want to make 
> sure I'm not stepping on toes or duplicating effort if I try to make it 
> useful.
> 
It's manipulated with accessors. If you look at the users of
dev_to_node()/set_dev_node() you can see where it's being used. It's
primarily used in allocation paths for node locality, and the existing
set_dev_node() callsites are places where node locality information
already exists (ie, which node a given controller sits on). You can see
this in places like PCI (pcibus_to_node()) and USB, with node allocation
hints used in places like the dmapool and skb alloc paths.

The in-kernel use looks perfectly sane in that regard, though I'm not
sure what the point of exporting this as a RO attribute to userspace is.
Presumably someone has a tool somewhere that cares about this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/