Received-SPF: pass (google.com: domain of linux-kernel+bounces-178780-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
To: <johan@kernel.org>
CC: <andersson@kernel.org>, <andy.shevchenko@gmail.com>, <broonie@kernel.org>,
        <conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
        <johan+linaro@kernel.org>, <konrad.dybcio@linaro.org>,
        <krzk+dt@kernel.org>, <lee@kernel.org>, <lgirdwood@gmail.com>,
        <linus.walleij@linaro.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <quic_skakitap@quicinc.com>, <robh@kernel.org>, <swboyd@chromium.org>
Subject: Re: [PATCH 12/13] regulator: add pm8008 pmic regulator driver
Date: Tue, 14 May 2024 19:34:46 +0530
Message-ID: <20240514140446.706847-1-quic_skakitap@quicinc.com>
In-Reply-To: <ZjpMeVk_HiixZUEu@hovoldconsulting.com>
References: <ZjpMeVk_HiixZUEu@hovoldconsulting.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain

> On Thu, May 09, 2024 at 03:07:02PM +0300, Andy Shevchenko wrote:=0D
> > Wed, May 08, 2024 at 10:37:50PM +0000, Stephen Boyd kirjoitti:=0D
> > > Quoting Johan Hovold (2024-05-06 08:08:29)=0D
> > =0D
> > ...=0D
> > =0D
> > > > +               BUILD_BUG_ON((ARRAY_SIZE(pldo_ranges) !=3D 1) ||=0D
> > > =0D
> > > This should be an && not || right?=0D
> > =0D
> > > > +                               (ARRAY_SIZE(nldo_ranges) !=3D 1));=
=0D
> > =0D
> > In any case BUILD_BUG_ON() is not encouraged for such cases, it would b=
e much=0D
> > better to have a static_assert() near to one of those arrays.=0D
> =0D
> I think the reason it is placed here is that the above line reads:=0D
> =0D
> 	rdesc->n_linear_ranges =3D 1;=0D
> =0D
> and that would need to change if anyone expands the arrays.=0D
=0D
Correct. static_assert() cannot be used in the middle of code here, it can =
only be used at the declarations part which doesn't serve the purpose.=0D
So, BUILD_BUG_ON is the only way to go here.=