Received-SPF: pass (google.com: domain of linux-kernel+bounces-178799-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 14 May 2024 10:23:29 -0400
From: Frank Li <Frank.li@nxp.com>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com,
	sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, marex@denx.de,
	linux-clk@vger.kernel.org, imx@lists.linux.dev,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, p.zabel@pengutronix.de,
	shengjiu.wang@gmail.com
Subject: Re: [PATCH v3 2/6] reset: imx8mp-audiomix: Add AudioMix Block
 Control reset driver
Message-ID: <ZkNz4ZJ772mlScoj@lizhi-Precision-Tower-5810>
References: <1715679210-9588-1-git-send-email-shengjiu.wang@nxp.com>
 <1715679210-9588-3-git-send-email-shengjiu.wang@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1715679210-9588-3-git-send-email-shengjiu.wang@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?+DPgukLXdAFBqTqsG6Lp0GUbFtP42Julub+/jbUe7zx5bcaX73b3XROxSgV1?=
 =?us-ascii?Q?+AFpxzj6b6bY/bJkhlehwaH1YVxyIozXAVu7mILnCfVjJM2UME9NoS3TgKRZ?=
 =?us-ascii?Q?wBvs3l8rNfUlSFfZXCZKSZKX53CPHW0QnORmfDrv5CWDbSenMDn/2/UtZSfD?=
 =?us-ascii?Q?rsFQx4FOawTdkXAULOWebNUFnwCdTLltz2e5pm3juvTBC7DiWm2qHMM59wef?=
 =?us-ascii?Q?ID7ZQrDs1jmHugNQ05V2OLJ6vP3n7fGbNC7WDbN6JUahlLYm9nBfnN4iN115?=
 =?us-ascii?Q?94JXL4u9Vk/LBaCjJM1FdEJoF0ItHAvkWyR51nDcxGxk2grvxqe8pTCPQMEA?=
 =?us-ascii?Q?znYjmikmXXPA6Fb1YFk7TGgxn5N0OjJD91LXb/e2N6CBnTzqRYBNTVmLHBUt?=
 =?us-ascii?Q?UGRG8TGRCdJaC7aI6p3TzPNxFr/A+hZ5viQqRuAwN5fOVR8vli6KGs4daNU0?=
 =?us-ascii?Q?B08Ici+ATfI2zMBHkC4ci4NdBZdcM0D4dVHFTl7sJ2CmYps+o/noMjKZ8s+Y?=
 =?us-ascii?Q?uFBRmGv530eByDANzFUZYenQGqgMn5Ws2OaZXzQaO8FiJTWjSyAJHn1HbXFk?=
 =?us-ascii?Q?XQAhM0/GNYY9jEXWid6vH2n5RrmyoKPKFVSR3Ir5b5rPc1aD6HSQe+t764tL?=
 =?us-ascii?Q?NLDw6pC8+D/xgG53RBUCUpQiduOJk0OnSqbGclFUeXLkSucKIJ1eHY/mIMnP?=
 =?us-ascii?Q?jwLxYYC55asDL29EkIDbjEhz1oQ5uCPQMsqUDC8LQlv59bCTfSGnJbYYe0JO?=
 =?us-ascii?Q?CAU7iTGuEH6wEbkA1XQQRpmS4+26zprERlTKlQpGlVlQqV4LBj+XxbnWmULk?=
 =?us-ascii?Q?bHecSFh4Ffq7/Za3j0jML+EmE4masOE37ErCcPAeAeC80LJCdXsLvwoA/4aA?=
 =?us-ascii?Q?Vh90y3rjSEcuLD+HIlSPrs0zuAA4CuNkEt7pANbhbv5qRdfoxkdDblP67Xhe?=
 =?us-ascii?Q?pqFJPsTL7ALQqsqIfjQv7S2stob2TWGPcS9/He4OcZQl/VE6ymG4UF9f5fxu?=
 =?us-ascii?Q?4Tm2c4Wd4sIz6rLixWGDIY3fSNN3fZxgpQGkS6ckSnrlfRVXhxsoA8e2+CnI?=
 =?us-ascii?Q?YTvdBTY57e96lX7Pyvg5yNoQhMtlM/yG0NVbg7ybSm6ofe4/XWUJKjRztCF5?=
 =?us-ascii?Q?gUHREMxvn3wp6Pu/0fiGGJRg5bybO7pOJaFsElI8e3K5TPWVXOPFv93O9f/l?=
 =?us-ascii?Q?deOtQGo2F6P8z3deGdFhzyL6ElBuzsSH22gZVs4GBIPrJgyeIiJclrjlOvmH?=
 =?us-ascii?Q?i1KiIlh9eA55zWdXuLwwrDh7hSYfA2mYIvaZ+zVUQWoBZEfc0zAGsH2WoLkw?=
 =?us-ascii?Q?TTlfLyw82lnabviWzSKkoG54yrGa0z/Z1bah94UMjfwqwT/hLezZogy8Bidg?=
 =?us-ascii?Q?+PFctLcqkXNO5Qb+NV5AxaLK9qFJCG+ZECTnZLcQuMmuPOXjRH7TBa+G/2gT?=
 =?us-ascii?Q?geY4G8/W+ID7io0abRISazKs+zuY8agesTWCy0RLQaS7FM5XQniCjojEzjGF?=
 =?us-ascii?Q?5vyecWSFEZhQmaCeG6ZEVPAjdHG9poeJDARGDjWhvO9cAZvINN0UmQPl7k6I?=
 =?us-ascii?Q?eag0fHHgHss0CIma7OgHpC2bhA2OKMuGr/hSB0zT?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa44b5bc-a600-46f4-dcbf-08dc742173fb
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2024 14:23:41.0120
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: q9NNSVFG3Yy4C/4m+HmGGRZWNmkpcCAQh23GRYw26G4mE5XKNW9LacbwKk9Hcqf4vhQ0CWKtedP+Ew1fTiNNPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6853

On Tue, May 14, 2024 at 05:33:26PM +0800, Shengjiu Wang wrote:
> Audiomix block control can be a reset controller for
> Enhanced Audio Return Channel (EARC), which is one of
> modules in this audiomix subsystem.
> 
> The EARC PHY software reset and EARC controller software
> reset need to be supported.
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>  drivers/reset/Kconfig                 |   8 ++
>  drivers/reset/Makefile                |   1 +
>  drivers/reset/reset-imx8mp-audiomix.c | 117 ++++++++++++++++++++++++++

It is just some bit change. Can you reuse reset-ti-syscon.c ? 

Frank

>  3 files changed, 126 insertions(+)
>  create mode 100644 drivers/reset/reset-imx8mp-audiomix.c
> 
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 7112f5932609..0e7da0bb0a21 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -91,6 +91,14 @@ config RESET_IMX7
>  	help
>  	  This enables the reset controller driver for i.MX7 SoCs.
>  
> +config RESET_IMX8MP_AUDIOMIX
> +	tristate "i.MX8MP AudioMix Reset Driver"
> +	depends on HAS_IOMEM
> +	depends on (ARM64 && ARCH_MXC) || COMPILE_TEST
> +	select MFD_SYSCON
> +	help
> +	  This enables the reset controller driver for i.MX8MP AudioMix.
> +
>  config RESET_INTEL_GW
>  	bool "Intel Reset Controller Driver"
>  	depends on X86 || COMPILE_TEST
> diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
> index fd8b49fa46fc..a6796e83900b 100644
> --- a/drivers/reset/Makefile
> +++ b/drivers/reset/Makefile
> @@ -14,6 +14,7 @@ obj-$(CONFIG_RESET_BRCMSTB_RESCAL) += reset-brcmstb-rescal.o
>  obj-$(CONFIG_RESET_GPIO) += reset-gpio.o
>  obj-$(CONFIG_RESET_HSDK) += reset-hsdk.o
>  obj-$(CONFIG_RESET_IMX7) += reset-imx7.o
> +obj-$(CONFIG_RESET_IMX8MP_AUDIOMIX) += reset-imx8mp-audiomix.o
>  obj-$(CONFIG_RESET_INTEL_GW) += reset-intel-gw.o
>  obj-$(CONFIG_RESET_K210) += reset-k210.o
>  obj-$(CONFIG_RESET_LANTIQ) += reset-lantiq.o
> diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-imx8mp-audiomix.c
> new file mode 100644
> index 000000000000..8ba0d4406b36
> --- /dev/null
> +++ b/drivers/reset/reset-imx8mp-audiomix.c
> @@ -0,0 +1,117 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Copyright 2024 NXP
> + */
> +
> +#include <linux/mfd/syscon.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +#include <linux/pm_runtime.h>
> +#include <linux/regmap.h>
> +#include <linux/reset-controller.h>
> +
> +#define EARC			0x200
> +#define EARC_RESET_MASK		0x3
> +
> +struct imx8mp_audiomix_rst_priv {
> +	struct regmap *regmap;
> +	struct reset_controller_dev rcdev;
> +};
> +
> +static int imx8mp_audiomix_reset_set(struct reset_controller_dev *rcdev,
> +				     unsigned long id, bool assert)
> +{
> +	struct imx8mp_audiomix_rst_priv *priv = container_of(rcdev,
> +				struct imx8mp_audiomix_rst_priv, rcdev);
> +	unsigned int mask = BIT(id);
> +
> +	/* bit = 0 reset, bit = 1 unreset */
> +	if (assert)
> +		regmap_update_bits(priv->regmap, EARC, mask, 0);
> +	else
> +		regmap_update_bits(priv->regmap, EARC, mask, mask);
> +
> +	return 0;
> +}
> +
> +static int imx8mp_audiomix_reset_reset(struct reset_controller_dev *rcdev,
> +				       unsigned long id)
> +{
> +	imx8mp_audiomix_reset_set(rcdev, id, true);
> +
> +	return imx8mp_audiomix_reset_set(rcdev, id, false);
> +}
> +
> +static int imx8mp_audiomix_reset_assert(struct reset_controller_dev *rcdev,
> +					unsigned long id)
> +{
> +	return imx8mp_audiomix_reset_set(rcdev, id, true);
> +}
> +
> +static int imx8mp_audiomix_reset_deassert(struct reset_controller_dev *rcdev,
> +					  unsigned long id)
> +{
> +	return imx8mp_audiomix_reset_set(rcdev, id, false);
> +}
> +
> +static int imx8mp_audiomix_reset_xlate(struct reset_controller_dev *rcdev,
> +				       const struct of_phandle_args *reset_spec)
> +{
> +	unsigned long id = reset_spec->args[0];
> +
> +	if (!(BIT(id) & EARC_RESET_MASK))
> +		return -EINVAL;
> +
> +	return id;
> +}
> +
> +static const struct reset_control_ops imx8mp_audiomix_reset_ops = {
> +	.reset = imx8mp_audiomix_reset_reset,
> +	.assert = imx8mp_audiomix_reset_assert,
> +	.deassert = imx8mp_audiomix_reset_deassert,
> +};
> +
> +static int imx8mp_audiomix_reset_probe(struct platform_device *pdev)
> +{
> +	struct device_node *parent_np = of_get_parent(pdev->dev.of_node);
> +	struct imx8mp_audiomix_rst_priv *priv;
> +
> +	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
> +	if (!priv)
> +		return -ENOMEM;
> +
> +	priv->regmap = syscon_node_to_regmap(parent_np);
> +	of_node_put(parent_np);
> +	if (IS_ERR(priv->regmap))
> +		return PTR_ERR(priv->regmap);
> +
> +	priv->rcdev.owner     = THIS_MODULE;
> +	priv->rcdev.nr_resets = fls(EARC_RESET_MASK);
> +	priv->rcdev.ops       = &imx8mp_audiomix_reset_ops;
> +	priv->rcdev.of_node   = pdev->dev.of_node;
> +	priv->rcdev.dev	      = &pdev->dev;
> +	priv->rcdev.of_reset_n_cells = 1;
> +	priv->rcdev.of_xlate  = imx8mp_audiomix_reset_xlate;
> +
> +	return devm_reset_controller_register(&pdev->dev, &priv->rcdev);
> +}
> +
> +static const struct of_device_id imx8mp_audiomix_reset_dt_match[] = {
> +	{ .compatible = "fsl,imx8mp-audiomix-reset" },
> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, imx8mp_audiomix_reset_dt_match);
> +
> +static struct platform_driver imx8mp_audiomix_reset_driver = {
> +	.probe	= imx8mp_audiomix_reset_probe,
> +	.driver	= {
> +		.name = "imx8mp-audiomix-reset",
> +		.of_match_table = imx8mp_audiomix_reset_dt_match,
> +	},
> +};
> +module_platform_driver(imx8mp_audiomix_reset_driver);
> +
> +MODULE_AUTHOR("Shengjiu Wang <shengjiu.wang@nxp.com>");
> +MODULE_DESCRIPTION("Freescale i.MX8MP Audio Block Controller reset driver");
> +MODULE_LICENSE("GPL");
> -- 
> 2.34.1
>