Received-SPF: pass (google.com: domain of linux-kernel+bounces-178807-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <0eee0424-f177-808f-3a86-499443155ddb@ti.com>
Date: Tue, 14 May 2024 19:59:23 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] arm64: dts: ti: k3-am62x-sk-common: Reserve 128MiB of
 global CMA
Content-Language: en-US
From: Devarsh Thakkar <devarsht@ti.com>
To: Andrew Davis <afd@ti.com>, Nishanth Menon <nm@ti.com>,
        "Raghavendra,
 Vignesh" <vigneshr@ti.com>
CC: <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <a-bhatia1@ti.com>, <j-luthra@ti.com>,
        <praneeth@ti.com>, <j-choudhary@ti.com>, <gregkh@linuxfoundation.org>,
        Brandon <b-brnich@ti.com>, "Pothukuchi, Vijay" <vijayp@ti.com>,
        "Etheridge,
 Darren" <detheridge@ti.com>
References: <20230803111455.811339-1-devarsht@ti.com>
 <20230805193355.o657pwbq2w3tciui@vehicular>
 <9b61e8a0-fec0-b33f-259c-c744aa5a88b9@ti.com>
 <18bb47b8-c441-00b1-7ac7-f9038dffedc4@ti.com>
 <d2c6c120-5d3b-4975-5972-155343c1c0ca@ti.com>
In-Reply-To: <d2c6c120-5d3b-4975-5972-155343c1c0ca@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

Hi Andrew, Vignesh, Nishanth,

On 08/08/23 13:44, Devarsh Thakkar wrote:
[...]
>>>>> Reserve 128MiB of global CMA which is also marked as re-usable
>>>>> so that OS can also use the same if peripheral drivers are not using the
>>>>> same.
>>>>>

I wanted to re-initiate discussion on this. Per discussion with few of the
maintainers in OSS 2023 Summit, the suggestion was either to have MMU in the
devices or use the CMA region as done with this patch.
There was not much traction for the idea/suggestion to have some updates in
CMA API to dynamically increase the CMA region per the requirement (for e.g.
move the MIGRATE_MOVABLE pages to CMA area dynamically). Also I see some
efforts in the past made on that direction for introducing CMA_AGGRESSIVE
Kconfig to allocate from ZONE_MOVEABLE but were not accepted [1] and
nevertheless it still requires CMA region to be available to begin with and
only gives a bit of extra margin for the CMA.

My vote is still to use global cma region with re-usable flag (as done with
this patch) and 128 MiB is well estimated per the use-cases AM62x EVM is meant
to cater (the vendor specific kernel has been using it) and is very much
needed to provided out-of-box experience as otherwise basic display and camera
use-cases don't work out-of-box. Besides I see many other boards [presumably
mmu-less] using a similar approach :

     $git grep linux,cma-default arch/ | wc
     36      72    2538


Kindly let us know your opinion on this if we are aligned to proceed with this
approach or not.

[1]:
https://lore.kernel.org/all/20141107070655.GA3486@bbox/
https://linux-mm.kvack.narkive.com/LCGSAqAp/patch-0-4-cma-aggressive-make-cma-memory-be-more-aggressive-about-allocation


Regards
Devarsh