Received-SPF: pass (google.com: domain of linux-kernel+bounces-178801-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <e942abce-97ec-4bf1-8220-55bfed18c265@linux.ibm.com>
Date: Tue, 14 May 2024 19:53:58 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RESEND][PATCH v3 1/1] sched: Report the different kinds of
 imbalances in /proc/schedstat
To: Chen Yu <yu.c.chen@intel.com>, Swapnil Sapkal <swapnil.sapkal@amd.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, peterz@infradead.org,
        torvalds@linux-foundation.org, juri.lelli@redhat.com,
        dietmar.eggemann@arm.com, rostedt@goodmis.org, mgorman@suse.de,
        bristot@redhat.com, vschneid@redhat.com, vincent.guittot@linaro.org,
        gautham.shenoy@amd.com, kprateek.nayak@amd.com
References: <20240514044445.1409976-1-swapnil.sapkal@amd.com>
 <20240514044445.1409976-2-swapnil.sapkal@amd.com>
 <ZkNHshuGhY6nBGmJ@chenyu5-mobl2>
Content-Language: en-US
From: Shrikanth Hegde <sshegde@linux.ibm.com>
In-Reply-To: <ZkNHshuGhY6nBGmJ@chenyu5-mobl2>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 5/14/24 4:44 PM, Chen Yu wrote:
> On 2024-05-14 at 04:44:45 +0000, Swapnil Sapkal wrote:
>> In /proc/schedstat, lb_imbalance reports the sum of imbalances
>> discovered in sched domains with each call to sched_balance_rq(), which is
>> not very useful because lb_imbalance does not mention whether the imbalance
>> is due to load, utilization, nr_tasks or misfit_tasks. Remove this field
>> from /proc/schedstat.
>>
>> Currently there is no field in /proc/schedstat to report different types
>> of imbalances. Introduce new fields in /proc/schedstat to report the
>> total imbalances in load, utilization, nr_tasks or misfit_tasks.
>>
>> Added fields to /proc/schedstat:
>>  	- lb_imbalance_load: Total imbalance due to load.
>> 	- lb_imbalance_util: Total imbalance due to utilization.
>> 	- lb_imbalance_task: Total imbalance due to number of tasks.
>> 	- lb_imbalance_misfit: Total imbalance due to misfit tasks.
>>
>> Reviewed-by: Shrikanth Hegde <sshegde@linux.ibm.com>
>> Signed-off-by: Swapnil Sapkal <swapnil.sapkal@amd.com>
>> ---
>>  Documentation/scheduler/sched-stats.rst | 121 ++++++++++++++----------
>>  include/linux/sched/topology.h          |   5 +-
>>  kernel/sched/fair.c                     |  21 +++-
>>  kernel/sched/stats.c                    |   7 +-
>>  4 files changed, 99 insertions(+), 55 deletions(-)
> 
> [...]
> 
>> diff --git a/kernel/sched/stats.c b/kernel/sched/stats.c
>> index 78e48f5426ee..a02bc9db2f1c 100644
>> --- a/kernel/sched/stats.c
>> +++ b/kernel/sched/stats.c
>> @@ -151,11 +151,14 @@ static int show_schedstat(struct seq_file *seq, void *v)
>>  			seq_printf(seq, "domain%d %*pb", dcount++,
>>  				   cpumask_pr_args(sched_domain_span(sd)));
>>  			for (itype = 0; itype < CPU_MAX_IDLE_TYPES; itype++) {
>> -				seq_printf(seq, " %u %u %u %u %u %u %u %u",
>> +				seq_printf(seq, " %u %u %u %u %u %u %u %u %u %u %u",
>>  				    sd->lb_count[itype],
>>  				    sd->lb_balanced[itype],
>>  				    sd->lb_failed[itype],
>> -				    sd->lb_imbalance[itype],
>> +				    sd->lb_imbalance_load[itype],
>> +				    sd->lb_imbalance_util[itype],
>> +				    sd->lb_imbalance_task[itype],
>> +				    sd->lb_imbalance_misfit[itype],
>>  				    sd->lb_gained[itype],
>>  				    sd->lb_hot_gained[itype],
>>  				    sd->lb_nobusyq[itype],
> 
> Do we need to increase SCHEDSTAT_VERSION to 16?

It's been increased already as part of below commit 

commit 11b0bfa5d463b17cac5bf6b94fea4921713530c3
Author: Ingo Molnar <mingo@kernel.org>
Date:   Fri Mar 8 11:58:55 2024 +0100

    sched/debug: Increase SCHEDSTAT_VERSION to 16
    
    We changed the order of definitions within 'enum cpu_idle_type',
    which changed the order of [CPU_MAX_IDLE_TYPES] columns in
    show_schedstat().


> 
> thanks,
> Chenyu